mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Aleksandrs Vinarskis <alex@vinarskis.com>,
	Hans de Goede <hansg@kernel.org>, Lee Jones <lee@kernel.org>,
	Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-leds@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Aleksandrs Vinarskis <alex@vinarskis.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 2/2] leds: led-class: Add devicetree support to led_get()
Date: Wed, 3 Sep 2025 11:31:58 +0800	[thread overview]
Message-ID: <202509031142.WBnVOXZW-lkp@intel.com> (raw)
In-Reply-To: <010201990a1f6559-9e836a40-f534-4535-bd59-5e967d80559a-000000@eu-west-1.amazonses.com>

Hi Aleksandrs,

kernel test robot noticed the following build warnings:

[auto build test WARNING on lee-leds/for-leds-next]
[also build test WARNING on linus/master v6.17-rc4 next-20250902]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Aleksandrs-Vinarskis/leds-led-class-Add-devicetree-support-to-led_get/20250902-191342
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
patch link:    https://lore.kernel.org/r/010201990a1f6559-9e836a40-f534-4535-bd59-5e967d80559a-000000%40eu-west-1.amazonses.com
patch subject: [PATCH 2/2] leds: led-class: Add devicetree support to led_get()
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20250903/202509031142.WBnVOXZW-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250903/202509031142.WBnVOXZW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509031142.WBnVOXZW-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/leds/led-class.c:281:22: warning: no previous prototype for 'of_led_get' [-Wmissing-prototypes]
     281 | struct led_classdev *of_led_get(struct device_node *np, int index)
         |                      ^~~~~~~~~~


vim +/of_led_get +281 drivers/leds/led-class.c

   272	
   273	/**
   274	 * of_led_get() - request a LED device via the LED framework
   275	 * @np: device node to get the LED device from
   276	 * @index: the index of the LED
   277	 *
   278	 * Returns the LED device parsed from the phandle specified in the "leds"
   279	 * property of a device tree node or a negative error-code on failure.
   280	 */
 > 281	struct led_classdev *of_led_get(struct device_node *np, int index)
   282	{
   283		return __of_led_get(np, index, NULL);
   284	}
   285	EXPORT_SYMBOL_GPL(of_led_get);
   286	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      parent reply	other threads:[~2025-09-03  3:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250902-leds-v1-0-4a31e125276b@vinarskis.com>
2025-09-02 11:10 ` [PATCH 1/2] dt-bindings: leds: add generic LED consumer documentation Aleksandrs Vinarskis
2025-09-02 17:57   ` Rob Herring (Arm)
2025-09-02 18:21   ` Rob Herring
2025-09-03 23:56     ` Aleksandrs Vinarskis
2025-09-04  6:41       ` Krzysztof Kozlowski
2025-09-04  7:26         ` Hans de Goede
2025-09-04  9:45           ` Krzysztof Kozlowski
2025-09-04 10:29             ` Hans de Goede
2025-09-04 10:47               ` Krzysztof Kozlowski
2025-09-04 11:47                 ` Hans de Goede
2025-09-04 12:05                   ` Hans de Goede
2025-09-04 14:10                     ` Rob Herring
2025-09-04 22:52                       ` Aleksandrs Vinarskis
2025-09-02 11:10 ` [PATCH 2/2] leds: led-class: Add devicetree support to led_get() Aleksandrs Vinarskis
2025-09-02 12:25   ` Hans de Goede
2025-09-03 23:01     ` Aleksandrs Vinarskis
2025-09-04  7:08     ` Hans de Goede
2025-09-02 22:22   ` Linus Walleij
2025-09-03  6:58     ` Lee Jones
2025-09-03  3:31   ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202509031142.WBnVOXZW-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=alex@vinarskis.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hansg@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pavel@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®