* [PATCH] gpio: nomadik: wrap a local variable in a necessary ifdef
@ 2025-09-03 13:19 Bartosz Golaszewski
2025-09-04 14:31 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2025-09-03 13:19 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-arm-kernel, linux-gpio, linux-kernel, Bartosz Golaszewski,
kernel test robot
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
The 'desc' local variable in nmk_gpio_dbg_show_one() is now only used
with CONFIG_PINCTRL_NOMADIK enabled so wrap its declaration with an
appropriate ifdef.
Fixes: ddeb66d2cb10 ("gpio: nomadik: don't print out global GPIO numbers in debugfs callbacks")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202509032125.nXBcPuaf-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/gpio/gpio-nomadik.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c
index fde4b416faa8..97c5cd33279d 100644
--- a/drivers/gpio/gpio-nomadik.c
+++ b/drivers/gpio/gpio-nomadik.c
@@ -400,7 +400,9 @@ void nmk_gpio_dbg_show_one(struct seq_file *s, struct pinctrl_dev *pctldev,
struct gpio_chip *chip, unsigned int offset)
{
struct nmk_gpio_chip *nmk_chip = gpiochip_get_data(chip);
+#ifdef CONFIG_PINCTRL_NOMADIK
struct gpio_desc *desc;
+#endif
int mode;
bool is_out;
bool data_out;
--
2.48.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: nomadik: wrap a local variable in a necessary ifdef
2025-09-03 13:19 [PATCH] gpio: nomadik: wrap a local variable in a necessary ifdef Bartosz Golaszewski
@ 2025-09-04 14:31 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2025-09-04 14:31 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Bartosz Golaszewski, linux-arm-kernel, linux-gpio, linux-kernel,
kernel test robot
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Wed, 03 Sep 2025 15:19:03 +0200, Bartosz Golaszewski wrote:
> The 'desc' local variable in nmk_gpio_dbg_show_one() is now only used
> with CONFIG_PINCTRL_NOMADIK enabled so wrap its declaration with an
> appropriate ifdef.
>
>
Applied, thanks!
[1/1] gpio: nomadik: wrap a local variable in a necessary ifdef
(no commit info)
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-04 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-03 13:19 [PATCH] gpio: nomadik: wrap a local variable in a necessary ifdef Bartosz Golaszewski
2025-09-04 14:31 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®