* [PATCH v4 0/4] Remove unused bits from dts and add support for remaining pinctrl macros
@ 2025-09-04 11:22 Akashdeep Kaur
2025-09-04 11:22 ` [PATCH v4 1/4] arm64: dts: ti: k3-am62p5-sk: Remove the unused cfg in USB1_DRVVBUS Akashdeep Kaur
0 siblings, 1 reply; 3+ messages in thread
From: Akashdeep Kaur @ 2025-09-04 11:22 UTC (permalink / raw)
To: praneeth, nm, afd, vigneshr, d-gole, kristo, robh, krzk+dt,
conor+dt, linux-arm-kernel, devicetree, linux-kernel
Cc: vishalm, sebin.francis
This patch series cleans up the dts files to remove the pin control
DeepSleep configuration that does not take effect in hardware.
This series also adds the remaining macros in the pin control file
supported by SoC so that any configuration can be used as per requirement
in dts files.
Link to Previous Versions:
-V1: https://lore.kernel.org/linux-arm-kernel/20250731115631.3263798-1-a-kaur@ti.com/
-V2: https://lore.kernel.org/linux-arm-kernel/20250901122835.3022850-1-a-kaur@ti.com/
-V3: https://lore.kernel.org/linux-arm-kernel/20250902071917.1616729-1-a-kaur@ti.com/
Change Log:
V1-> V2:
-Added the macros that were removed earlier for backward compatibility
-Fixed the indentation
-Added documentation references in commit message
V2-> V3:
-Updated the commit message to be more descriptive and Clear
-Fixed errors introduced in previous version
V3->V4:
-Rearranged pinctrl macros so that all macros of same type are at same place
-Removed any redundant macros added in previous versions of the series
-Added new commit to fix the missing existing macro definition
Akashdeep Kaur (4):
arm64: dts: ti: k3-am62p5-sk: Remove the unused cfg in USB1_DRVVBUS
arm64: dts: ti: k3-am62x-sk-common: Remove the unused cfg in
USB1_DRVVBUS
arm64: dts: ti: k3-pinctrl: Add the remaining macros
arm64: dts: ti: k3-pinctrl: Fix the bug in existing macros
arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 +-
.../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 2 +-
arch/arm64/boot/dts/ti/k3-pinctrl.h | 51 +++++++++++++++++--
3 files changed, 50 insertions(+), 5 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v4 1/4] arm64: dts: ti: k3-am62p5-sk: Remove the unused cfg in USB1_DRVVBUS
2025-09-04 11:22 [PATCH v4 0/4] Remove unused bits from dts and add support for remaining pinctrl macros Akashdeep Kaur
@ 2025-09-04 11:22 ` Akashdeep Kaur
0 siblings, 0 replies; 3+ messages in thread
From: Akashdeep Kaur @ 2025-09-04 11:22 UTC (permalink / raw)
To: praneeth, nm, afd, vigneshr, d-gole, kristo, robh, krzk+dt,
conor+dt, linux-arm-kernel, devicetree, linux-kernel
Cc: vishalm, sebin.francis
After the SoC has entered the DeepSleep low power mode, USB1 can be used
to wakeup the SoC based on USB events triggered by USB devices. This
requires that the pin corresponding to the Type-A connector remains pulled
up even after the SoC has entered the DeepSleep low power mode.
For that, either DeepSleep pullup configuration can be selected or the pin
can have the same configuration that it had when SoC was in active mode.
But, in order for DeepSleep configuration to take effect, the DeepSleep
control bit has to be enabled.
Remove the unnecessary DeepSleep state configuration from USB1_DRVBUS pin,
as the DeepSleep control bit is not set and the active configuration is
sufficient to keep the pin pulled up. This simplifies the setup and removes
redundant configuration.
This reverts commit 115290c112952db27009668aa7ae2f29920704f0.
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Signed-off-by: Akashdeep Kaur <a-kaur@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
index 899da7896563..e8f0ac2c55e2 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
@@ -360,7 +360,7 @@ AM62PX_IOPAD(0x01b0, PIN_OUTPUT, 2) /* (G20) MCASP0_ACLKR.UART1_TXD */
main_usb1_pins_default: main-usb1-default-pins {
pinctrl-single,pins = <
- AM62PX_IOPAD(0x0258, PIN_INPUT | PIN_DS_PULLUD_ENABLE | PIN_DS_PULL_UP, 0) /* (G21) USB1_DRVVBUS */
+ AM62PX_IOPAD(0x0258, PIN_INPUT, 0) /* (G21) USB1_DRVVBUS */
>;
};
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v4 1/4] arm64: dts: ti: k3-am62p5-sk: Remove the unused cfg in USB1_DRVVBUS
2025-09-04 11:25 [PATCH v4 0/4] Remove unused bits from dts and add support for remaining pinctrl macros Akashdeep Kaur
@ 2025-09-04 11:25 ` Akashdeep Kaur
0 siblings, 0 replies; 3+ messages in thread
From: Akashdeep Kaur @ 2025-09-04 11:25 UTC (permalink / raw)
To: praneeth, nm, afd, vigneshr, d-gole, u-kumar1, sebin.francis,
kristo, robh, krzk+dt, conor+dt, linux-arm-kernel, devicetree,
linux-kernel
Cc: vishalm
After the SoC has entered the DeepSleep low power mode, USB1 can be used
to wakeup the SoC based on USB events triggered by USB devices. This
requires that the pin corresponding to the Type-A connector remains pulled
up even after the SoC has entered the DeepSleep low power mode.
For that, either DeepSleep pullup configuration can be selected or the pin
can have the same configuration that it had when SoC was in active mode.
But, in order for DeepSleep configuration to take effect, the DeepSleep
control bit has to be enabled.
Remove the unnecessary DeepSleep state configuration from USB1_DRVBUS pin,
as the DeepSleep control bit is not set and the active configuration is
sufficient to keep the pin pulled up. This simplifies the setup and removes
redundant configuration.
This reverts commit 115290c112952db27009668aa7ae2f29920704f0.
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Signed-off-by: Akashdeep Kaur <a-kaur@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
index 899da7896563..e8f0ac2c55e2 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
@@ -360,7 +360,7 @@ AM62PX_IOPAD(0x01b0, PIN_OUTPUT, 2) /* (G20) MCASP0_ACLKR.UART1_TXD */
main_usb1_pins_default: main-usb1-default-pins {
pinctrl-single,pins = <
- AM62PX_IOPAD(0x0258, PIN_INPUT | PIN_DS_PULLUD_ENABLE | PIN_DS_PULL_UP, 0) /* (G21) USB1_DRVVBUS */
+ AM62PX_IOPAD(0x0258, PIN_INPUT, 0) /* (G21) USB1_DRVVBUS */
>;
};
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-04 11:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-04 11:22 [PATCH v4 0/4] Remove unused bits from dts and add support for remaining pinctrl macros Akashdeep Kaur
2025-09-04 11:22 ` [PATCH v4 1/4] arm64: dts: ti: k3-am62p5-sk: Remove the unused cfg in USB1_DRVVBUS Akashdeep Kaur
2025-09-04 11:25 [PATCH v4 0/4] Remove unused bits from dts and add support for remaining pinctrl macros Akashdeep Kaur
2025-09-04 11:25 ` [PATCH v4 1/4] arm64: dts: ti: k3-am62p5-sk: Remove the unused cfg in USB1_DRVVBUS Akashdeep Kaur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®