Re: [PATCH net-next v7 3/3] net: dsa: yt921x: Add support for Motorcomm YT921x

[kernel test robot <lkp@intel.com>]

Hi David,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]
[also build test WARNING on linus/master v6.17-rc4 next-20250905]
[cannot apply to net-next/main horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Yang/dt-bindings-net-dsa-yt921x-Add-Motorcomm-YT921x-switch-support/20250906-021942
base:   net/main
patch link:    https://lore.kernel.org/r/20250905181728.3169479-4-mmyangfl%40gmail.com
patch subject: [PATCH net-next v7 3/3] net: dsa: yt921x: Add support for Motorcomm YT921x
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250906/202509061559.nSYmNbyV-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250906/202509061559.nSYmNbyV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509061559.nSYmNbyV-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/dsa/yt921x.c: In function 'yt921x_set_eee':
>> drivers/net/dsa/yt921x.c:1045:24: warning: unused variable 'dev' [-Wunused-variable]
    1045 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_port_change_mtu':
   drivers/net/dsa/yt921x.c:1110:24: warning: unused variable 'dev' [-Wunused-variable]
    1110 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_port_mirror_add':
   drivers/net/dsa/yt921x.c:1161:24: warning: unused variable 'dev' [-Wunused-variable]
    1161 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_port_fdb_dump':
   drivers/net/dsa/yt921x.c:1579:24: warning: unused variable 'dev' [-Wunused-variable]
    1579 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_set_ageing_time':
   drivers/net/dsa/yt921x.c:1611:24: warning: unused variable 'dev' [-Wunused-variable]
    1611 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_port_fdb_del':
   drivers/net/dsa/yt921x.c:1636:24: warning: unused variable 'dev' [-Wunused-variable]
    1636 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_port_fdb_add':
   drivers/net/dsa/yt921x.c:1651:24: warning: unused variable 'dev' [-Wunused-variable]
    1651 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_port_mdb_del':
   drivers/net/dsa/yt921x.c:1668:24: warning: unused variable 'dev' [-Wunused-variable]
    1668 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_port_mdb_add':
   drivers/net/dsa/yt921x.c:1686:24: warning: unused variable 'dev' [-Wunused-variable]
    1686 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_port_vlan_filtering':
   drivers/net/dsa/yt921x.c:1849:24: warning: unused variable 'dev' [-Wunused-variable]
    1849 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_port_vlan_del':
   drivers/net/dsa/yt921x.c:1867:24: warning: unused variable 'dev' [-Wunused-variable]
    1867 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_port_vlan_add':
   drivers/net/dsa/yt921x.c:1900:24: warning: unused variable 'dev' [-Wunused-variable]
    1900 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_port_bridge_flags':
   drivers/net/dsa/yt921x.c:2148:24: warning: unused variable 'dev' [-Wunused-variable]
    2148 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_port_bridge_join':
   drivers/net/dsa/yt921x.c:2187:24: warning: unused variable 'dev' [-Wunused-variable]
    2187 |         struct device *dev = to_device(priv);
         |                        ^~~
   drivers/net/dsa/yt921x.c: In function 'yt921x_dsa_port_setup':
   drivers/net/dsa/yt921x.c:2557:24: warning: unused variable 'dev' [-Wunused-variable]
    2557 |         struct device *dev = to_device(priv);
         |                        ^~~


vim +/dev +1045 drivers/net/dsa/yt921x.c

  1041	
  1042	static int
  1043	yt921x_set_eee(struct yt921x_priv *priv, int port, struct ethtool_keee *e)
  1044	{
> 1045		struct device *dev = to_device(priv);
  1046		bool enable = e->eee_enabled;
  1047		u16 new_mask;
  1048		int res;
  1049	
  1050		/* Enable / disable global EEE */
  1051		new_mask = priv->eee_ports_mask;
  1052		new_mask &= ~BIT(port);
  1053		new_mask |= !enable ? 0 : BIT(port);
  1054	
  1055		if (!!new_mask != !!priv->eee_ports_mask) {
  1056			res = yt921x_reg_toggle_bits(priv, YT921X_PON_STRAP_FUNC,
  1057						     YT921X_PON_STRAP_EEE, !!new_mask);
  1058			if (res)
  1059				return res;
  1060			res = yt921x_reg_toggle_bits(priv, YT921X_PON_STRAP_VAL,
  1061						     YT921X_PON_STRAP_EEE, !!new_mask);
  1062			if (res)
  1063				return res;
  1064		}
  1065	
  1066		priv->eee_ports_mask = new_mask;
  1067	
  1068		/* Enable / disable port EEE */
  1069		res = yt921x_reg_toggle_bits(priv, YT921X_EEE_CTRL,
  1070					     YT921X_EEE_CTRL_ENn(port), enable);
  1071		if (res)
  1072			return res;
  1073		res = yt921x_reg_toggle_bits(priv, YT921X_EEEn_VAL(port),
  1074					     YT921X_EEE_VAL_DATA, enable);
  1075		if (res)
  1076			return res;
  1077	
  1078		return 0;
  1079	}
  1080	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki