* [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
@ 2025-09-10 9:10 Huacai Chen
2025-09-11 0:59 ` kernel test robot
2025-09-20 23:48 ` Nathan Chancellor
0 siblings, 2 replies; 10+ messages in thread
From: Huacai Chen @ 2025-09-10 9:10 UTC (permalink / raw)
To: Huacai Chen
Cc: loongarch, Xuefeng Li, Guo Ren, Xuerui Wang, Jiaxun Yang,
linux-kernel, Huacai Chen, stable, Binbin Zhou, Xi Ruoyao
ARCH_STRICT_ALIGN is used for hardware without UAL, now it only control
the -mstrict-align flag. However, ACPI structures are packed by default
so will cause unaligned accesses.
To avoid this, define ACPI_MISALIGNMENT_NOT_SUPPORTED in asm/acenv.h to
align ACPI structures if ARCH_STRICT_ALIGN enabled.
Cc: stable@vger.kernel.org
Reported-by: Binbin Zhou <zhoubinbin@loongson.cn>
Suggested-by: Xi Ruoyao <xry111@xry111.site>
Suggested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
V2: Modify asm/acenv.h instead of Makefile.
arch/loongarch/include/asm/acenv.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/loongarch/include/asm/acenv.h b/arch/loongarch/include/asm/acenv.h
index 52f298f7293b..483c955f2ae5 100644
--- a/arch/loongarch/include/asm/acenv.h
+++ b/arch/loongarch/include/asm/acenv.h
@@ -10,9 +10,8 @@
#ifndef _ASM_LOONGARCH_ACENV_H
#define _ASM_LOONGARCH_ACENV_H
-/*
- * This header is required by ACPI core, but we have nothing to fill in
- * right now. Will be updated later when needed.
- */
+#ifdef CONFIG_ARCH_STRICT_ALIGN
+#define ACPI_MISALIGNMENT_NOT_SUPPORTED
+#endif /* CONFIG_ARCH_STRICT_ALIGN */
#endif /* _ASM_LOONGARCH_ACENV_H */
--
2.47.3
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
2025-09-10 9:10 [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled Huacai Chen
@ 2025-09-11 0:59 ` kernel test robot
2025-09-11 8:41 ` Huacai Chen
2025-09-20 23:48 ` Nathan Chancellor
1 sibling, 1 reply; 10+ messages in thread
From: kernel test robot @ 2025-09-11 0:59 UTC (permalink / raw)
To: Huacai Chen, Huacai Chen
Cc: oe-kbuild-all, loongarch, Xuefeng Li, Guo Ren, Xuerui Wang,
Jiaxun Yang, linux-kernel, stable, Binbin Zhou, Xi Ruoyao
Hi Huacai,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.17-rc5 next-20250910]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Huacai-Chen/LoongArch-Align-ACPI-structures-if-ARCH_STRICT_ALIGN-enabled/20250910-171140
base: linus/master
patch link: https://lore.kernel.org/r/20250910091033.725716-1-chenhuacai%40loongson.cn
patch subject: [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
config: loongarch-randconfig-001-20250911 (https://download.01.org/0day-ci/archive/20250911/202509110853.ASZKE1gv-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250911/202509110853.ASZKE1gv-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509110853.ASZKE1gv-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/acpi/acpi.h:24,
from drivers/acpi/acpica/tbprint.c:10:
drivers/acpi/acpica/tbprint.c: In function 'acpi_tb_print_table_header':
>> include/acpi/actypes.h:530:43: warning: 'strncmp' argument 1 declared attribute 'nonstring' is smaller than the specified bound 8 [-Wstringop-overread]
530 | #define ACPI_VALIDATE_RSDP_SIG(a) (!strncmp (ACPI_CAST_PTR (char, (a)), ACPI_SIG_RSDP, (sizeof(a) < 8) ? ACPI_NAMESEG_SIZE : 8))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/acpica/tbprint.c:105:20: note: in expansion of macro 'ACPI_VALIDATE_RSDP_SIG'
105 | } else if (ACPI_VALIDATE_RSDP_SIG(ACPI_CAST_PTR(struct acpi_table_rsdp,
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from include/acpi/acpi.h:26:
include/acpi/actbl.h:69:14: note: argument 'signature' declared here
69 | char signature[ACPI_NAMESEG_SIZE] ACPI_NONSTRING; /* ASCII table signature */
| ^~~~~~~~~
vim +530 include/acpi/actypes.h
cacba8657351f7 Lv Zheng 2013-09-23 529
64b9dfd0776e9c Ahmed Salem 2025-04-25 @530 #define ACPI_VALIDATE_RSDP_SIG(a) (!strncmp (ACPI_CAST_PTR (char, (a)), ACPI_SIG_RSDP, (sizeof(a) < 8) ? ACPI_NAMESEG_SIZE : 8))
4fa4616e279df8 Bob Moore 2015-07-01 531 #define ACPI_MAKE_RSDP_SIG(dest) (memcpy (ACPI_CAST_PTR (char, (dest)), ACPI_SIG_RSDP, 8))
cacba8657351f7 Lv Zheng 2013-09-23 532
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
2025-09-11 0:59 ` kernel test robot
@ 2025-09-11 8:41 ` Huacai Chen
0 siblings, 0 replies; 10+ messages in thread
From: Huacai Chen @ 2025-09-11 8:41 UTC (permalink / raw)
To: kernel test robot
Cc: Huacai Chen, oe-kbuild-all, loongarch, Xuefeng Li, Guo Ren,
Xuerui Wang, Jiaxun Yang, linux-kernel, stable, Binbin Zhou,
Xi Ruoyao
On Thu, Sep 11, 2025 at 9:00 AM kernel test robot <lkp@intel.com> wrote:
>
> Hi Huacai,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v6.17-rc5 next-20250910]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Huacai-Chen/LoongArch-Align-ACPI-structures-if-ARCH_STRICT_ALIGN-enabled/20250910-171140
> base: linus/master
> patch link: https://lore.kernel.org/r/20250910091033.725716-1-chenhuacai%40loongson.cn
> patch subject: [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
> config: loongarch-randconfig-001-20250911 (https://download.01.org/0day-ci/archive/20250911/202509110853.ASZKE1gv-lkp@intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 15.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250911/202509110853.ASZKE1gv-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202509110853.ASZKE1gv-lkp@intel.com/
This seems like a compiler issue...
https://github.com/AOSC-Tracking/linux/commit/1e9ee413357ef58dd902f6ec55013d2a2f2043eb
Huacai
>
> All warnings (new ones prefixed by >>):
>
> In file included from include/acpi/acpi.h:24,
> from drivers/acpi/acpica/tbprint.c:10:
> drivers/acpi/acpica/tbprint.c: In function 'acpi_tb_print_table_header':
> >> include/acpi/actypes.h:530:43: warning: 'strncmp' argument 1 declared attribute 'nonstring' is smaller than the specified bound 8 [-Wstringop-overread]
> 530 | #define ACPI_VALIDATE_RSDP_SIG(a) (!strncmp (ACPI_CAST_PTR (char, (a)), ACPI_SIG_RSDP, (sizeof(a) < 8) ? ACPI_NAMESEG_SIZE : 8))
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/acpi/acpica/tbprint.c:105:20: note: in expansion of macro 'ACPI_VALIDATE_RSDP_SIG'
> 105 | } else if (ACPI_VALIDATE_RSDP_SIG(ACPI_CAST_PTR(struct acpi_table_rsdp,
> | ^~~~~~~~~~~~~~~~~~~~~~
> In file included from include/acpi/acpi.h:26:
> include/acpi/actbl.h:69:14: note: argument 'signature' declared here
> 69 | char signature[ACPI_NAMESEG_SIZE] ACPI_NONSTRING; /* ASCII table signature */
> | ^~~~~~~~~
>
>
> vim +530 include/acpi/actypes.h
>
> cacba8657351f7 Lv Zheng 2013-09-23 529
> 64b9dfd0776e9c Ahmed Salem 2025-04-25 @530 #define ACPI_VALIDATE_RSDP_SIG(a) (!strncmp (ACPI_CAST_PTR (char, (a)), ACPI_SIG_RSDP, (sizeof(a) < 8) ? ACPI_NAMESEG_SIZE : 8))
> 4fa4616e279df8 Bob Moore 2015-07-01 531 #define ACPI_MAKE_RSDP_SIG(dest) (memcpy (ACPI_CAST_PTR (char, (dest)), ACPI_SIG_RSDP, 8))
> cacba8657351f7 Lv Zheng 2013-09-23 532
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
2025-09-10 9:10 [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled Huacai Chen
2025-09-11 0:59 ` kernel test robot
@ 2025-09-20 23:48 ` Nathan Chancellor
2025-09-21 1:07 ` Huacai Chen
1 sibling, 1 reply; 10+ messages in thread
From: Nathan Chancellor @ 2025-09-20 23:48 UTC (permalink / raw)
To: Huacai Chen
Cc: Huacai Chen, loongarch, Xuefeng Li, Guo Ren, Xuerui Wang,
Jiaxun Yang, linux-kernel, stable, Binbin Zhou, Xi Ruoyao
Hi Huacai,
On Wed, Sep 10, 2025 at 05:10:33PM +0800, Huacai Chen wrote:
> ARCH_STRICT_ALIGN is used for hardware without UAL, now it only control
> the -mstrict-align flag. However, ACPI structures are packed by default
> so will cause unaligned accesses.
>
> To avoid this, define ACPI_MISALIGNMENT_NOT_SUPPORTED in asm/acenv.h to
> align ACPI structures if ARCH_STRICT_ALIGN enabled.
>
> Cc: stable@vger.kernel.org
> Reported-by: Binbin Zhou <zhoubinbin@loongson.cn>
> Suggested-by: Xi Ruoyao <xry111@xry111.site>
> Suggested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
> V2: Modify asm/acenv.h instead of Makefile.
>
> arch/loongarch/include/asm/acenv.h | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/loongarch/include/asm/acenv.h b/arch/loongarch/include/asm/acenv.h
> index 52f298f7293b..483c955f2ae5 100644
> --- a/arch/loongarch/include/asm/acenv.h
> +++ b/arch/loongarch/include/asm/acenv.h
> @@ -10,9 +10,8 @@
> #ifndef _ASM_LOONGARCH_ACENV_H
> #define _ASM_LOONGARCH_ACENV_H
>
> -/*
> - * This header is required by ACPI core, but we have nothing to fill in
> - * right now. Will be updated later when needed.
> - */
> +#ifdef CONFIG_ARCH_STRICT_ALIGN
> +#define ACPI_MISALIGNMENT_NOT_SUPPORTED
> +#endif /* CONFIG_ARCH_STRICT_ALIGN */
>
> #endif /* _ASM_LOONGARCH_ACENV_H */
I am seeing several ACPI errors in my QEMU testing after this change in
Linus's tree as commit a9d13433fe17 ("LoongArch: Align ACPI structures
if ARCH_STRICT_ALIGN enabled").
$ make -skj"$(nproc)" ARCH=loongarch CROSS_COMPILE=loongarch64-linux- clean defconfig vmlinuz.efi
kernel/sched/fair.o: warning: objtool: sched_update_scaling() falls through to next function init_entity_runnable_average()
mm/mempolicy.o: warning: objtool: alloc_pages_bulk_mempolicy_noprof+0x380: stack state mismatch: reg1[30]=-1+0 reg2[30]=-2-80
lib/crypto/mpi/mpih-div.o: warning: objtool: mpihelp_divrem+0x2d0: stack state mismatch: reg1[22]=-1+0 reg2[22]=-2-16
In file included from include/acpi/acpi.h:24,
from drivers/acpi/acpica/tbprint.c:10:
drivers/acpi/acpica/tbprint.c: In function 'acpi_tb_print_table_header':
include/acpi/actypes.h:530:43: warning: 'strncmp' argument 1 declared attribute 'nonstring' is smaller than the specified bound 8 [-Wstringop-overread]
530 | #define ACPI_VALIDATE_RSDP_SIG(a) (!strncmp (ACPI_CAST_PTR (char, (a)), ACPI_SIG_RSDP, (sizeof(a) < 8) ? ACPI_NAMESEG_SIZE : 8))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/acpica/tbprint.c:105:20: note: in expansion of macro 'ACPI_VALIDATE_RSDP_SIG'
105 | } else if (ACPI_VALIDATE_RSDP_SIG(ACPI_CAST_PTR(struct acpi_table_rsdp,
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from include/acpi/acpi.h:26:
include/acpi/actbl.h:69:14: note: argument 'signature' declared here
69 | char signature[ACPI_NAMESEG_SIZE] ACPI_NONSTRING; /* ASCII table signature */
| ^~~~~~~~~
$ curl -LSso /tmp/loongarch-QEMU_EFI.fd https://github.com/loongson/Firmware/raw/main/LoongArchVirtMachine/QEMU_EFI.fd
$ curl -LSs https://github.com/ClangBuiltLinux/boot-utils/releases/download/20241120-044434/loongarch-rootfs.cpio.zst | zstd -d >/tmp/rootfs.cpio
$ sha256sum /tmp/loongarch-QEMU_EFI.fd /tmp/rootfs.cpio
b375639ebcf7a873d2cab67f0c9c1c6c208fc3f1bcba4083172fa20c4fb7e1ab /tmp/loongarch-QEMU_EFI.fd
1c17c9a4ea823931446fca5f5323b8e9384ba88b48d679e394ec5d4f6e258793 /tmp/rootfs.cpio
$ qemu-system-loongarch64 --version | head -1
QEMU emulator version 10.1.0 (qemu-10.1.0-8.fc44)
# Filtered by "ACPI" and "Linux version"
$ qemu-system-loongarch64 \
-display none \
-nodefaults \
-M virt \
-cpu la464 \
-bios /tmp/loongarch-QEMU_EFI.fd \
-no-reboot \
-append console=ttyS0,115200 \
-kernel arch/loongarch/boot/vmlinuz.efi \
-initrd /tmp/rootfs.cpio \
-m 2G \
-smp 2 \
-serial mon:stdio
[ 0.000000] Linux version 6.17.0-rc6+ (nathan@aadp) (loongarch64-linux-gcc (GCC) 15.2.0, GNU ld (GNU Binutils) 2.45) #1 SMP PREEMPT_DYNAMIC Sat Sep 20 16:24:42 MST 2025
[ 0.000000] efi: SMBIOS=0xf3c0000 SMBIOS 3.0=0xdd50000 MEMATTR=0xe832118 ACPI=0xe12f000 ACPI 2.0=0xe12f014 INITRD=0xe125f18 MEMRESERVE=0xe125f98 MEMMAP=0xe122018
[ 0.000000] ACPI: Early table checksum verification disabled
[ 0.000000] ACPI: RSDP 0x000000000E12F014 000024 (v02 BOCHS )
[ 0.000000] ACPI: XSDT 0x000000000E12E0E8 000054 (v01 BOCHS BXPC 00000001 01000013)
[ 0.000000] ACPI: FACP 0x000000000E12B000 00010C (v05 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: DSDT 0x000000000E12C000 00125D (v01 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: FACS 0x000000000C770000 000040
[ 0.000000] ACPI: APIC 0x000000000E12A000 00007B (v01 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: PPTT 0x000000000E129000 000074 (v02 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: SRAT 0x000000000E128000 0000A0 (v01 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: SPCR 0x000000000E127000 000050 (v02 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: MCFG 0x000000000E126000 00003C (v01 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: SPCR: console: uart,mmio,0x1fe001e0,115200
[ 0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x00000000-0x0fffffff]
[ 0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x80000000-0xefffffff]
[ 0.014877] ACPI: Core revision 20250404
[ 0.854788] ACPI: Added _OSI(Module Device)
[ 0.854920] ACPI: Added _OSI(Processor Device)
[ 0.854935] ACPI: Added _OSI(Processor Aggregator Device)
[ 0.885597] ACPI: 1 ACPI AML tables successfully acquired and loaded
[ 0.906695] ACPI: Interpreter enabled
[ 0.910327] ACPI: PM: (supports S0 S5)
[ 0.910495] ACPI: Using LPIC for interrupt routing
[ 0.911650] ACPI: MCFG table detected, 1 entries
[ 0.925560] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
[ 0.928083] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 0.930036] ACPI Error: Aborting method \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 0.930585] ACPI Error: Method execution failed \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/uteval-68)
[ 0.931693] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
[ 0.931878] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 0.932035] ACPI Error: Aborting method \_SB.CPUS.C001._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 0.932171] ACPI Error: Method execution failed \_SB.CPUS.C001._STA due to previous error (AE_AML_ALIGNMENT) (20250404/uteval-68)
[ 0.969018] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
[ 0.969139] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 0.969238] ACPI Error: Aborting method \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 0.971203] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
[ 0.971307] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 0.971399] ACPI Error: Aborting method \_SB.CPUS.C001._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 0.992513] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
[ 0.992762] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 0.993027] ACPI Error: Aborting method \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 0.993511] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
[ 0.993593] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 0.993664] ACPI Error: Aborting method \_SB.CPUS.C001._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 0.994569] ACPI: PCI: Interrupt link L000 configured for IRQ 80
[ 0.994887] ACPI: PCI: Interrupt link L001 configured for IRQ 81
[ 0.995038] ACPI: PCI: Interrupt link L002 configured for IRQ 82
[ 0.995167] ACPI: PCI: Interrupt link L003 configured for IRQ 83
[ 0.998540] ACPI: PCI Root Bridge [PCI0] (domain 0000 [bus 00-7f])
[ 1.009539] ACPI: Remapped I/O 0x0000000018004000 to [io 0x0000-0xbfff window]
[ 1.039462] ACPI: bus type USB registered
[ 1.125150] pnp: PnP ACPI init
[ 1.135025] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
[ 1.135162] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 1.135433] ACPI Error: Aborting method \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 1.135539] ACPI Error: Method execution failed \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/uteval-68)
[ 1.136219] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
[ 1.136328] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 1.136426] ACPI Error: Aborting method \_SB.CPUS.C001._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
[ 1.136516] ACPI Error: Method execution failed \_SB.CPUS.C001._STA due to previous error (AE_AML_ALIGNMENT) (20250404/uteval-68)
[ 1.144655] pnp: PnP ACPI: found 5 devices
[ 1.316259] ACPI: bus type thunderbolt registered
[ 1.441002] ACPI: button: Power Button [PWRB]
[ 1.719602] ACPI: bus type drm_connector registered
[ 8.642000] ACPI: PM: Preparing to enter system sleep state S5
At the parent change, this is all I see for ACPI messages.
[ 0.000000] efi: SMBIOS=0xf3c0000 SMBIOS 3.0=0xdd50000 MEMATTR=0xe832118 ACPI=0xe12f000 ACPI 2.0=0xe12f014 INITRD=0xe125f18 MEMRESERVE=0xe125f98 MEMMAP=0xe122018
[ 0.000000] ACPI: Early table checksum verification disabled
[ 0.000000] ACPI: RSDP 0x000000000E12F014 000024 (v02 BOCHS )
[ 0.000000] ACPI: XSDT 0x000000000E12E0E8 000054 (v01 BOCHS BXPC 00000001 01000013)
[ 0.000000] ACPI: FACP 0x000000000E12B000 00010C (v05 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: DSDT 0x000000000E12C000 00125D (v01 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: FACS 0x000000000C770000 000040
[ 0.000000] ACPI: APIC 0x000000000E12A000 00007B (v01 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: PPTT 0x000000000E129000 000074 (v02 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: SRAT 0x000000000E128000 0000A0 (v01 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: SPCR 0x000000000E127000 000050 (v02 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: MCFG 0x000000000E126000 00003C (v01 BOCHS BXPC 00000001 BXPC 00000001)
[ 0.000000] ACPI: SPCR: console: uart,mmio,0x1fe001e0,115200
[ 0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x00000000-0x0fffffff]
[ 0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x80000000-0xefffffff]
[ 0.014597] ACPI: Core revision 20250404
[ 0.915706] ACPI: Added _OSI(Module Device)
[ 0.915755] ACPI: Added _OSI(Processor Device)
[ 0.915764] ACPI: Added _OSI(Processor Aggregator Device)
[ 0.945135] ACPI: 1 ACPI AML tables successfully acquired and loaded
[ 0.960197] ACPI: Interpreter enabled
[ 0.961985] ACPI: PM: (supports S0 S5)
[ 0.962069] ACPI: Using LPIC for interrupt routing
[ 0.962718] ACPI: MCFG table detected, 1 entries
[ 1.013706] ACPI: PCI: Interrupt link L000 configured for IRQ 80
[ 1.013966] ACPI: PCI: Interrupt link L001 configured for IRQ 81
[ 1.014076] ACPI: PCI: Interrupt link L002 configured for IRQ 82
[ 1.014176] ACPI: PCI: Interrupt link L003 configured for IRQ 83
[ 1.014977] ACPI: PCI Root Bridge [PCI0] (domain 0000 [bus 00-7f])
[ 1.022475] ACPI: Remapped I/O 0x0000000018004000 to [io 0x0000-0xbfff window]
[ 1.058781] ACPI: bus type USB registered
[ 1.125533] pnp: PnP ACPI init
[ 1.140430] pnp: PnP ACPI: found 5 devices
[ 1.270053] ACPI: bus type thunderbolt registered
[ 1.382724] ACPI: button: Power Button [PWRB]
[ 1.673533] ACPI: bus type drm_connector registered
[ 8.715507] ACPI: PM: Preparing to enter system sleep state S5
Is this expected?
Cheers,
Nathan
# bad: [3b08f56fbbb9ef75c7454487f8d3db80a84deef7] Merge tag 'x86-urgent-2025-09-20' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
# good: [f83ec76bf285bea5727f478a68b894f5543ca76e] Linux 6.17-rc6
git bisect start '3b08f56fbbb9ef75c7454487f8d3db80a84deef7' 'v6.17-rc6'
# good: [cbf658dd09419f1ef9de11b9604e950bdd5c170b] Merge tag 'net-6.17-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
git bisect good cbf658dd09419f1ef9de11b9604e950bdd5c170b
# good: [e8442d5b7bc6338d553040f5b1f7bd43f5ab30e0] Merge tag 'sound-6.17-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
git bisect good e8442d5b7bc6338d553040f5b1f7bd43f5ab30e0
# bad: [ffa7119cd1294dc1814e582dc07ffeb953ae7b26] Merge tag 'mmc-v6.17-rc2-2' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc
git bisect bad ffa7119cd1294dc1814e582dc07ffeb953ae7b26
# bad: [8dc5245673cf7f33743e5c0d2a4207c0b8df3067] LoongArch: KVM: Avoid copy_*_user() with lock hold in kvm_pch_pic_regs_access()
git bisect bad 8dc5245673cf7f33743e5c0d2a4207c0b8df3067
# bad: [d6d69f0edde63b553345d4efaceb7daed89fe04c] LoongArch: Replace sprintf() with sysfs_emit()
git bisect bad d6d69f0edde63b553345d4efaceb7daed89fe04c
# good: [74f8295c6fb8436bec9995baf6ba463151b6fb68] LoongArch: Handle jump tables options for RUST
git bisect good 74f8295c6fb8436bec9995baf6ba463151b6fb68
# bad: [a9d13433fe17be0e867e51e71a1acd2731fbef8d] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
git bisect bad a9d13433fe17be0e867e51e71a1acd2731fbef8d
# good: [f5003098e2f337d8e8a87dc636250e3fa978d9ad] LoongArch: Update help info of ARCH_STRICT_ALIGN
git bisect good f5003098e2f337d8e8a87dc636250e3fa978d9ad
# first bad commit: [a9d13433fe17be0e867e51e71a1acd2731fbef8d] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
2025-09-20 23:48 ` Nathan Chancellor
@ 2025-09-21 1:07 ` Huacai Chen
2025-09-26 14:31 ` Guenter Roeck
0 siblings, 1 reply; 10+ messages in thread
From: Huacai Chen @ 2025-09-21 1:07 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Huacai Chen, loongarch, Xuefeng Li, Guo Ren, Xuerui Wang,
Jiaxun Yang, linux-kernel, stable, Binbin Zhou, Xi Ruoyao
Hi, Nathan,
On Sun, Sep 21, 2025 at 7:48 AM Nathan Chancellor <nathan@kernel.org> wrote:
>
> Hi Huacai,
>
> On Wed, Sep 10, 2025 at 05:10:33PM +0800, Huacai Chen wrote:
> > ARCH_STRICT_ALIGN is used for hardware without UAL, now it only control
> > the -mstrict-align flag. However, ACPI structures are packed by default
> > so will cause unaligned accesses.
> >
> > To avoid this, define ACPI_MISALIGNMENT_NOT_SUPPORTED in asm/acenv.h to
> > align ACPI structures if ARCH_STRICT_ALIGN enabled.
> >
> > Cc: stable@vger.kernel.org
> > Reported-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > Suggested-by: Xi Ruoyao <xry111@xry111.site>
> > Suggested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> > ---
> > V2: Modify asm/acenv.h instead of Makefile.
> >
> > arch/loongarch/include/asm/acenv.h | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/loongarch/include/asm/acenv.h b/arch/loongarch/include/asm/acenv.h
> > index 52f298f7293b..483c955f2ae5 100644
> > --- a/arch/loongarch/include/asm/acenv.h
> > +++ b/arch/loongarch/include/asm/acenv.h
> > @@ -10,9 +10,8 @@
> > #ifndef _ASM_LOONGARCH_ACENV_H
> > #define _ASM_LOONGARCH_ACENV_H
> >
> > -/*
> > - * This header is required by ACPI core, but we have nothing to fill in
> > - * right now. Will be updated later when needed.
> > - */
> > +#ifdef CONFIG_ARCH_STRICT_ALIGN
> > +#define ACPI_MISALIGNMENT_NOT_SUPPORTED
> > +#endif /* CONFIG_ARCH_STRICT_ALIGN */
> >
> > #endif /* _ASM_LOONGARCH_ACENV_H */
>
> I am seeing several ACPI errors in my QEMU testing after this change in
> Linus's tree as commit a9d13433fe17 ("LoongArch: Align ACPI structures
> if ARCH_STRICT_ALIGN enabled").
>
> $ make -skj"$(nproc)" ARCH=loongarch CROSS_COMPILE=loongarch64-linux- clean defconfig vmlinuz.efi
> kernel/sched/fair.o: warning: objtool: sched_update_scaling() falls through to next function init_entity_runnable_average()
> mm/mempolicy.o: warning: objtool: alloc_pages_bulk_mempolicy_noprof+0x380: stack state mismatch: reg1[30]=-1+0 reg2[30]=-2-80
> lib/crypto/mpi/mpih-div.o: warning: objtool: mpihelp_divrem+0x2d0: stack state mismatch: reg1[22]=-1+0 reg2[22]=-2-16
> In file included from include/acpi/acpi.h:24,
> from drivers/acpi/acpica/tbprint.c:10:
> drivers/acpi/acpica/tbprint.c: In function 'acpi_tb_print_table_header':
> include/acpi/actypes.h:530:43: warning: 'strncmp' argument 1 declared attribute 'nonstring' is smaller than the specified bound 8 [-Wstringop-overread]
> 530 | #define ACPI_VALIDATE_RSDP_SIG(a) (!strncmp (ACPI_CAST_PTR (char, (a)), ACPI_SIG_RSDP, (sizeof(a) < 8) ? ACPI_NAMESEG_SIZE : 8))
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/acpi/acpica/tbprint.c:105:20: note: in expansion of macro 'ACPI_VALIDATE_RSDP_SIG'
> 105 | } else if (ACPI_VALIDATE_RSDP_SIG(ACPI_CAST_PTR(struct acpi_table_rsdp,
> | ^~~~~~~~~~~~~~~~~~~~~~
> In file included from include/acpi/acpi.h:26:
> include/acpi/actbl.h:69:14: note: argument 'signature' declared here
> 69 | char signature[ACPI_NAMESEG_SIZE] ACPI_NONSTRING; /* ASCII table signature */
> | ^~~~~~~~~
From this link this seems a comiler issue (at least not an
arch-specific kernel issue):
https://github.com/AOSC-Tracking/linux/commit/1e9ee413357ef58dd902f6ec55013d2a2f2043eb
>
> $ curl -LSso /tmp/loongarch-QEMU_EFI.fd https://github.com/loongson/Firmware/raw/main/LoongArchVirtMachine/QEMU_EFI.fd
>
> $ curl -LSs https://github.com/ClangBuiltLinux/boot-utils/releases/download/20241120-044434/loongarch-rootfs.cpio.zst | zstd -d >/tmp/rootfs.cpio
>
> $ sha256sum /tmp/loongarch-QEMU_EFI.fd /tmp/rootfs.cpio
> b375639ebcf7a873d2cab67f0c9c1c6c208fc3f1bcba4083172fa20c4fb7e1ab /tmp/loongarch-QEMU_EFI.fd
> 1c17c9a4ea823931446fca5f5323b8e9384ba88b48d679e394ec5d4f6e258793 /tmp/rootfs.cpio
>
> $ qemu-system-loongarch64 --version | head -1
> QEMU emulator version 10.1.0 (qemu-10.1.0-8.fc44)
>
> # Filtered by "ACPI" and "Linux version"
> $ qemu-system-loongarch64 \
> -display none \
> -nodefaults \
> -M virt \
> -cpu la464 \
> -bios /tmp/loongarch-QEMU_EFI.fd \
> -no-reboot \
> -append console=ttyS0,115200 \
> -kernel arch/loongarch/boot/vmlinuz.efi \
> -initrd /tmp/rootfs.cpio \
> -m 2G \
> -smp 2 \
> -serial mon:stdio
> [ 0.000000] Linux version 6.17.0-rc6+ (nathan@aadp) (loongarch64-linux-gcc (GCC) 15.2.0, GNU ld (GNU Binutils) 2.45) #1 SMP PREEMPT_DYNAMIC Sat Sep 20 16:24:42 MST 2025
> [ 0.000000] efi: SMBIOS=0xf3c0000 SMBIOS 3.0=0xdd50000 MEMATTR=0xe832118 ACPI=0xe12f000 ACPI 2.0=0xe12f014 INITRD=0xe125f18 MEMRESERVE=0xe125f98 MEMMAP=0xe122018
> [ 0.000000] ACPI: Early table checksum verification disabled
> [ 0.000000] ACPI: RSDP 0x000000000E12F014 000024 (v02 BOCHS )
> [ 0.000000] ACPI: XSDT 0x000000000E12E0E8 000054 (v01 BOCHS BXPC 00000001 01000013)
> [ 0.000000] ACPI: FACP 0x000000000E12B000 00010C (v05 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: DSDT 0x000000000E12C000 00125D (v01 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: FACS 0x000000000C770000 000040
> [ 0.000000] ACPI: APIC 0x000000000E12A000 00007B (v01 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: PPTT 0x000000000E129000 000074 (v02 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: SRAT 0x000000000E128000 0000A0 (v01 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: SPCR 0x000000000E127000 000050 (v02 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: MCFG 0x000000000E126000 00003C (v01 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: SPCR: console: uart,mmio,0x1fe001e0,115200
> [ 0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x00000000-0x0fffffff]
> [ 0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x80000000-0xefffffff]
> [ 0.014877] ACPI: Core revision 20250404
> [ 0.854788] ACPI: Added _OSI(Module Device)
> [ 0.854920] ACPI: Added _OSI(Processor Device)
> [ 0.854935] ACPI: Added _OSI(Processor Aggregator Device)
> [ 0.885597] ACPI: 1 ACPI AML tables successfully acquired and loaded
> [ 0.906695] ACPI: Interpreter enabled
> [ 0.910327] ACPI: PM: (supports S0 S5)
> [ 0.910495] ACPI: Using LPIC for interrupt routing
> [ 0.911650] ACPI: MCFG table detected, 1 entries
> [ 0.925560] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
> [ 0.928083] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 0.930036] ACPI Error: Aborting method \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 0.930585] ACPI Error: Method execution failed \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/uteval-68)
> [ 0.931693] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
> [ 0.931878] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 0.932035] ACPI Error: Aborting method \_SB.CPUS.C001._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 0.932171] ACPI Error: Method execution failed \_SB.CPUS.C001._STA due to previous error (AE_AML_ALIGNMENT) (20250404/uteval-68)
> [ 0.969018] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
> [ 0.969139] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 0.969238] ACPI Error: Aborting method \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 0.971203] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
> [ 0.971307] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 0.971399] ACPI Error: Aborting method \_SB.CPUS.C001._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 0.992513] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
> [ 0.992762] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 0.993027] ACPI Error: Aborting method \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 0.993511] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
> [ 0.993593] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 0.993664] ACPI Error: Aborting method \_SB.CPUS.C001._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 0.994569] ACPI: PCI: Interrupt link L000 configured for IRQ 80
> [ 0.994887] ACPI: PCI: Interrupt link L001 configured for IRQ 81
> [ 0.995038] ACPI: PCI: Interrupt link L002 configured for IRQ 82
> [ 0.995167] ACPI: PCI: Interrupt link L003 configured for IRQ 83
> [ 0.998540] ACPI: PCI Root Bridge [PCI0] (domain 0000 [bus 00-7f])
> [ 1.009539] ACPI: Remapped I/O 0x0000000018004000 to [io 0x0000-0xbfff window]
> [ 1.039462] ACPI: bus type USB registered
> [ 1.125150] pnp: PnP ACPI init
> [ 1.135025] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
> [ 1.135162] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 1.135433] ACPI Error: Aborting method \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 1.135539] ACPI Error: Method execution failed \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/uteval-68)
> [ 1.136219] ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
> [ 1.136328] ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 1.136426] ACPI Error: Aborting method \_SB.CPUS.C001._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> [ 1.136516] ACPI Error: Method execution failed \_SB.CPUS.C001._STA due to previous error (AE_AML_ALIGNMENT) (20250404/uteval-68)
> [ 1.144655] pnp: PnP ACPI: found 5 devices
> [ 1.316259] ACPI: bus type thunderbolt registered
> [ 1.441002] ACPI: button: Power Button [PWRB]
> [ 1.719602] ACPI: bus type drm_connector registered
> [ 8.642000] ACPI: PM: Preparing to enter system sleep state S5
>
> At the parent change, this is all I see for ACPI messages.
>
> [ 0.000000] efi: SMBIOS=0xf3c0000 SMBIOS 3.0=0xdd50000 MEMATTR=0xe832118 ACPI=0xe12f000 ACPI 2.0=0xe12f014 INITRD=0xe125f18 MEMRESERVE=0xe125f98 MEMMAP=0xe122018
> [ 0.000000] ACPI: Early table checksum verification disabled
> [ 0.000000] ACPI: RSDP 0x000000000E12F014 000024 (v02 BOCHS )
> [ 0.000000] ACPI: XSDT 0x000000000E12E0E8 000054 (v01 BOCHS BXPC 00000001 01000013)
> [ 0.000000] ACPI: FACP 0x000000000E12B000 00010C (v05 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: DSDT 0x000000000E12C000 00125D (v01 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: FACS 0x000000000C770000 000040
> [ 0.000000] ACPI: APIC 0x000000000E12A000 00007B (v01 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: PPTT 0x000000000E129000 000074 (v02 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: SRAT 0x000000000E128000 0000A0 (v01 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: SPCR 0x000000000E127000 000050 (v02 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: MCFG 0x000000000E126000 00003C (v01 BOCHS BXPC 00000001 BXPC 00000001)
> [ 0.000000] ACPI: SPCR: console: uart,mmio,0x1fe001e0,115200
> [ 0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x00000000-0x0fffffff]
> [ 0.000000] ACPI: SRAT: Node 0 PXM 0 [mem 0x80000000-0xefffffff]
> [ 0.014597] ACPI: Core revision 20250404
> [ 0.915706] ACPI: Added _OSI(Module Device)
> [ 0.915755] ACPI: Added _OSI(Processor Device)
> [ 0.915764] ACPI: Added _OSI(Processor Aggregator Device)
> [ 0.945135] ACPI: 1 ACPI AML tables successfully acquired and loaded
> [ 0.960197] ACPI: Interpreter enabled
> [ 0.961985] ACPI: PM: (supports S0 S5)
> [ 0.962069] ACPI: Using LPIC for interrupt routing
> [ 0.962718] ACPI: MCFG table detected, 1 entries
> [ 1.013706] ACPI: PCI: Interrupt link L000 configured for IRQ 80
> [ 1.013966] ACPI: PCI: Interrupt link L001 configured for IRQ 81
> [ 1.014076] ACPI: PCI: Interrupt link L002 configured for IRQ 82
> [ 1.014176] ACPI: PCI: Interrupt link L003 configured for IRQ 83
> [ 1.014977] ACPI: PCI Root Bridge [PCI0] (domain 0000 [bus 00-7f])
> [ 1.022475] ACPI: Remapped I/O 0x0000000018004000 to [io 0x0000-0xbfff window]
> [ 1.058781] ACPI: bus type USB registered
> [ 1.125533] pnp: PnP ACPI init
> [ 1.140430] pnp: PnP ACPI: found 5 devices
> [ 1.270053] ACPI: bus type thunderbolt registered
> [ 1.382724] ACPI: button: Power Button [PWRB]
> [ 1.673533] ACPI: bus type drm_connector registered
> [ 8.715507] ACPI: PM: Preparing to enter system sleep state S5
>
> Is this expected?
This doesn't appear on real machine, maybe the virtual bios need to be modified.
Huacai
>
> Cheers,
> Nathan
>
> # bad: [3b08f56fbbb9ef75c7454487f8d3db80a84deef7] Merge tag 'x86-urgent-2025-09-20' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
> # good: [f83ec76bf285bea5727f478a68b894f5543ca76e] Linux 6.17-rc6
> git bisect start '3b08f56fbbb9ef75c7454487f8d3db80a84deef7' 'v6.17-rc6'
> # good: [cbf658dd09419f1ef9de11b9604e950bdd5c170b] Merge tag 'net-6.17-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
> git bisect good cbf658dd09419f1ef9de11b9604e950bdd5c170b
> # good: [e8442d5b7bc6338d553040f5b1f7bd43f5ab30e0] Merge tag 'sound-6.17-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
> git bisect good e8442d5b7bc6338d553040f5b1f7bd43f5ab30e0
> # bad: [ffa7119cd1294dc1814e582dc07ffeb953ae7b26] Merge tag 'mmc-v6.17-rc2-2' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc
> git bisect bad ffa7119cd1294dc1814e582dc07ffeb953ae7b26
> # bad: [8dc5245673cf7f33743e5c0d2a4207c0b8df3067] LoongArch: KVM: Avoid copy_*_user() with lock hold in kvm_pch_pic_regs_access()
> git bisect bad 8dc5245673cf7f33743e5c0d2a4207c0b8df3067
> # bad: [d6d69f0edde63b553345d4efaceb7daed89fe04c] LoongArch: Replace sprintf() with sysfs_emit()
> git bisect bad d6d69f0edde63b553345d4efaceb7daed89fe04c
> # good: [74f8295c6fb8436bec9995baf6ba463151b6fb68] LoongArch: Handle jump tables options for RUST
> git bisect good 74f8295c6fb8436bec9995baf6ba463151b6fb68
> # bad: [a9d13433fe17be0e867e51e71a1acd2731fbef8d] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
> git bisect bad a9d13433fe17be0e867e51e71a1acd2731fbef8d
> # good: [f5003098e2f337d8e8a87dc636250e3fa978d9ad] LoongArch: Update help info of ARCH_STRICT_ALIGN
> git bisect good f5003098e2f337d8e8a87dc636250e3fa978d9ad
> # first bad commit: [a9d13433fe17be0e867e51e71a1acd2731fbef8d] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
2025-09-21 1:07 ` Huacai Chen
@ 2025-09-26 14:31 ` Guenter Roeck
2025-09-26 17:15 ` Xi Ruoyao
0 siblings, 1 reply; 10+ messages in thread
From: Guenter Roeck @ 2025-09-26 14:31 UTC (permalink / raw)
To: Huacai Chen
Cc: Nathan Chancellor, Huacai Chen, loongarch, Xuefeng Li, Guo Ren,
Xuerui Wang, Jiaxun Yang, linux-kernel, stable, Binbin Zhou,
Xi Ruoyao
On Sun, Sep 21, 2025 at 09:07:38AM +0800, Huacai Chen wrote:
> Hi, Nathan,
>
> On Sun, Sep 21, 2025 at 7:48 AM Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > Hi Huacai,
> >
> > On Wed, Sep 10, 2025 at 05:10:33PM +0800, Huacai Chen wrote:
> > > ARCH_STRICT_ALIGN is used for hardware without UAL, now it only control
> > > the -mstrict-align flag. However, ACPI structures are packed by default
> > > so will cause unaligned accesses.
> > >
> > > To avoid this, define ACPI_MISALIGNMENT_NOT_SUPPORTED in asm/acenv.h to
> > > align ACPI structures if ARCH_STRICT_ALIGN enabled.
> > >
> > > Cc: stable@vger.kernel.org
> > > Reported-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > > Suggested-by: Xi Ruoyao <xry111@xry111.site>
> > > Suggested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> > > ---
> > > V2: Modify asm/acenv.h instead of Makefile.
> > >
> > > arch/loongarch/include/asm/acenv.h | 7 +++----
> > > 1 file changed, 3 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/arch/loongarch/include/asm/acenv.h b/arch/loongarch/include/asm/acenv.h
> > > index 52f298f7293b..483c955f2ae5 100644
> > > --- a/arch/loongarch/include/asm/acenv.h
> > > +++ b/arch/loongarch/include/asm/acenv.h
> > > @@ -10,9 +10,8 @@
> > > #ifndef _ASM_LOONGARCH_ACENV_H
> > > #define _ASM_LOONGARCH_ACENV_H
> > >
> > > -/*
> > > - * This header is required by ACPI core, but we have nothing to fill in
> > > - * right now. Will be updated later when needed.
> > > - */
> > > +#ifdef CONFIG_ARCH_STRICT_ALIGN
> > > +#define ACPI_MISALIGNMENT_NOT_SUPPORTED
> > > +#endif /* CONFIG_ARCH_STRICT_ALIGN */
> > >
> > > #endif /* _ASM_LOONGARCH_ACENV_H */
> >
> > I am seeing several ACPI errors in my QEMU testing after this change in
> > Linus's tree as commit a9d13433fe17 ("LoongArch: Align ACPI structures
> > if ARCH_STRICT_ALIGN enabled").
> >
> > $ make -skj"$(nproc)" ARCH=loongarch CROSS_COMPILE=loongarch64-linux- clean defconfig vmlinuz.efi
> > kernel/sched/fair.o: warning: objtool: sched_update_scaling() falls through to next function init_entity_runnable_average()
> > mm/mempolicy.o: warning: objtool: alloc_pages_bulk_mempolicy_noprof+0x380: stack state mismatch: reg1[30]=-1+0 reg2[30]=-2-80
> > lib/crypto/mpi/mpih-div.o: warning: objtool: mpihelp_divrem+0x2d0: stack state mismatch: reg1[22]=-1+0 reg2[22]=-2-16
> > In file included from include/acpi/acpi.h:24,
> > from drivers/acpi/acpica/tbprint.c:10:
> > drivers/acpi/acpica/tbprint.c: In function 'acpi_tb_print_table_header':
> > include/acpi/actypes.h:530:43: warning: 'strncmp' argument 1 declared attribute 'nonstring' is smaller than the specified bound 8 [-Wstringop-overread]
> > 530 | #define ACPI_VALIDATE_RSDP_SIG(a) (!strncmp (ACPI_CAST_PTR (char, (a)), ACPI_SIG_RSDP, (sizeof(a) < 8) ? ACPI_NAMESEG_SIZE : 8))
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/acpi/acpica/tbprint.c:105:20: note: in expansion of macro 'ACPI_VALIDATE_RSDP_SIG'
> > 105 | } else if (ACPI_VALIDATE_RSDP_SIG(ACPI_CAST_PTR(struct acpi_table_rsdp,
> > | ^~~~~~~~~~~~~~~~~~~~~~
> > In file included from include/acpi/acpi.h:26:
> > include/acpi/actbl.h:69:14: note: argument 'signature' declared here
> > 69 | char signature[ACPI_NAMESEG_SIZE] ACPI_NONSTRING; /* ASCII table signature */
> > | ^~~~~~~~~
> >From this link this seems a comiler issue (at least not an
> arch-specific kernel issue):
> https://github.com/AOSC-Tracking/linux/commit/1e9ee413357ef58dd902f6ec55013d2a2f2043eb
>
I see that the patch made it into the upstream kernel, now breaking both
mainline and 6.16.y test builds of loongarch64:allmodconfig with gcc.
Since this is apparently intentional, I'll stop build testing
loongarch64:allmodconfig. So far it looks like my qemu tests
are not affected, so I'll continue testing those for the time being.
Guenter
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
2025-09-26 14:31 ` Guenter Roeck
@ 2025-09-26 17:15 ` Xi Ruoyao
2025-09-26 18:27 ` Guenter Roeck
0 siblings, 1 reply; 10+ messages in thread
From: Xi Ruoyao @ 2025-09-26 17:15 UTC (permalink / raw)
To: Guenter Roeck, Huacai Chen
Cc: Nathan Chancellor, Huacai Chen, loongarch, Xuefeng Li, Guo Ren,
Xuerui Wang, Jiaxun Yang, linux-kernel, stable, Binbin Zhou
On Fri, 2025-09-26 at 07:31 -0700, Guenter Roeck wrote:
> On Sun, Sep 21, 2025 at 09:07:38AM +0800, Huacai Chen wrote:
> > Hi, Nathan,
> >
> > On Sun, Sep 21, 2025 at 7:48 AM Nathan Chancellor <nathan@kernel.org> wrote:
> > >
> > > Hi Huacai,
> > >
> > > On Wed, Sep 10, 2025 at 05:10:33PM +0800, Huacai Chen wrote:
> > > > ARCH_STRICT_ALIGN is used for hardware without UAL, now it only control
> > > > the -mstrict-align flag. However, ACPI structures are packed by default
> > > > so will cause unaligned accesses.
> > > >
> > > > To avoid this, define ACPI_MISALIGNMENT_NOT_SUPPORTED in asm/acenv.h to
> > > > align ACPI structures if ARCH_STRICT_ALIGN enabled.
> > > >
> > > > Cc: stable@vger.kernel.org
> > > > Reported-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > > > Suggested-by: Xi Ruoyao <xry111@xry111.site>
> > > > Suggested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> > > > ---
> > > > V2: Modify asm/acenv.h instead of Makefile.
> > > >
> > > > arch/loongarch/include/asm/acenv.h | 7 +++----
> > > > 1 file changed, 3 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/arch/loongarch/include/asm/acenv.h b/arch/loongarch/include/asm/acenv.h
> > > > index 52f298f7293b..483c955f2ae5 100644
> > > > --- a/arch/loongarch/include/asm/acenv.h
> > > > +++ b/arch/loongarch/include/asm/acenv.h
> > > > @@ -10,9 +10,8 @@
> > > > #ifndef _ASM_LOONGARCH_ACENV_H
> > > > #define _ASM_LOONGARCH_ACENV_H
> > > >
> > > > -/*
> > > > - * This header is required by ACPI core, but we have nothing to fill in
> > > > - * right now. Will be updated later when needed.
> > > > - */
> > > > +#ifdef CONFIG_ARCH_STRICT_ALIGN
> > > > +#define ACPI_MISALIGNMENT_NOT_SUPPORTED
> > > > +#endif /* CONFIG_ARCH_STRICT_ALIGN */
> > > >
> > > > #endif /* _ASM_LOONGARCH_ACENV_H */
> > >
> > > I am seeing several ACPI errors in my QEMU testing after this change in
> > > Linus's tree as commit a9d13433fe17 ("LoongArch: Align ACPI structures
> > > if ARCH_STRICT_ALIGN enabled").
> > >
> > > $ make -skj"$(nproc)" ARCH=loongarch CROSS_COMPILE=loongarch64-linux- clean defconfig vmlinuz.efi
> > > kernel/sched/fair.o: warning: objtool: sched_update_scaling() falls through to next function init_entity_runnable_average()
> > > mm/mempolicy.o: warning: objtool: alloc_pages_bulk_mempolicy_noprof+0x380: stack state mismatch: reg1[30]=-1+0 reg2[30]=-2-80
> > > lib/crypto/mpi/mpih-div.o: warning: objtool: mpihelp_divrem+0x2d0: stack state mismatch: reg1[22]=-1+0 reg2[22]=-2-16
> > > In file included from include/acpi/acpi.h:24,
> > > from drivers/acpi/acpica/tbprint.c:10:
> > > drivers/acpi/acpica/tbprint.c: In function 'acpi_tb_print_table_header':
> > > include/acpi/actypes.h:530:43: warning: 'strncmp' argument 1 declared attribute 'nonstring' is smaller than the specified bound 8 [-Wstringop-overread]
> > > 530 | #define ACPI_VALIDATE_RSDP_SIG(a) (!strncmp (ACPI_CAST_PTR (char, (a)), ACPI_SIG_RSDP, (sizeof(a) < 8) ? ACPI_NAMESEG_SIZE : 8))
> > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > drivers/acpi/acpica/tbprint.c:105:20: note: in expansion of macro 'ACPI_VALIDATE_RSDP_SIG'
> > > 105 | } else if (ACPI_VALIDATE_RSDP_SIG(ACPI_CAST_PTR(struct acpi_table_rsdp,
> > > | ^~~~~~~~~~~~~~~~~~~~~~
> > > In file included from include/acpi/acpi.h:26:
> > > include/acpi/actbl.h:69:14: note: argument 'signature' declared here
> > > 69 | char signature[ACPI_NAMESEG_SIZE] ACPI_NONSTRING; /* ASCII table signature */
> > > | ^~~~~~~~~
> > > From this link this seems a comiler issue (at least not an
> > arch-specific kernel issue):
> > https://github.com/AOSC-Tracking/linux/commit/1e9ee413357ef58dd902f6ec55013d2a2f2043eb
> >
>
> I see that the patch made it into the upstream kernel, now breaking both
> mainline and 6.16.y test builds of loongarch64:allmodconfig with gcc.
>
> Since this is apparently intentional, I'll stop build testing
> loongarch64:allmodconfig. So far it looks like my qemu tests
> are not affected, so I'll continue testing those for the time being.
See https://gcc.gnu.org/PR122073 and
https://github.com/acpica/acpica/pull/1050.
--
Xi Ruoyao <xry111@xry111.site>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
2025-09-26 17:15 ` Xi Ruoyao
@ 2025-09-26 18:27 ` Guenter Roeck
2025-10-25 13:02 ` Xi Ruoyao
0 siblings, 1 reply; 10+ messages in thread
From: Guenter Roeck @ 2025-09-26 18:27 UTC (permalink / raw)
To: Xi Ruoyao, Huacai Chen
Cc: Nathan Chancellor, Huacai Chen, loongarch, Xuefeng Li, Guo Ren,
Xuerui Wang, Jiaxun Yang, linux-kernel, stable, Binbin Zhou
On 9/26/25 10:15, Xi Ruoyao wrote:
> On Fri, 2025-09-26 at 07:31 -0700, Guenter Roeck wrote:
>> On Sun, Sep 21, 2025 at 09:07:38AM +0800, Huacai Chen wrote:
>>> Hi, Nathan,
>>>
>>> On Sun, Sep 21, 2025 at 7:48 AM Nathan Chancellor <nathan@kernel.org> wrote:
>>>>
>>>> Hi Huacai,
>>>>
>>>> On Wed, Sep 10, 2025 at 05:10:33PM +0800, Huacai Chen wrote:
>>>>> ARCH_STRICT_ALIGN is used for hardware without UAL, now it only control
>>>>> the -mstrict-align flag. However, ACPI structures are packed by default
>>>>> so will cause unaligned accesses.
>>>>>
>>>>> To avoid this, define ACPI_MISALIGNMENT_NOT_SUPPORTED in asm/acenv.h to
>>>>> align ACPI structures if ARCH_STRICT_ALIGN enabled.
>>>>>
>>>>> Cc: stable@vger.kernel.org
>>>>> Reported-by: Binbin Zhou <zhoubinbin@loongson.cn>
>>>>> Suggested-by: Xi Ruoyao <xry111@xry111.site>
>>>>> Suggested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>>>> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
>>>>> ---
>>>>> V2: Modify asm/acenv.h instead of Makefile.
>>>>>
>>>>> arch/loongarch/include/asm/acenv.h | 7 +++----
>>>>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/arch/loongarch/include/asm/acenv.h b/arch/loongarch/include/asm/acenv.h
>>>>> index 52f298f7293b..483c955f2ae5 100644
>>>>> --- a/arch/loongarch/include/asm/acenv.h
>>>>> +++ b/arch/loongarch/include/asm/acenv.h
>>>>> @@ -10,9 +10,8 @@
>>>>> #ifndef _ASM_LOONGARCH_ACENV_H
>>>>> #define _ASM_LOONGARCH_ACENV_H
>>>>>
>>>>> -/*
>>>>> - * This header is required by ACPI core, but we have nothing to fill in
>>>>> - * right now. Will be updated later when needed.
>>>>> - */
>>>>> +#ifdef CONFIG_ARCH_STRICT_ALIGN
>>>>> +#define ACPI_MISALIGNMENT_NOT_SUPPORTED
>>>>> +#endif /* CONFIG_ARCH_STRICT_ALIGN */
>>>>>
>>>>> #endif /* _ASM_LOONGARCH_ACENV_H */
>>>>
>>>> I am seeing several ACPI errors in my QEMU testing after this change in
>>>> Linus's tree as commit a9d13433fe17 ("LoongArch: Align ACPI structures
>>>> if ARCH_STRICT_ALIGN enabled").
>>>>
>>>> $ make -skj"$(nproc)" ARCH=loongarch CROSS_COMPILE=loongarch64-linux- clean defconfig vmlinuz.efi
>>>> kernel/sched/fair.o: warning: objtool: sched_update_scaling() falls through to next function init_entity_runnable_average()
>>>> mm/mempolicy.o: warning: objtool: alloc_pages_bulk_mempolicy_noprof+0x380: stack state mismatch: reg1[30]=-1+0 reg2[30]=-2-80
>>>> lib/crypto/mpi/mpih-div.o: warning: objtool: mpihelp_divrem+0x2d0: stack state mismatch: reg1[22]=-1+0 reg2[22]=-2-16
>>>> In file included from include/acpi/acpi.h:24,
>>>> from drivers/acpi/acpica/tbprint.c:10:
>>>> drivers/acpi/acpica/tbprint.c: In function 'acpi_tb_print_table_header':
>>>> include/acpi/actypes.h:530:43: warning: 'strncmp' argument 1 declared attribute 'nonstring' is smaller than the specified bound 8 [-Wstringop-overread]
>>>> 530 | #define ACPI_VALIDATE_RSDP_SIG(a) (!strncmp (ACPI_CAST_PTR (char, (a)), ACPI_SIG_RSDP, (sizeof(a) < 8) ? ACPI_NAMESEG_SIZE : 8))
>>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> drivers/acpi/acpica/tbprint.c:105:20: note: in expansion of macro 'ACPI_VALIDATE_RSDP_SIG'
>>>> 105 | } else if (ACPI_VALIDATE_RSDP_SIG(ACPI_CAST_PTR(struct acpi_table_rsdp,
>>>> | ^~~~~~~~~~~~~~~~~~~~~~
>>>> In file included from include/acpi/acpi.h:26:
>>>> include/acpi/actbl.h:69:14: note: argument 'signature' declared here
>>>> 69 | char signature[ACPI_NAMESEG_SIZE] ACPI_NONSTRING; /* ASCII table signature */
>>>> | ^~~~~~~~~
>>>> From this link this seems a comiler issue (at least not an
>>> arch-specific kernel issue):
>>> https://github.com/AOSC-Tracking/linux/commit/1e9ee413357ef58dd902f6ec55013d2a2f2043eb
>>>
>>
>> I see that the patch made it into the upstream kernel, now breaking both
>> mainline and 6.16.y test builds of loongarch64:allmodconfig with gcc.
>>
>> Since this is apparently intentional, I'll stop build testing
>> loongarch64:allmodconfig. So far it looks like my qemu tests
>> are not affected, so I'll continue testing those for the time being.
>
> See https://gcc.gnu.org/PR122073 and
> https://github.com/acpica/acpica/pull/1050.
>
I understand that. Every compiler has bugs. Normally workarounds are implemented.
Since that won't happen here, my remedy is to stop testing the affected
configuration(s). I do this whenever I learn that a known problem won't be fixed.
The above is not a complaint, just an information.
Guenter
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
2025-09-26 18:27 ` Guenter Roeck
@ 2025-10-25 13:02 ` Xi Ruoyao
0 siblings, 0 replies; 10+ messages in thread
From: Xi Ruoyao @ 2025-10-25 13:02 UTC (permalink / raw)
To: Guenter Roeck, Huacai Chen
Cc: Nathan Chancellor, Huacai Chen, loongarch, Xuefeng Li, Guo Ren,
Xuerui Wang, Jiaxun Yang, linux-kernel, stable, Binbin Zhou
On Fri, 2025-09-26 at 11:27 -0700, Guenter Roeck wrote:
> > > I see that the patch made it into the upstream kernel, now breaking both
> > > mainline and 6.16.y test builds of loongarch64:allmodconfig with gcc.
> > >
> > > Since this is apparently intentional, I'll stop build testing
> > > loongarch64:allmodconfig. So far it looks like my qemu tests
> > > are not affected, so I'll continue testing those for the time being.
> >
> > See https://gcc.gnu.org/PR122073 and
> > https://github.com/acpica/acpica/pull/1050.
> >
>
> I understand that. Every compiler has bugs. Normally workarounds are implemented.
> Since that won't happen here, my remedy is to stop testing the affected
> configuration(s). I do this whenever I learn that a known problem won't be fixed.
> The above is not a complaint, just an information.
Hi Guenter,
The mainline should be already fixed with 6e3a4754717a ("ACPICA: Work
around bogus -Wstringop-overread warning since GCC 11") now. The commit
is Cc'ed to stable so we can expect 6.16.y will be fixed soon as well.
--
Xi Ruoyao <xry111@xry111.site>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled
@ 2026-06-19 22:26 ANDREW
0 siblings, 0 replies; 10+ messages in thread
From: ANDREW @ 2026-06-19 22:26 UTC (permalink / raw)
To: 899f2dec-e8b9-44f4-ab8d-001e160a2aed
Cc: Nathan Chancellor, Huacai Chen, loongarch, Xuefeng Li, Guo Ren,
Xuerui Wang, Jiaxun Yang, linux-kernel, stable, Binbin Zhou,
Xi Ruoyao
[-- Attachment #1.1.1: Type: text/plain, Size: 1811 bytes --]
voidacpi_tb_print_table_header(acpi_physical_address address,
struct acpi_table_header *header)
{
struct acpi_table_header local_header;
ssize_t ssrc_len = sizeof(ACPI_CAST_PTR(struct acpi_table_rsdp, header)->signature);
size_t src_len = (ssrc_len < 0) ? 0 : (size_t)ssrc_len;
size_t src_length = (src_len < 8) ? src_len : 8;
char rsdp_sig[src_length + 1];
memcpy(rsdp_sig,
ACPI_CAST_PTR(struct acpi_table_rsdp, header)->signature,
src_length);
rsdp_sig[src_length] = '\0';
if (ACPI_COMPARE_NAMESEG(header->signature, ACPI_SIG_FACS)) {
/* FACS only has signature and length fields */
ACPI_INFO(("%-4.4s 0x%8.8X%8.8X %06X",
header->signature, ACPI_FORMAT_UINT64(address),
header->length));
} else if (ACPI_VALIDATE_RSDP_SIG(rsdp_sig)) {
/* RSDP has no common fields */
memcpy(local_header.oem_id,
ACPI_CAST_PTR(struct acpi_table_rsdp, header)->oem_id,
ACPI_OEM_ID_SIZE);
acpi_tb_fix_string(local_header.oem_id, ACPI_OEM_ID_SIZE);
ACPI_INFO(("RSDP 0x%8.8X%8.8X %06X (v%.2d %-6.6s)",
ACPI_FORMAT_UINT64(address),
(ACPI_CAST_PTR(struct acpi_table_rsdp, header)->
revision >
0) ? ACPI_CAST_PTR(struct acpi_table_rsdp,
header)->length : 20,
ACPI_CAST_PTR(struct acpi_table_rsdp,
header)->revision,
local_header.oem_id));
} else {
/* Standard ACPI table with full common header */
acpi_tb_cleanup_table_header(&local_header, header);
ACPI_INFO(("%-4.4s 0x%8.8X%8.8X"
" %06X (v%.2d %-6.6s %-8.8s %08X %-4.4s %08X)",
local_header.signature, ACPI_FORMAT_UINT64(address),
local_header.length, local_header.revision,
local_header.oem_id, local_header.oem_table_id,
local_header.oem_revision,
local_header.asl_compiler_id,
local_header.asl_compiler_revision));
}
}
[-- Attachment #1.1.2.1: Type: text/html, Size: 3250 bytes --]
[-- Attachment #1.2: publickey - andreasx0@protonmail.ch - 0xBB6B52B1.asc --]
[-- Type: application/pgp-keys, Size: 848 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 343 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2026-06-19 22:26 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-10 9:10 [PATCH V2] LoongArch: Align ACPI structures if ARCH_STRICT_ALIGN enabled Huacai Chen
2025-09-11 0:59 ` kernel test robot
2025-09-11 8:41 ` Huacai Chen
2025-09-20 23:48 ` Nathan Chancellor
2025-09-21 1:07 ` Huacai Chen
2025-09-26 14:31 ` Guenter Roeck
2025-09-26 17:15 ` Xi Ruoyao
2025-09-26 18:27 ` Guenter Roeck
2025-10-25 13:02 ` Xi Ruoyao
2026-06-19 22:26 ANDREW
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®