From: Yana Bashlykova <yana2bsh@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Yana Bashlykova <yana2bsh@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: [PATCH 6.1 05/15] genetlink: add test case for family with invalid ops
Date: Fri, 12 Sep 2025 22:53:28 +0300 [thread overview]
Message-ID: <20250912195339.20635-6-yana2bsh@gmail.com> (raw)
In-Reply-To: <20250912195339.20635-1-yana2bsh@gmail.com>
Add test case that verifies error handling when registering
a genetlink family with invalid operations where both doit
and dumpit callbacks are NULL.
The test registers incorrect_ops_genl_family which contains a command with:
- .doit = NULL
- .dumpit = NULL
and expects the registration to fail with -EINVAL.
This validates proper validation of genetlink operations during family
registration.
Signed-off-by: Yana Bashlykova <yana2bsh@gmail.com>
---
.../net-pf-16-proto-16-family-PARALLEL_GENL.c | 41 +++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/drivers/net/genetlink/net-pf-16-proto-16-family-PARALLEL_GENL.c b/drivers/net/genetlink/net-pf-16-proto-16-family-PARALLEL_GENL.c
index 1db5d15a6f2c..245f3b0f4fbb 100644
--- a/drivers/net/genetlink/net-pf-16-proto-16-family-PARALLEL_GENL.c
+++ b/drivers/net/genetlink/net-pf-16-proto-16-family-PARALLEL_GENL.c
@@ -1089,6 +1089,33 @@ static struct genl_family incorrect_genl_family = {
.policy = my_genl_policy,
};
+enum {
+ INCORRECT_OP_WITH_NULL,
+};
+
+// Generic Netlink operations with incorrect ops
+static const struct genl_ops incorrect_ops_with_null[] = {
+ {
+ .cmd = INCORRECT_OP_WITH_NULL,
+ .flags = 0,
+ .policy = my_genl_policy, // random policy
+ .doit = NULL, // doit and dumpit are NULL --> kernel will send -EINVAL
+ .dumpit = NULL,
+ },
+};
+
+// genl_family struct with incorrect ops
+static struct genl_family incorrect_ops_genl_family = {
+ .hdrsize = 0,
+ .name = "INCORRECT",
+ .version = 1,
+ .maxattr = 1,
+ .netnsok = true,
+ .ops = incorrect_ops_with_null, // ops contain NULL
+ .n_ops = ARRAY_SIZE(incorrect_ops_with_null),
+ .policy = my_genl_policy, // random policy
+};
+
static int __init init_netlink(void)
{
int rc;
@@ -1116,6 +1143,16 @@ static int __init init_netlink(void)
return rc;
}
+static int __init incorrect_ops_netlink(void)
+{
+ int ret;
+
+ ret = genl_register_family(&incorrect_ops_genl_family);
+ if (ret != -EINVAL)
+ return ret;
+ return 0;
+}
+
static int __init incorrect_init_netlink(void)
{
int rc;
@@ -1241,6 +1278,10 @@ static int __init module_netlink_init(void)
if (ret)
goto err_sysfs;
+ ret = incorrect_ops_netlink();
+ if (ret)
+ goto err_sysfs;
+
ret = init_netlink();
if (ret)
goto err_sysfs;
--
2.34.1
next prev parent reply other threads:[~2025-09-12 19:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 19:53 [PATCH 6.1 00/15] genetlink: Test Netlink subsystem of Linux v6.1 Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 01/15] genetlink: add sysfs test module for Generic Netlink Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 02/15] genetlink: add TEST_GENL family for netlink testing Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 03/15] genetlink: add PARALLEL_GENL test family Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 04/15] genetlink: add test case for duplicate genl family registration Yana Bashlykova
2025-09-12 19:53 ` Yana Bashlykova [this message]
2025-09-12 19:53 ` [PATCH 6.1 06/15] genetlink: add netlink notifier support Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 07/15] genetlink: add THIRD_GENL family Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 08/15] genetlink: verify unregister fails for non-registered family Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 09/15] genetlink: add LARGE_GENL stress test family Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 10/15] selftests: net: genetlink: add packet capture test infrastructure Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 11/15] selftests: net: genetlink: add /proc/net/netlink test Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 12/15] selftests: net: genetlink: add Generic Netlink controller tests Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 13/15] selftests: net: genetlink: add large family ID resolution test Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 14/15] selftests: net: genetlink: add Netlink and Generic Netlink test suite Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 15/15] selftests: net: genetlink: fix expectation for large family resolution Yana Bashlykova
2025-09-12 20:17 ` [PATCH 6.1 00/15] genetlink: Test Netlink subsystem of Linux v6.1 Jakub Kicinski
2025-10-15 14:49 ` Яна Башлыкова
2025-10-15 15:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250912195339.20635-6-yana2bsh@gmail.com \
--to=yana2bsh@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®