mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yana Bashlykova <yana2bsh@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Yana Bashlykova <yana2bsh@gmail.com>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	lvc-project@linuxtesting.org
Subject: [PATCH 6.1 07/15] genetlink: add THIRD_GENL family
Date: Fri, 12 Sep 2025 22:53:30 +0300	[thread overview]
Message-ID: <20250912195339.20635-8-yana2bsh@gmail.com> (raw)
In-Reply-To: <20250912195339.20635-1-yana2bsh@gmail.com>

- New family with echo command
- Supports string and flag attributes
- Sysfs interface at /sys/kernel/third_genl/message

Signed-off-by: Yana Bashlykova <yana2bsh@gmail.com>
---
 .../net-pf-16-proto-16-family-PARALLEL_GENL.c | 103 ++++++++++++++++++
 1 file changed, 103 insertions(+)

diff --git a/drivers/net/genetlink/net-pf-16-proto-16-family-PARALLEL_GENL.c b/drivers/net/genetlink/net-pf-16-proto-16-family-PARALLEL_GENL.c
index cdedd77b2a1b..f651159a311c 100644
--- a/drivers/net/genetlink/net-pf-16-proto-16-family-PARALLEL_GENL.c
+++ b/drivers/net/genetlink/net-pf-16-proto-16-family-PARALLEL_GENL.c
@@ -152,10 +152,13 @@ static DEFINE_MUTEX(genl_mutex);
 
 #define PARALLEL_GENL_FAMILY_NAME "PARALLEL_GENL"
 
+#define THIRD_GENL_FAMILY_NAME "THIRD_GENL"
+
 #define PATH_GENL_TEST_NUM "/sys/kernel/genl_test/value"
 #define PATH_GENL_TEST_MES "/sys/kernel/genl_test/message"
 #define PATH_GENL_TEST_DEV "/sys/kernel/genl_test/some_info"
 #define PATH_PARALLEL_GENL_MES "/sys/kernel/parallel_genl/message"
+#define PATH_THIRD_GENL_MES "/sys/kernel/third_genl/message"
 
 // TEST_GENL
 enum {
@@ -205,6 +208,8 @@ static struct genl_family my_genl_family;
 
 static struct genl_family my_genl_family_parallel;
 
+static struct genl_family third_genl_family;
+
 enum my_multicast_groups {
 	MY_MCGRP_GENL,
 };
@@ -1077,6 +1082,94 @@ static struct genl_family my_genl_family_parallel = {
 	.n_mcgrps = ARRAY_SIZE(genl_many_mcgrps_two),
 };
 
+// THIRD_GENL
+enum {
+	THIRD_GENL_ATTR_UNSPEC,
+	THIRD_GENL_ATTR_DATA,
+	THIRD_GENL_ATTR_FLAG,
+	__THIRD_GENL_ATTR_MAX,
+};
+
+#define THIRD_GENL_ATTR_MAX (__THIRD_GENL_ATTR_MAX - 1)
+
+enum {
+	THIRD_GENL_CMD_UNSPEC,
+	THIRD_GENL_CMD_ECHO,
+	__THIRD_GENL_CMD_MAX,
+};
+
+#define THIRD_GENL_CMD_MAX (__THIRD_GENL_CMD_MAX - 1)
+
+static const struct nla_policy third_genl_policy[THIRD_GENL_ATTR_MAX + 1] = {
+	[THIRD_GENL_ATTR_UNSPEC] = { .type = NLA_UNSPEC },
+	[THIRD_GENL_ATTR_DATA] = { .type = NLA_STRING },
+	[THIRD_GENL_ATTR_FLAG] = { .type = NLA_FLAG },
+};
+
+// Functions for THIRD_GENL family
+static int third_genl_echo(struct sk_buff *skb, struct genl_info *info)
+{
+	struct sk_buff *msg;
+	void *data;
+	int ret;
+	char *str;
+
+	if (info->nlhdr->nlmsg_flags & NLM_F_ECHO) {
+		msg = genlmsg_new(GENLMSG_DEFAULT_SIZE, GFP_KERNEL);
+		if (!msg)
+			return -ENOMEM;
+
+		data = genlmsg_put_reply(msg, info, &my_genl_family, 0,
+					 THIRD_GENL_CMD_ECHO);
+		if (!data)
+			goto error;
+
+		str = "Hello from THIRD_GENL!";
+		strcpy(sysfs_data.third_genl_message, str);
+
+		ret = nla_put_string(msg, THIRD_GENL_ATTR_DATA, str);
+		if (ret < 0)
+			goto error;
+
+		ret = nla_put_flag(msg, THIRD_GENL_ATTR_FLAG);
+		if (ret < 0)
+			goto error;
+
+		genlmsg_end(msg, data);
+
+		genlmsg_reply(msg, info);
+	}
+
+	return 0;
+
+error:
+	nlmsg_free(msg);
+	return -EMSGSIZE;
+}
+
+// Generic Netlink operations for THIRD_GENL family
+static const struct genl_ops third_genl_ops[] = {
+	{
+		.cmd = THIRD_GENL_CMD_ECHO,
+		.flags = 0,
+		.policy = third_genl_policy,
+		.doit = third_genl_echo,
+		.dumpit = NULL,
+	},
+};
+
+// genl_family struct for THIRD_GENL family
+static struct genl_family third_genl_family = {
+	.hdrsize = 0,
+	.name = THIRD_GENL_FAMILY_NAME,
+	.version = 1,
+	.maxattr = THIRD_GENL_ATTR_MAX,
+	.netnsok = true,
+	.ops = third_genl_ops,
+	.n_ops = ARRAY_SIZE(third_genl_ops),
+	.policy = third_genl_policy,
+};
+
 // genl_family struct with incorrect name
 static struct genl_family incorrect_genl_family = {
 	.hdrsize = 0,
@@ -1144,8 +1237,16 @@ static int __init init_netlink(void)
 		goto failure_2;
 	}
 
+	rc = genl_register_family(&third_genl_family);
+	if (rc) {
+		pr_err("%s: Failed to register Generic Netlink family\n", __func__);
+		goto failure_3;
+	}
+
 	return 0;
 
+failure_3:
+	genl_unregister_family(&my_genl_family_parallel);
 failure_2:
 	genl_unregister_family(&my_genl_family);
 failure_1:
@@ -1311,6 +1412,7 @@ static int __init module_netlink_init(void)
 err_family:
 	genl_unregister_family(&my_genl_family);
 	genl_unregister_family(&my_genl_family_parallel);
+	genl_unregister_family(&third_genl_family);
 err_sysfs:
 	sysfs_remove_file(kobj_genl_test, &my_attr_u32_genl_test.attr);
 	sysfs_remove_file(kobj_genl_test, &my_attr_str_genl_test.attr);
@@ -1330,6 +1432,7 @@ static void __exit module_netlink_exit(void)
 	netlink_unregister_notifier(&genl_notifier);
 	genl_unregister_family(&my_genl_family);
 	genl_unregister_family(&my_genl_family_parallel);
+	genl_unregister_family(&third_genl_family);
 
 	sysfs_remove_file(kobj_genl_test, &my_attr_u32_genl_test.attr);
 	sysfs_remove_file(kobj_genl_test, &my_attr_str_genl_test.attr);
-- 
2.34.1


  parent reply	other threads:[~2025-09-12 19:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-12 19:53 [PATCH 6.1 00/15] genetlink: Test Netlink subsystem of Linux v6.1 Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 01/15] genetlink: add sysfs test module for Generic Netlink Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 02/15] genetlink: add TEST_GENL family for netlink testing Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 03/15] genetlink: add PARALLEL_GENL test family Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 04/15] genetlink: add test case for duplicate genl family registration Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 05/15] genetlink: add test case for family with invalid ops Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 06/15] genetlink: add netlink notifier support Yana Bashlykova
2025-09-12 19:53 ` Yana Bashlykova [this message]
2025-09-12 19:53 ` [PATCH 6.1 08/15] genetlink: verify unregister fails for non-registered family Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 09/15] genetlink: add LARGE_GENL stress test family Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 10/15] selftests: net: genetlink: add packet capture test infrastructure Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 11/15] selftests: net: genetlink: add /proc/net/netlink test Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 12/15] selftests: net: genetlink: add Generic Netlink controller tests Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 13/15] selftests: net: genetlink: add large family ID resolution test Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 14/15] selftests: net: genetlink: add Netlink and Generic Netlink test suite Yana Bashlykova
2025-09-12 19:53 ` [PATCH 6.1 15/15] selftests: net: genetlink: fix expectation for large family resolution Yana Bashlykova
2025-09-12 20:17 ` [PATCH 6.1 00/15] genetlink: Test Netlink subsystem of Linux v6.1 Jakub Kicinski
2025-10-15 14:49   ` Яна Башлыкова
2025-10-15 15:04     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250912195339.20635-8-yana2bsh@gmail.com \
    --to=yana2bsh@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®