From: "Pali Rohár" <pali@kernel.org>
To: Armin Wolf <W_Armin@gmx.de>
Cc: linux@roeck-us.net, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] hwmon: (dell-smm) Add support for automatic fan mode
Date: Wed, 17 Sep 2025 23:19:25 +0200 [thread overview]
Message-ID: <20250917211925.dhzocprqgo4tkpte@pali> (raw)
In-Reply-To: <20250917181036.10972-1-W_Armin@gmx.de>
On Wednesday 17 September 2025 20:10:32 Armin Wolf wrote:
> This patch series adds support for individually enabling and disabling
> automatic fan control for each fan on most Dell machines. This works
> by using fan state 3 that does not act like an ordinary fan state on
> most devices. Instead of increasing the speed, said fan state usually
> enables automatic fan control for the associated fan.
>
> The first patch removes the custom config data for the Precision 490
> that turned out to be incorrect, see the link inside the patch
> description for details.
>
> The second patch enables i8k_set_fan() to accept fan states larger
> than i8k_fan_max to prepare for the following patch.
>
> The third patch finally adds support for this special fan state. It
> should be noted that after applying this patch, the "pwmX" and
> "fanX_target" sysfs attributes will return -ENODATA when automatic fan
> control has been enabled for fan X using the special fan state.
>
> The last patch adds the OptiPlex 7040 to the device whitelist so that
> the driver automatically loads on those machine.
>
> All patches have been tested on a Dell Inspiron 3505 and appear to
> work.
>
> Armin Wolf (4):
> hwmon: (dell-smm) Remove Dell Precision 490 custom config data
> hwmon: (dell-smm) Move clamping of fan speed out of i8k_set_fan()
> hwmon: (dell-smm) Add support for automatic fan mode
> hwmon: (dell-smm) Add support for Dell OptiPlex 7040
>
> Documentation/hwmon/dell-smm-hwmon.rst | 56 +++++++++------
> drivers/hwmon/dell-smm-hwmon.c | 99 ++++++++++++++++++--------
> include/uapi/linux/i8k.h | 2 +
> 3 files changed, 108 insertions(+), 49 deletions(-)
>
> --
> 2.39.5
>
This patch series looks good to me.
Acked-by: Pali Rohár <pali@kernel.org>
prev parent reply other threads:[~2025-09-17 21:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 18:10 Armin Wolf
2025-09-17 18:10 ` [PATCH 1/4] hwmon: (dell-smm) Remove Dell Precision 490 custom config data Armin Wolf
2025-09-24 14:46 ` Guenter Roeck
2025-09-17 18:10 ` [PATCH 2/4] hwmon: (dell-smm) Move clamping of fan speed out of i8k_set_fan() Armin Wolf
2025-09-24 14:47 ` Guenter Roeck
2025-09-17 18:10 ` [PATCH 3/4] hwmon: (dell-smm) Add support for automatic fan mode Armin Wolf
2025-09-24 14:50 ` Guenter Roeck
2025-09-17 18:10 ` [PATCH 4/4] hwmon: (dell-smm) Add support for Dell OptiPlex 7040 Armin Wolf
2025-09-24 14:50 ` Guenter Roeck
2025-09-17 21:19 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917211925.dhzocprqgo4tkpte@pali \
--to=pali@kernel.org \
--cc=W_Armin@gmx.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®