From: Guenter Roeck <linux@roeck-us.net>
To: Armin Wolf <W_Armin@gmx.de>
Cc: pali@kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] hwmon: (dell-smm) Move clamping of fan speed out of i8k_set_fan()
Date: Wed, 24 Sep 2025 07:47:28 -0700 [thread overview]
Message-ID: <964da8dd-449f-42bb-90df-5ecf4b2d1e32@roeck-us.net> (raw)
In-Reply-To: <20250917181036.10972-3-W_Armin@gmx.de>
On Wed, Sep 17, 2025 at 08:10:34PM +0200, Armin Wolf wrote:
> Currently i8k_set_fan() clamps the fan speed before performing the
> SMM call to ensure that the speed is not negative and not greater than
> i8k_fan_max. This however is mostly unnecessary as the hwmon and
> thermal interfaces alread ensure this. Only the legacy ioctl interface
> does not ensure that the fan speed passed to i8k_set_fan() does meet
> the above criteria.
>
> Move the clamping out of i8k_set_fan() and into the legacy ioctl
> handler to prepare for future changes.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Applied.
Guenter
next prev parent reply other threads:[~2025-09-24 14:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 18:10 [PATCH 0/4] hwmon: (dell-smm) Add support for automatic fan mode Armin Wolf
2025-09-17 18:10 ` [PATCH 1/4] hwmon: (dell-smm) Remove Dell Precision 490 custom config data Armin Wolf
2025-09-24 14:46 ` Guenter Roeck
2025-09-17 18:10 ` [PATCH 2/4] hwmon: (dell-smm) Move clamping of fan speed out of i8k_set_fan() Armin Wolf
2025-09-24 14:47 ` Guenter Roeck [this message]
2025-09-17 18:10 ` [PATCH 3/4] hwmon: (dell-smm) Add support for automatic fan mode Armin Wolf
2025-09-24 14:50 ` Guenter Roeck
2025-09-17 18:10 ` [PATCH 4/4] hwmon: (dell-smm) Add support for Dell OptiPlex 7040 Armin Wolf
2025-09-24 14:50 ` Guenter Roeck
2025-09-17 21:19 ` [PATCH 0/4] hwmon: (dell-smm) Add support for automatic fan mode Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=964da8dd-449f-42bb-90df-5ecf4b2d1e32@roeck-us.net \
--to=linux@roeck-us.net \
--cc=W_Armin@gmx.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®