* [PATCH] drm/i915: i915_pmu: Use sysfs_emit() instead of sprintf()
@ 2025-09-23 19:50 Madhur Kumar
2025-09-24 12:21 ` Andi Shyti
2025-09-25 22:46 ` Andi Shyti
0 siblings, 2 replies; 3+ messages in thread
From: Madhur Kumar @ 2025-09-23 19:50 UTC (permalink / raw)
To: jani.nikula
Cc: joonas.lahtinen, rodrigo.vivi, tursulin, airlied, simona,
intel-gfx, dri-devel, linux-kernel, Madhur Kumar
Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.
Signed-off-by: Madhur Kumar <madhurkumar004@gmail.com>
---
drivers/gpu/drm/i915/i915_pmu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
index 5bc696bfbb0f..d8f69bba79a9 100644
--- a/drivers/gpu/drm/i915/i915_pmu.c
+++ b/drivers/gpu/drm/i915/i915_pmu.c
@@ -895,7 +895,7 @@ static ssize_t i915_pmu_format_show(struct device *dev,
struct i915_str_attribute *eattr;
eattr = container_of(attr, struct i915_str_attribute, attr);
- return sprintf(buf, "%s\n", eattr->str);
+ return sysfs_emit(buf, "%s\n", eattr->str);
}
#define I915_PMU_FORMAT_ATTR(_name, _config) \
@@ -925,7 +925,7 @@ static ssize_t i915_pmu_event_show(struct device *dev,
struct i915_ext_attribute *eattr;
eattr = container_of(attr, struct i915_ext_attribute, attr);
- return sprintf(buf, "config=0x%lx\n", eattr->val);
+ return sysfs_emit(buf, "config=0x%lx\n", eattr->val);
}
#define __event(__counter, __name, __unit) \
--
2.51.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: i915_pmu: Use sysfs_emit() instead of sprintf()
2025-09-23 19:50 [PATCH] drm/i915: i915_pmu: Use sysfs_emit() instead of sprintf() Madhur Kumar
@ 2025-09-24 12:21 ` Andi Shyti
2025-09-25 22:46 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2025-09-24 12:21 UTC (permalink / raw)
To: Madhur Kumar
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin, airlied,
simona, intel-gfx, dri-devel, linux-kernel
Hi Madhur,
On Wed, Sep 24, 2025 at 01:20:51AM +0530, Madhur Kumar wrote:
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
>
> Signed-off-by: Madhur Kumar <madhurkumar004@gmail.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: i915_pmu: Use sysfs_emit() instead of sprintf()
2025-09-23 19:50 [PATCH] drm/i915: i915_pmu: Use sysfs_emit() instead of sprintf() Madhur Kumar
2025-09-24 12:21 ` Andi Shyti
@ 2025-09-25 22:46 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2025-09-25 22:46 UTC (permalink / raw)
To: Madhur Kumar
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin, airlied,
simona, intel-gfx, dri-devel, linux-kernel
Hi Madhur,
On Wed, Sep 24, 2025 at 01:20:51AM +0530, Madhur Kumar wrote:
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
>
> Signed-off-by: Madhur Kumar <madhurkumar004@gmail.com>
merged to drm-intel-next.
Thank you,
Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-25 22:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-23 19:50 [PATCH] drm/i915: i915_pmu: Use sysfs_emit() instead of sprintf() Madhur Kumar
2025-09-24 12:21 ` Andi Shyti
2025-09-25 22:46 ` Andi Shyti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®