mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Siddh Raman Pant <siddh.raman.pant@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>
Subject: [PATCH 5.10] NFSv4: Clear the NFS_CAP_XATTR flag if not supported by the server
Date: Thu, 25 Sep 2025 18:32:11 +0530	[thread overview]
Message-ID: <20250925130211.76431-1-siddh.raman.pant@oracle.com> (raw)
In-Reply-To: <20250925125800.74222-1-siddh.raman.pant@oracle.com>

From: Trond Myklebust <trond.myklebust@hammerspace.com>

nfs_server_set_fsinfo() shouldn't assume that NFS_CAP_XATTR is unset
on entry to the function.

Fixes: b78ef845c35d ("NFSv4.2: query the server for extended attribute support")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
(cherry picked from commit 4fb2b677fc1f70ee642c0beecc3cabf226ef5707)
Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
---
 fs/nfs/client.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/nfs/client.c b/fs/nfs/client.c
index ac2fbbba1521..6134101184fa 100644
--- a/fs/nfs/client.c
+++ b/fs/nfs/client.c
@@ -850,6 +850,8 @@ static void nfs_server_set_fsinfo(struct nfs_server *server,
 
 	if (fsinfo->xattr_support)
 		server->caps |= NFS_CAP_XATTR;
+	else
+		server->caps &= ~NFS_CAP_XATTR;
 #endif
 }
 
-- 
2.51.0


  parent reply	other threads:[~2025-09-25 13:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2025091224-CVE-2025-39798-a66e@gregkh>
2025-09-25 12:58 ` [PATCH 5.15, 5.10, 5.4] NFSv4: Don't clear capabilities that won't be reset Siddh Raman Pant
2025-09-25 13:01   ` [PATCH 5.15 1/3] NFSv4: Clear the NFS_CAP_FS_LOCATIONS flag if it is not set Siddh Raman Pant
2025-09-25 13:01     ` [PATCH 5.15 2/3] NFSv4: Clear NFS_CAP_OPEN_XOR and NFS_CAP_DELEGTIME if not supported Siddh Raman Pant
2025-09-29 13:24       ` Greg Kroah-Hartman
2025-09-29 14:04         ` Siddh Raman Pant
2025-09-25 13:01     ` [PATCH 5.15 3/3] NFSv4: Clear the NFS_CAP_XATTR flag if not supported by the server Siddh Raman Pant
2025-09-25 13:02   ` Siddh Raman Pant [this message]
2025-09-29 13:23   ` [PATCH 5.15, 5.10, 5.4] NFSv4: Don't clear capabilities that won't be reset Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250925130211.76431-1-siddh.raman.pant@oracle.com \
    --to=siddh.raman.pant@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®