mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Siddh Raman Pant <siddh.raman.pant@oracle.com>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org,
	Trond Myklebust <trond.myklebust@hammerspace.com>
Subject: Re: [PATCH 5.15 2/3] NFSv4: Clear NFS_CAP_OPEN_XOR and NFS_CAP_DELEGTIME if not supported
Date: Mon, 29 Sep 2025 15:24:09 +0200	[thread overview]
Message-ID: <2025092903-plentiful-banister-9ad0@gregkh> (raw)
In-Reply-To: <2e811427a30b62898f63bab33ec07d9253061a33.1758805195.git.siddh.raman.pant@oracle.com>

On Thu, Sep 25, 2025 at 06:31:45PM +0530, Siddh Raman Pant wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
> 
> _nfs4_server_capabilities() should clear capabilities that are not
> supported by the server.
> 
> Fixes: d2a00cceb93a ("NFSv4: Detect support for OPEN4_SHARE_ACCESS_WANT_OPEN_XOR_DELEGATION")
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> (cherry picked from commit b3ac33436030bce37ecb3dcae581ecfaad28078c)
> Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
> ---
>  fs/nfs/nfs4proc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 3d854e2537bc..91b95310e107 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -3906,7 +3906,8 @@ static int _nfs4_server_capabilities(struct nfs_server *server, struct nfs_fh *f
>  		memcpy(server->attr_bitmask, res.attr_bitmask, sizeof(server->attr_bitmask));
>  		server->caps &=
>  			~(NFS_CAP_ACLS | NFS_CAP_HARDLINKS | NFS_CAP_SYMLINKS |
> -			  NFS_CAP_SECURITY_LABEL | NFS_CAP_FS_LOCATIONS);
> +			  NFS_CAP_SECURITY_LABEL | NFS_CAP_FS_LOCATIONS |
> +			  NFS_CAP_OPEN_XOR | NFS_CAP_DELEGTIME);
>  		server->fattr_valid = NFS_ATTR_FATTR_V4;
>  		if (res.attr_bitmask[0] & FATTR4_WORD0_ACL &&
>  				res.acl_bitmask & ACL4_SUPPORT_ALLOW_ACL)
> -- 
> 2.51.0
> 

This breaks the build :(

  reply	other threads:[~2025-09-29 13:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2025091224-CVE-2025-39798-a66e@gregkh>
2025-09-25 12:58 ` [PATCH 5.15, 5.10, 5.4] NFSv4: Don't clear capabilities that won't be reset Siddh Raman Pant
2025-09-25 13:01   ` [PATCH 5.15 1/3] NFSv4: Clear the NFS_CAP_FS_LOCATIONS flag if it is not set Siddh Raman Pant
2025-09-25 13:01     ` [PATCH 5.15 2/3] NFSv4: Clear NFS_CAP_OPEN_XOR and NFS_CAP_DELEGTIME if not supported Siddh Raman Pant
2025-09-29 13:24       ` Greg Kroah-Hartman [this message]
2025-09-29 14:04         ` Siddh Raman Pant
2025-09-25 13:01     ` [PATCH 5.15 3/3] NFSv4: Clear the NFS_CAP_XATTR flag if not supported by the server Siddh Raman Pant
2025-09-25 13:02   ` [PATCH 5.10] " Siddh Raman Pant
2025-09-29 13:23   ` [PATCH 5.15, 5.10, 5.4] NFSv4: Don't clear capabilities that won't be reset Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025092903-plentiful-banister-9ad0@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=siddh.raman.pant@oracle.com \
    --cc=stable@kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®