From: Fushuai Wang <wangfushuai@baidu.com>
To: <markus.elfring@web.de>
Cc: <bharathsm@microsoft.com>, <linux-cifs@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <pc@manguebit.org>,
<ronniesahlberg@gmail.com>, <samba-technical@lists.samba.org>,
<sfrench@samba.org>, <sprasad@microsoft.com>, <tom@talpey.com>,
<wangfushuai@baidu.com>
Subject: Re: [PATCH] cifs: Fix copy_to_iter return value check
Date: Sun, 5 Oct 2025 21:51:32 +0800 [thread overview]
Message-ID: <20251005135132.33612-1-wangfushuai@baidu.com> (raw)
In-Reply-To: <912d867a-f08f-40d3-bbd3-9ada24f468fd@web.de>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="y", Size: 353 bytes --]
>> The return value of copy_to_iter() function will never be negative,
>> it is the number of bytes copied, or zero if nothing was copied.
> …
>
> Why do you propose to preserve the comparison operator part “<” then?
> Would the condition check “!length” be nicer at this place?
Yes, you are right. I will send a v2 shortly.
Regards,
Wang.
prev parent reply other threads:[~2025-10-05 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-05 6:49 Fushuai Wang
2025-10-05 10:45 ` Markus Elfring
2025-10-05 13:51 ` Fushuai Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251005135132.33612-1-wangfushuai@baidu.com \
--to=wangfushuai@baidu.com \
--cc=bharathsm@microsoft.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.elfring@web.de \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®