From: Markus Elfring <Markus.Elfring@web.de>
To: Fushuai Wang <wangfushuai@baidu.com>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
Bharath SM <bharathsm@microsoft.com>,
Paulo Alcantara <pc@manguebit.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Steve French <sfrench@samba.org>, Tom Talpey <tom@talpey.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cifs: Fix copy_to_iter return value check
Date: Sun, 5 Oct 2025 12:45:47 +0200 [thread overview]
Message-ID: <912d867a-f08f-40d3-bbd3-9ada24f468fd@web.de> (raw)
In-Reply-To: <20251005064952.4056-1-wangfushuai@baidu.com>
> The return value of copy_to_iter() function will never be negative,
> it is the number of bytes copied, or zero if nothing was copied.
…
Why do you propose to preserve the comparison operator part “<” then?
Would the condition check “!length” be nicer at this place?
Regards,
Markus
next prev parent reply other threads:[~2025-10-05 10:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-05 6:49 Fushuai Wang
2025-10-05 10:45 ` Markus Elfring [this message]
2025-10-05 13:51 ` Fushuai Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=912d867a-f08f-40d3-bbd3-9ada24f468fd@web.de \
--to=markus.elfring@web.de \
--cc=bharathsm@microsoft.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=wangfushuai@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®