From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, hehuan1@eswincomputing.com,
ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, jszhang@kernel.org, adrian.hunter@intel.com,
p.zabel@pengutronix.de, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
ningyu@eswincomputing.com, linmin@eswincomputing.com,
pinkesh.vaghela@einfochips.com, xuxiang@eswincomputing.com,
luyulin@eswincomputing.com, dongxuyang@eswincomputing.com,
zhangsenchuan@eswincomputing.com,
weishangjuan@eswincomputing.com, lizhi2@eswincomputing.com,
caohang@eswincomputing.com, hehuan1@eswincomputing.com
Subject: Re: [PATCH v4 2/2] mmc: sdhci-of-dwcmshc: Add support for Eswin EIC7700
Date: Tue, 14 Oct 2025 11:42:22 +0300 [thread overview]
Message-ID: <202510131636.lJ5QxMpK-lkp@intel.com> (raw)
In-Reply-To: <20251011111216.570-1-hehuan1@eswincomputing.com>
Hi,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/hehuan1-eswincomputing-com/dt-bindings-mmc-sdhci-of-dwcmshc-Add-Eswin-EIC7700/20251011-191312
base: linus/master
patch link: https://lore.kernel.org/r/20251011111216.570-1-hehuan1%40eswincomputing.com
patch subject: [PATCH v4 2/2] mmc: sdhci-of-dwcmshc: Add support for Eswin EIC7700
config: s390-randconfig-r073-20251013 (https://download.01.org/0day-ci/archive/20251013/202510131636.lJ5QxMpK-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202510131636.lJ5QxMpK-lkp@intel.com/
New smatch warnings:
drivers/mmc/host/sdhci-of-dwcmshc.c:1547 eic7700_init() warn: missing error code? 'ret'
vim +/ret +1547 drivers/mmc/host/sdhci-of-dwcmshc.c
3c5c200f02eee8 Huan He 2025-10-11 1516 static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcmshc_priv *dwc_priv)
3c5c200f02eee8 Huan He 2025-10-11 1517 {
3c5c200f02eee8 Huan He 2025-10-11 1518 u32 emmc_caps = MMC_CAP2_NO_SD | MMC_CAP2_NO_SDIO;
3c5c200f02eee8 Huan He 2025-10-11 1519 unsigned int val, hsp_int_status, hsp_pwr_ctrl;
3c5c200f02eee8 Huan He 2025-10-11 1520 struct of_phandle_args args;
3c5c200f02eee8 Huan He 2025-10-11 1521 struct eic7700_priv *priv;
3c5c200f02eee8 Huan He 2025-10-11 1522 struct regmap *hsp_regmap;
3c5c200f02eee8 Huan He 2025-10-11 1523 int ret;
3c5c200f02eee8 Huan He 2025-10-11 1524
3c5c200f02eee8 Huan He 2025-10-11 1525 priv = devm_kzalloc(dev, sizeof(struct eic7700_priv), GFP_KERNEL);
3c5c200f02eee8 Huan He 2025-10-11 1526 if (!priv)
3c5c200f02eee8 Huan He 2025-10-11 1527 return -ENOMEM;
3c5c200f02eee8 Huan He 2025-10-11 1528
3c5c200f02eee8 Huan He 2025-10-11 1529 dwc_priv->priv = priv;
3c5c200f02eee8 Huan He 2025-10-11 1530
3c5c200f02eee8 Huan He 2025-10-11 1531 ret = sdhci_eic7700_reset_init(dev, dwc_priv->priv);
3c5c200f02eee8 Huan He 2025-10-11 1532 if (ret) {
3c5c200f02eee8 Huan He 2025-10-11 1533 dev_err(dev, "failed to reset\n");
3c5c200f02eee8 Huan He 2025-10-11 1534 return ret;
3c5c200f02eee8 Huan He 2025-10-11 1535 }
3c5c200f02eee8 Huan He 2025-10-11 1536
3c5c200f02eee8 Huan He 2025-10-11 1537 ret = of_parse_phandle_with_fixed_args(dev->of_node, "eswin,hsp-sp-csr", 2, 0, &args);
3c5c200f02eee8 Huan He 2025-10-11 1538 if (ret) {
3c5c200f02eee8 Huan He 2025-10-11 1539 dev_err(dev, "Fail to parse 'eswin,hsp-sp-csr' phandle (%d)\n", ret);
3c5c200f02eee8 Huan He 2025-10-11 1540 return ret;
3c5c200f02eee8 Huan He 2025-10-11 1541 }
3c5c200f02eee8 Huan He 2025-10-11 1542
3c5c200f02eee8 Huan He 2025-10-11 1543 hsp_regmap = syscon_node_to_regmap(args.np);
3c5c200f02eee8 Huan He 2025-10-11 1544 if (IS_ERR(hsp_regmap)) {
3c5c200f02eee8 Huan He 2025-10-11 1545 dev_err(dev, "Failed to get regmap for 'eswin,hsp-sp-csr'\n");
3c5c200f02eee8 Huan He 2025-10-11 1546 of_node_put(args.np);
3c5c200f02eee8 Huan He 2025-10-11 @1547 return ret;
return PTR_ERR(hsp_regmap);
3c5c200f02eee8 Huan He 2025-10-11 1548 }
3c5c200f02eee8 Huan He 2025-10-11 1549 hsp_int_status = args.args[0];
3c5c200f02eee8 Huan He 2025-10-11 1550 hsp_pwr_ctrl = args.args[1];
3c5c200f02eee8 Huan He 2025-10-11 1551 of_node_put(args.np);
3c5c200f02eee8 Huan He 2025-10-11 1552 /*
3c5c200f02eee8 Huan He 2025-10-11 1553 * Assert clock stability: write EIC7700_INT_CLK_STABLE to hsp_int_status.
3c5c200f02eee8 Huan He 2025-10-11 1554 * This signals to the eMMC controller that platform clocks (card, ACLK,
3c5c200f02eee8 Huan He 2025-10-11 1555 * BCLK, TMCLK) are enabled and stable.
3c5c200f02eee8 Huan He 2025-10-11 1556 */
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-10-14 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-11 11:10 [PATCH v4 0/2] Add support for Eswin EIC7700 SD/eMMC controller hehuan1
2025-10-11 11:11 ` [PATCH v4 1/2] dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700 hehuan1
2025-10-13 11:40 ` Rob Herring
2025-10-11 11:12 ` [PATCH v4 2/2] mmc: sdhci-of-dwcmshc: Add support for " hehuan1
2025-10-14 8:42 ` Dan Carpenter [this message]
2025-10-15 13:09 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202510131636.lJ5QxMpK-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=caohang@eswincomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongxuyang@eswincomputing.com \
--cc=hehuan1@eswincomputing.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lizhi2@eswincomputing.com \
--cc=lkp@intel.com \
--cc=luyulin@eswincomputing.com \
--cc=ningyu@eswincomputing.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=pinkesh.vaghela@einfochips.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=weishangjuan@eswincomputing.com \
--cc=xuxiang@eswincomputing.com \
--cc=zhangsenchuan@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®