* [PATCH sched_ext/for-6.19] sched_ext: Fix build error in cgroup_set_idle()
@ 2025-10-13 19:30 Andrea Righi
2025-10-14 20:28 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Andrea Righi @ 2025-10-13 19:30 UTC (permalink / raw)
To: Tejun Heo, David Vernet, Changwoo Min; +Cc: sched-ext, linux-kernel
Commit a5bd6ba30b336 ("sched_ext: Use cgroup_lock/unlock() to
synchronize against cgroup operations") renamed scx_cgroup_rwsem to
scx_cgroup_ops_rwsem.
Update cgroup_set_idle() accordingly to fix the resulting build error.
Fixes: d579dc6eb4fd0 ("sched/ext: Implement cgroup_set_idle() callback")
Signed-off-by: Andrea Righi <arighi@nvidia.com>
---
kernel/sched/ext.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 228f4faef7670..430749ce46ab3 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -3217,7 +3217,7 @@ void scx_group_set_idle(struct task_group *tg, bool idle)
{
struct scx_sched *sch = scx_root;
- percpu_down_read(&scx_cgroup_rwsem);
+ percpu_down_read(&scx_cgroup_ops_rwsem);
if (scx_cgroup_enabled && SCX_HAS_OP(sch, cgroup_set_idle))
SCX_CALL_OP(sch, SCX_KF_UNLOCKED, cgroup_set_idle, NULL,
@@ -3226,7 +3226,7 @@ void scx_group_set_idle(struct task_group *tg, bool idle)
/* Update the task group's idle state */
tg->scx.idle = idle;
- percpu_up_read(&scx_cgroup_rwsem);
+ percpu_up_read(&scx_cgroup_ops_rwsem);
}
void scx_group_set_bandwidth(struct task_group *tg,
--
2.51.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH sched_ext/for-6.19] sched_ext: Fix build error in cgroup_set_idle()
2025-10-13 19:30 [PATCH sched_ext/for-6.19] sched_ext: Fix build error in cgroup_set_idle() Andrea Righi
@ 2025-10-14 20:28 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2025-10-14 20:28 UTC (permalink / raw)
To: Andrea Righi; +Cc: David Vernet, Changwoo Min, sched-ext, linux-kernel
On Mon, Oct 13, 2025 at 09:30:03PM +0200, Andrea Righi wrote:
> Commit a5bd6ba30b336 ("sched_ext: Use cgroup_lock/unlock() to
> synchronize against cgroup operations") renamed scx_cgroup_rwsem to
> scx_cgroup_ops_rwsem.
>
> Update cgroup_set_idle() accordingly to fix the resulting build error.
>
> Fixes: d579dc6eb4fd0 ("sched/ext: Implement cgroup_set_idle() callback")
> Signed-off-by: Andrea Righi <arighi@nvidia.com>
Oh, I fixed this by updating the top of the tree. Sorry about the breakage.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-14 20:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-13 19:30 [PATCH sched_ext/for-6.19] sched_ext: Fix build error in cgroup_set_idle() Andrea Righi
2025-10-14 20:28 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®