* [PATCH v1] perf trace: Don't synthesize mmaps unless callchains are enabled
@ 2025-10-18 4:59 Ian Rogers
2025-10-18 5:19 ` Howard Chu
2025-10-20 2:11 ` Namhyung Kim
0 siblings, 2 replies; 3+ messages in thread
From: Ian Rogers @ 2025-10-18 4:59 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Alexander Shishkin, Jiri Olsa, Ian Rogers,
Adrian Hunter, linux-perf-users, linux-kernel, Stephane Eranian
Synthesizing mmaps in perf trace is unnecessary unless call chains are
being generated.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/builtin-trace.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index c607f39b8c8b..a743bda294bd 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -2005,7 +2005,9 @@ static int trace__symbols_init(struct trace *trace, int argc, const char **argv,
err = __machine__synthesize_threads(trace->host, &trace->tool, &trace->opts.target,
evlist->core.threads, trace__tool_process,
- true, false, 1);
+ /*needs_mmap=*/callchain_param.enabled,
+ /*mmap_data=*/false,
+ /*nr_threads_synthesize=*/1);
out:
if (err) {
perf_env__exit(&trace->host_env);
--
2.51.0.858.gf9c4a03a3a-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] perf trace: Don't synthesize mmaps unless callchains are enabled
2025-10-18 4:59 [PATCH v1] perf trace: Don't synthesize mmaps unless callchains are enabled Ian Rogers
@ 2025-10-18 5:19 ` Howard Chu
2025-10-20 2:11 ` Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: Howard Chu @ 2025-10-18 5:19 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
linux-perf-users, linux-kernel, Stephane Eranian
Hi Ian,
(It's been a while, forgot to switch on plain text mode)
On Fri, Oct 17, 2025 at 9:59 PM Ian Rogers <irogers@google.com> wrote:
>
> Synthesizing mmaps in perf trace is unnecessary unless call chains are
> being generated.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Howard Chu <howardchu95@gmail.com>
Thanks,
Howard
> ---
> tools/perf/builtin-trace.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index c607f39b8c8b..a743bda294bd 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -2005,7 +2005,9 @@ static int trace__symbols_init(struct trace *trace, int argc, const char **argv,
>
> err = __machine__synthesize_threads(trace->host, &trace->tool, &trace->opts.target,
> evlist->core.threads, trace__tool_process,
> - true, false, 1);
> + /*needs_mmap=*/callchain_param.enabled,
> + /*mmap_data=*/false,
> + /*nr_threads_synthesize=*/1);
> out:
> if (err) {
> perf_env__exit(&trace->host_env);
> --
> 2.51.0.858.gf9c4a03a3a-goog
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] perf trace: Don't synthesize mmaps unless callchains are enabled
2025-10-18 4:59 [PATCH v1] perf trace: Don't synthesize mmaps unless callchains are enabled Ian Rogers
2025-10-18 5:19 ` Howard Chu
@ 2025-10-20 2:11 ` Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2025-10-20 2:11 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Alexander Shishkin, Jiri Olsa, Adrian Hunter, linux-perf-users,
linux-kernel, Stephane Eranian, Ian Rogers
On Fri, 17 Oct 2025 21:59:02 -0700, Ian Rogers wrote:
> Synthesizing mmaps in perf trace is unnecessary unless call chains are
> being generated.
>
>
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-20 2:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-18 4:59 [PATCH v1] perf trace: Don't synthesize mmaps unless callchains are enabled Ian Rogers
2025-10-18 5:19 ` Howard Chu
2025-10-20 2:11 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®