* [PATCH] dt-bindings: leds: Add TI LM36274 backlight driver schema
@ 2025-10-20 14:04 Erick Setubal Bacurau
2025-10-20 15:09 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Erick Setubal Bacurau @ 2025-10-20 14:04 UTC (permalink / raw)
To: lee, pavel, robh, krzk+dt, conor+dt, linux-leds, devicetree,
linux-kernel, skhan, linux-kernel-mentees, david.hunter.linux
Cc: Erick Setubal Bacurau
Add the DeviceTree binding schema for the Texas Instruments LM36274.
Signed-off-by: Erick Setubal Bacurau <erick.setubal@gmx.de>
---
.../bindings/leds/leds-lm36274.yaml | 81 +++++++++++++++++++
1 file changed, 81 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/leds-lm36274.yaml
diff --git a/Documentation/devicetree/bindings/leds/leds-lm36274.yaml b/Documentation/devicetree/bindings/leds/leds-lm36274.yaml
new file mode 100644
index 000000000000..390ca660c0be
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-lm36274.yaml
@@ -0,0 +1,81 @@
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/leds-lm36274.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Texas Instruments LM36274 4-Channel LCD Backlight Driver w/Integrated Bias
+maintainers: [Erick Setubal Bacurau <erick.setubal@gmx.de>]
+description:
+ The LM36274 is an integrated four-channel WLED driver and LCD bias supply.
+ The backlight boost provides the power to bias four parallel LED strings with
+ up to 29V total output voltage. The 11-bit LED current is programmable via
+ the I2C bus and/or controlled via a logic level PWM input from 60 uA to 30 mA.
+ For more product information please see the link https://www.ti.com/lit/ds/symlink/lm36274.pdf
+
+properties:
+ compatible:
+ const: ti,lm36274-backlight
+ reg:
+ maxItems: 1
+ description: I2C address of the device.
+
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 0
+
+ label:
+ $ref: /schemas/leds/common.yaml#/properties/label
+
+ linux,default-trigger:
+ $ref: /schemas/leds/common.yaml#/properties/linux,default-trigger
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+patternProperties:
+ '^led@[0-3]$':
+ type: object
+ properties:
+ reg:
+ description: LED channel index (0..3)
+ minimum: 0
+ maximum: 3
+
+ led-sources:
+ description: Indicates which LED strings will be enabled (0..3).
+ allOf:
+ - $ref: /schemas/leds/common.yaml#/properties/led-sources
+ - type: array
+ items:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 3
+ maxItems: 4
+ uniqueItems: true
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ backlight@11 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x11>;
+ compatible = "ti,lm36274-backlight";
+
+ led@0 {
+ reg = <0>;
+ led-sources = <0 2>;
+ label = "white:backlight_cluster";
+ linux,default-trigger = "backlight";
+ };
+ };
+ };
+
+
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: leds: Add TI LM36274 backlight driver schema
2025-10-20 14:04 [PATCH] dt-bindings: leds: Add TI LM36274 backlight driver schema Erick Setubal Bacurau
@ 2025-10-20 15:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-20 15:09 UTC (permalink / raw)
To: Erick Setubal Bacurau, lee, pavel, robh, krzk+dt, conor+dt,
linux-leds, devicetree, linux-kernel, skhan,
linux-kernel-mentees, david.hunter.linux
On 20/10/2025 16:04, Erick Setubal Bacurau wrote:
> Add the DeviceTree binding schema for the Texas Instruments LM36274.
>
> Signed-off-by: Erick Setubal Bacurau <erick.setubal@gmx.de>
> ---
> .../bindings/leds/leds-lm36274.yaml | 81 +++++++++++++++++++
Why do you add this without any users?
> 1 file changed, 81 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm36274.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lm36274.yaml b/Documentation/devicetree/bindings/leds/leds-lm36274.yaml
> new file mode 100644
> index 000000000000..390ca660c0be
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-lm36274.yaml
> @@ -0,0 +1,81 @@
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-lm36274.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +title: Texas Instruments LM36274 4-Channel LCD Backlight Driver w/Integrated Bias
> +maintainers: [Erick Setubal Bacurau <erick.setubal@gmx.de>]
Don't code with AI. This looks like nothing in existing code, 100%
different, so I do not see how you could come with this.
Any AI slop is waste of our time. Please start from scratch from latest
approved bindings (including correct file naming) and provide users.
NAK.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-20 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-20 14:04 [PATCH] dt-bindings: leds: Add TI LM36274 backlight driver schema Erick Setubal Bacurau
2025-10-20 15:09 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®