[PATCH] kernel/sched: removed unused *cpumask ptr in kernel/sched/sched.h

[PATCH] kernel/sched: removed unused *cpumask ptr in kernel/sched/sched.h

[Aditya Gollamudi]

From: Adi Gollamudi <adigollamudi@gmail.com>

remove use of cpumask ptr initialized at the top of the mm_cid_get() function to nothing.
remove initialization of cpumask ptr in the same function, "cpumask = mm_cidmask(mm);" because
it is not used later.

Signed-off-by: Adi Gollamudi <adigollamudi@gmail.com>
---
 kernel/sched/sched.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index be9745d104f7..d5d943681bf8 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -3710,11 +3710,9 @@ static inline int mm_cid_get(struct rq *rq, struct task_struct *t,
 			     struct mm_struct *mm)
 {
 	struct mm_cid __percpu *pcpu_cid = mm->pcpu_cid;
-	struct cpumask *cpumask;
 	int cid;
 
 	lockdep_assert_rq_held(rq);
-	cpumask = mm_cidmask(mm);
 	cid = __this_cpu_read(pcpu_cid->cid);
 	if (mm_cid_is_valid(cid)) {
 		mm_cid_snapshot_time(rq, mm);
-- 
2.34.1

[PATCH v2] kernel/sched: removed unused *cpumask ptr in kernel/sched/sched.h

[Aditya Gollamudi]

From: Adi Gollamudi <adigollamudi@gmail.com>

v2: fix formatting and style errors found by checkpatch.pl. no actual functional changes

v1: remove use of cpumask ptr initialized at the top of the mm_cid_get() function to nothing.
remove initialization of cpumask ptr in the same function, "cpumask = mm_cidmask(mm);" because
it is not used later.

Signed-off-by: Adi Gollamudi <adigollamudi@gmail.com>
---
 kernel/sched/sched.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index be9745d104f7..d5d943681bf8 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -3710,11 +3710,9 @@ static inline int mm_cid_get(struct rq *rq, struct task_struct *t,
 			     struct mm_struct *mm)
 {
 	struct mm_cid __percpu *pcpu_cid = mm->pcpu_cid;
-	struct cpumask *cpumask;
 	int cid;

 	lockdep_assert_rq_held(rq);
-	cpumask = mm_cidmask(mm);
 	cid = __this_cpu_read(pcpu_cid->cid);
 	if (mm_cid_is_valid(cid)) {
 		mm_cid_snapshot_time(rq, mm);
--
2.34.1

Re: [PATCH v2] kernel/sched: removed unused *cpumask ptr in kernel/sched/sched.h

[Valentin Schneider]

On 20/10/25 15:17, Aditya Gollamudi wrote:
> From: Adi Gollamudi <adigollamudi@gmail.com>
>
> v2: fix formatting and style errors found by checkpatch.pl. no actual functional changes
>
> v1: remove use of cpumask ptr initialized at the top of the mm_cid_get() function to nothing.
> remove initialization of cpumask ptr in the same function, "cpumask = mm_cidmask(mm);" because
> it is not used later.
>

Please see Documentation/process/submitting-patches; the version changelogs
don't belong in the patch body but should rather be put after the '---'
marker line.

Re: [PATCH v2] kernel/sched: removed unused *cpumask ptr in kernel/sched/sched.h

[Peter Zijlstra]

On Tue, Oct 21, 2025 at 09:58:29AM +0200, Valentin Schneider wrote:
> On 20/10/25 15:17, Aditya Gollamudi wrote:
> > From: Adi Gollamudi <adigollamudi@gmail.com>
> >
> > v2: fix formatting and style errors found by checkpatch.pl. no actual functional changes
> >
> > v1: remove use of cpumask ptr initialized at the top of the mm_cid_get() function to nothing.
> > remove initialization of cpumask ptr in the same function, "cpumask = mm_cidmask(mm);" because
> > it is not used later.
> >
> 
> Please see Documentation/process/submitting-patches; the version changelogs
> don't belong in the patch body but should rather be put after the '---'
> marker line.
> 

Also, please search the archives before sending patches like this.
You'll find I have at least 5 versions of this patch already, and I'm
still not convinced its worth applying.