From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Artem Shimko <a.shimko.dev@gmail.com>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Artem Shimko <a.shimko.dev@gmail.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] dmaengine: dw-axi-dmac: add reset control support
Date: Wed, 22 Oct 2025 15:08:10 +0300 [thread overview]
Message-ID: <202510221508.PY6fB9CB-lkp@intel.com> (raw)
In-Reply-To: <20251017102950.206443-3-a.shimko.dev@gmail.com>
Hi Artem,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Artem-Shimko/dmaengine-dw-axi-dmac-simplify-PM-functions-and-use-modern-macros/20251017-183103
base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
patch link: https://lore.kernel.org/r/20251017102950.206443-3-a.shimko.dev%40gmail.com
patch subject: [PATCH v4 2/2] dmaengine: dw-axi-dmac: add reset control support
config: loongarch-randconfig-r072-20251019 (https://download.01.org/0day-ci/archive/20251022/202510221508.PY6fB9CB-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 15.1.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202510221508.PY6fB9CB-lkp@intel.com/
New smatch warnings:
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1355 axi_dma_resume() warn: 'chip->core_clk' from clk_prepare_enable() not released on lines: 1350.
Old smatch warnings:
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1237 dma_chan_pause() warn: inconsistent indenting
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1284 axi_chan_resume() warn: inconsistent indenting
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1355 axi_dma_resume() warn: 'chip->cfgr_clk' from clk_prepare_enable() not released on lines: 1346,1350.
vim +1355 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
45fdf99125b2bf7 Artem Shimko 2025-10-17 1335 static int axi_dma_resume(struct device *dev)
I guess kbuild bot thinks these are new warnings because the function
was renamed. In the past we've just ignored clk_prepare_enable() warnings.
Perhaps that's the correct thing to do in a resume function.
The indenting in dma_chan_pause() and axi_chan_resume() could be cleaned up.
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1336 {
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1337 int ret;
45fdf99125b2bf7 Artem Shimko 2025-10-17 1338 struct axi_dma_chip *chip = dev_get_drvdata(dev);
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1339
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1340 ret = clk_prepare_enable(chip->cfgr_clk);
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1341 if (ret < 0)
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1342 return ret;
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1343
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1344 ret = clk_prepare_enable(chip->core_clk);
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1345 if (ret < 0)
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1346 return ret;
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1347
9c360f02c387f93 Artem Shimko 2025-10-17 1348 ret = reset_control_deassert(chip->resets);
9c360f02c387f93 Artem Shimko 2025-10-17 1349 if (ret)
9c360f02c387f93 Artem Shimko 2025-10-17 1350 return ret;
9c360f02c387f93 Artem Shimko 2025-10-17 1351
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1352 axi_dma_enable(chip);
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1353 axi_dma_irq_enable(chip);
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1354
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 @1355 return 0;
1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1356 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2025-10-22 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 10:29 [PATCH v4 0/2] dmaengine: dw-axi-dmac: PM cleanup and " Artem Shimko
2025-10-17 10:29 ` [PATCH v4 1/2] dmaengine: dw-axi-dmac: simplify PM functions and use modern macros Artem Shimko
2025-10-17 10:29 ` [PATCH v4 2/2] dmaengine: dw-axi-dmac: add reset control support Artem Shimko
2025-10-22 12:08 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202510221508.PY6fB9CB-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=a.shimko.dev@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®