mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	John Ogness <john.ogness@linutronix.de>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk_legacy_map: use LD_WAIT_CONFIG instead of LD_WAIT_SLEEP
Date: Thu, 23 Oct 2025 11:28:13 +0200	[thread overview]
Message-ID: <20251023092812.GA26461@redhat.com> (raw)
In-Reply-To: <aPneEnDQmHhpvRkG@pathway.suse.cz>

On 10/23, Petr Mladek wrote:
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>

Thanks!

> This is much more clear. It might make sense to improve the comment,
> for example:
>
> <proposal>
> /*
>  * Legacy console printing from printk() caller context does not respect
>  * raw_spinlock/spinlock nesting. However, on PREEMPT_RT the printing
>  * path from atomic context is always avoided and the console driver
>  * is always invoked from a dedicated thread. Thus the lockdep splat
>  * on !PREEMPT_RT is a false positive.
>  *
>  * This map is used to temporarily establish LD_WAIT_CONFIG context for the
>  * console write() callback when legacy printing to avoid false positive
>  * lockdep complaints, thus allowing lockdep to continue to function for
>  * real issues.
>  */
> </proposal>

Agreed, will do and send V2.

Oleg.


  parent reply	other threads:[~2025-10-23  9:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22 15:41 Oleg Nesterov
2025-10-23  7:49 ` Petr Mladek
2025-10-23  8:58   ` John Ogness
2025-10-23 10:28     ` Oleg Nesterov
2025-10-23  9:28   ` Oleg Nesterov [this message]
2025-10-23 10:32 ` [PATCH v2] " Oleg Nesterov
2025-10-23 14:26   ` Sebastian Andrzej Siewior
2025-10-23 15:06     ` John Ogness
2025-10-23 15:11       ` Sebastian Andrzej Siewior
2025-10-23 15:46         ` John Ogness
2025-10-23 15:46         ` Oleg Nesterov
2025-10-23 19:14           ` Sebastian Andrzej Siewior
2025-10-24  9:35             ` Petr Mladek
2025-10-24 10:38               ` Sebastian Andrzej Siewior
2025-10-24 12:57                 ` Petr Mladek
2025-10-24 15:15                   ` Oleg Nesterov
2025-10-24 10:40     ` Oleg Nesterov
2025-10-24 10:52       ` Sebastian Andrzej Siewior
2025-10-24 11:00         ` Oleg Nesterov
2025-10-26 15:07 ` [PATCH v3] " Oleg Nesterov
2025-10-27  8:28   ` Sebastian Andrzej Siewior
2025-10-27  8:37   ` John Ogness
2025-10-29 13:15   ` Petr Mladek
2025-10-29 17:00   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251023092812.GA26461@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome