* [PATCH] video: valkyriefb: Fix reference count leak in valkyriefb_init
@ 2025-10-27 8:43 Miaoqian Lin
2025-10-28 21:15 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2025-10-27 8:43 UTC (permalink / raw)
To: Helge Deller, Paul Mackerras, Benjamin Herrenschmidt,
linux-fbdev, dri-devel, linux-kernel
Cc: linmq006, stable
The of_find_node_by_name() function returns a device tree node with its
reference count incremented. The caller is responsible for calling
of_node_put() to release this reference when done.
Found via static analysis.
Fixes: cc5d0189b9ba ("[PATCH] powerpc: Remove device_node addrs/n_addr")
Cc: stable@vger.kernel.org
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/video/fbdev/valkyriefb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/fbdev/valkyriefb.c b/drivers/video/fbdev/valkyriefb.c
index 91d070ef6989..6ff059ee1694 100644
--- a/drivers/video/fbdev/valkyriefb.c
+++ b/drivers/video/fbdev/valkyriefb.c
@@ -329,11 +329,13 @@ static int __init valkyriefb_init(void)
if (of_address_to_resource(dp, 0, &r)) {
printk(KERN_ERR "can't find address for valkyrie\n");
+ of_node_put(dp);
return 0;
}
frame_buffer_phys = r.start;
cmap_regs_phys = r.start + 0x304000;
+ of_node_put(dp);
}
#endif /* ppc (!CONFIG_MAC) */
--
2.39.5 (Apple Git-154)
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] video: valkyriefb: Fix reference count leak in valkyriefb_init
2025-10-27 8:43 [PATCH] video: valkyriefb: Fix reference count leak in valkyriefb_init Miaoqian Lin
@ 2025-10-28 21:15 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2025-10-28 21:15 UTC (permalink / raw)
To: Miaoqian Lin, Paul Mackerras, Benjamin Herrenschmidt,
linux-fbdev, dri-devel, linux-kernel
Cc: stable
On 10/27/25 09:43, Miaoqian Lin wrote:
> The of_find_node_by_name() function returns a device tree node with its
> reference count incremented. The caller is responsible for calling
> of_node_put() to release this reference when done.
>
> Found via static analysis.
>
> Fixes: cc5d0189b9ba ("[PATCH] powerpc: Remove device_node addrs/n_addr")
> Cc: stable@vger.kernel.org
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/video/fbdev/valkyriefb.c | 2 ++
> 1 file changed, 2 insertions(+)
applied.
Thanks!
Helge
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-28 21:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-27 8:43 [PATCH] video: valkyriefb: Fix reference count leak in valkyriefb_init Miaoqian Lin
2025-10-28 21:15 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®