mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Shawn Lin" <shawn.lin@rock-chips.com>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	 linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org,  kernel@collabora.com,
	Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: [PATCH v4 2/9] PCI: dw-rockchip: Support get_ltssm operation
Date: Wed, 29 Oct 2025 18:56:41 +0100	[thread overview]
Message-ID: <20251029-rockchip-pcie-system-suspend-v4-2-ce2e1b0692d2@collabora.com> (raw)
In-Reply-To: <20251029-rockchip-pcie-system-suspend-v4-0-ce2e1b0692d2@collabora.com>

Implement .get_ltssm operation function pointer, which will be needed
for system suspend support. As the driver used to have a function
called rockchip_pcie_get_ltssm() with different behavior the new
function is named rockchip_pcie_get_ltssm_state(), so that issues
can easily be detected when porting patches.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 drivers/pci/controller/dwc/pcie-dw-rockchip.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
index 58427db1cc65..e3d7792f7819 100644
--- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
+++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
@@ -180,6 +180,14 @@ static u32 rockchip_pcie_get_ltssm_status_reg(struct rockchip_pcie *rockchip)
 	return rockchip_pcie_readl_apb(rockchip, PCIE_CLIENT_LTSSM_STATUS);
 }
 
+static u32 rockchip_pcie_get_ltssm_state(struct dw_pcie *pci)
+{
+	struct rockchip_pcie *rockchip = to_rockchip_pcie(pci);
+	u32 val = rockchip_pcie_get_ltssm_status_reg(rockchip);
+
+	return FIELD_GET(PCIE_LTSSM_STATUS_MASK, val);
+}
+
 static void rockchip_pcie_enable_ltssm(struct rockchip_pcie *rockchip)
 {
 	rockchip_pcie_writel_apb(rockchip, PCIE_CLIENT_ENABLE_LTSSM,
@@ -446,6 +454,7 @@ static const struct dw_pcie_ops dw_pcie_ops = {
 	.link_up = rockchip_pcie_link_up,
 	.start_link = rockchip_pcie_start_link,
 	.stop_link = rockchip_pcie_stop_link,
+	.get_ltssm = rockchip_pcie_get_ltssm_state,
 };
 
 static irqreturn_t rockchip_pcie_rc_sys_irq_thread(int irq, void *arg)

-- 
2.51.0


  parent reply	other threads:[~2025-10-29 17:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29 17:56 [PATCH v4 0/9] PCI: dw-rockchip: add system suspend support Sebastian Reichel
2025-10-29 17:56 ` [PATCH v4 1/9] PCI: dw-rockchip: Rename rockchip_pcie_get_ltssm function Sebastian Reichel
2025-10-29 23:07   ` Bjorn Helgaas
2025-10-29 17:56 ` Sebastian Reichel [this message]
2025-10-29 17:56 ` [PATCH v4 3/9] PCI: dw-rockchip: Move devm_phy_get out of phy_init Sebastian Reichel
2025-10-29 17:56 ` [PATCH v4 4/9] PCI: dw-rockchip: Add helper function for enhanced LTSSM control mode Sebastian Reichel
2025-10-29 23:11   ` Bjorn Helgaas
2025-10-29 17:56 ` [PATCH v4 5/9] PCI: dw-rockchip: Add helper function for controller mode Sebastian Reichel
2025-10-29 17:56 ` [PATCH v4 6/9] PCI: dw-rockchip: Add helper function for DDL indicator Sebastian Reichel
2025-10-29 17:56 ` [PATCH v4 7/9] PCI: dw-rockchip: Add pme_turn_off support Sebastian Reichel
2025-10-29 18:36   ` Frank Li
2025-10-29 17:56 ` [PATCH v4 8/9] PCI: dw-rockchip: Add system PM support Sebastian Reichel
2025-10-29 17:56 ` [PATCH v4 9/9] PCI: dwc: support missing PCIe device on resume Sebastian Reichel
2025-10-29 23:17   ` Bjorn Helgaas
2025-10-30  5:37   ` Krishna Chaitanya Chundru
2025-11-01 14:20     ` Manivannan Sadhasivam
2025-11-03 19:00       ` Sebastian Reichel
2025-11-01 11:19 ` [PATCH v4 0/9] PCI: dw-rockchip: add system suspend support Anand Moon
2025-11-01 13:59 ` Manivannan Sadhasivam
2025-11-03 18:58   ` Sebastian Reichel
2025-11-06 19:01     ` Anand Moon
2025-11-10  8:40       ` Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251029-rockchip-pcie-system-suspend-v4-2-ce2e1b0692d2@collabora.com \
    --to=sebastian.reichel@collabora.com \
    --cc=bhelgaas@google.com \
    --cc=heiko@sntech.de \
    --cc=jingoohan1@gmail.com \
    --cc=kernel@collabora.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®