From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com,
Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: [PATCH v4 3/9] PCI: dw-rockchip: Move devm_phy_get out of phy_init
Date: Wed, 29 Oct 2025 18:56:42 +0100 [thread overview]
Message-ID: <20251029-rockchip-pcie-system-suspend-v4-3-ce2e1b0692d2@collabora.com> (raw)
In-Reply-To: <20251029-rockchip-pcie-system-suspend-v4-0-ce2e1b0692d2@collabora.com>
By moving devm_phy_get() to the probe routine, rockchip_pcie_phy_init()
can be used to re-initialize the PCIe PHY, which is for example needed
after a system suspend/resume cycle.
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
drivers/pci/controller/dwc/pcie-dw-rockchip.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
index e3d7792f7819..8e584016e244 100644
--- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
+++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
@@ -425,14 +425,8 @@ static int rockchip_pcie_resource_get(struct platform_device *pdev,
static int rockchip_pcie_phy_init(struct rockchip_pcie *rockchip)
{
- struct device *dev = rockchip->pci.dev;
int ret;
- rockchip->phy = devm_phy_get(dev, "pcie-phy");
- if (IS_ERR(rockchip->phy))
- return dev_err_probe(dev, PTR_ERR(rockchip->phy),
- "missing PHY\n");
-
ret = phy_init(rockchip->phy);
if (ret < 0)
return ret;
@@ -674,6 +668,13 @@ static int rockchip_pcie_probe(struct platform_device *pdev)
"failed to enable vpcie3v3 regulator\n");
}
+ rockchip->phy = devm_phy_get(dev, "pcie-phy");
+ if (IS_ERR(rockchip->phy)) {
+ ret = PTR_ERR(rockchip->phy);
+ dev_err_probe(dev, ret, "missing PHY\n");
+ goto disable_regulator;
+ }
+
ret = rockchip_pcie_phy_init(rockchip);
if (ret)
goto disable_regulator;
--
2.51.0
next prev parent reply other threads:[~2025-10-29 17:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 17:56 [PATCH v4 0/9] PCI: dw-rockchip: add system suspend support Sebastian Reichel
2025-10-29 17:56 ` [PATCH v4 1/9] PCI: dw-rockchip: Rename rockchip_pcie_get_ltssm function Sebastian Reichel
2025-10-29 23:07 ` Bjorn Helgaas
2025-10-29 17:56 ` [PATCH v4 2/9] PCI: dw-rockchip: Support get_ltssm operation Sebastian Reichel
2025-10-29 17:56 ` Sebastian Reichel [this message]
2025-10-29 17:56 ` [PATCH v4 4/9] PCI: dw-rockchip: Add helper function for enhanced LTSSM control mode Sebastian Reichel
2025-10-29 23:11 ` Bjorn Helgaas
2025-10-29 17:56 ` [PATCH v4 5/9] PCI: dw-rockchip: Add helper function for controller mode Sebastian Reichel
2025-10-29 17:56 ` [PATCH v4 6/9] PCI: dw-rockchip: Add helper function for DDL indicator Sebastian Reichel
2025-10-29 17:56 ` [PATCH v4 7/9] PCI: dw-rockchip: Add pme_turn_off support Sebastian Reichel
2025-10-29 18:36 ` Frank Li
2025-10-29 17:56 ` [PATCH v4 8/9] PCI: dw-rockchip: Add system PM support Sebastian Reichel
2025-10-29 17:56 ` [PATCH v4 9/9] PCI: dwc: support missing PCIe device on resume Sebastian Reichel
2025-10-29 23:17 ` Bjorn Helgaas
2025-10-30 5:37 ` Krishna Chaitanya Chundru
2025-11-01 14:20 ` Manivannan Sadhasivam
2025-11-03 19:00 ` Sebastian Reichel
2025-11-01 11:19 ` [PATCH v4 0/9] PCI: dw-rockchip: add system suspend support Anand Moon
2025-11-01 13:59 ` Manivannan Sadhasivam
2025-11-03 18:58 ` Sebastian Reichel
2025-11-06 19:01 ` Anand Moon
2025-11-10 8:40 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029-rockchip-pcie-system-suspend-v4-3-ce2e1b0692d2@collabora.com \
--to=sebastian.reichel@collabora.com \
--cc=bhelgaas@google.com \
--cc=heiko@sntech.de \
--cc=jingoohan1@gmail.com \
--cc=kernel@collabora.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®