* [PATCH v2] drm/panel: kingdisplay-kd097d04: Disable EoTp
@ 2025-10-29 12:35 Sebastian Fleer
2025-10-29 20:39 ` Neil Armstrong
2025-10-29 20:58 ` Neil Armstrong
0 siblings, 2 replies; 3+ messages in thread
From: Sebastian Fleer @ 2025-10-29 12:35 UTC (permalink / raw)
To: dri-devel, linux-kernel
Cc: Christoph Fritz, Neil Armstrong, Jessica Zhang,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Jens Reidel
Since commit d97e71e44937 ("drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by
default") panel output on an Acer Chromebook Tab 10 (google-dru) is corrupted.
The tablet I use is equipped with a kingdisplay-kd097d04 panel, disabling EoTp
restores the correct functionality.
Fixes: 2a994cbed6b2 ("drm/panel: Add Kingdisplay KD097D04 panel driver")
Suggested-by: Jens Reidel <adrian@postmarketos.org>
Signed-off-by: Sebastian Fleer <dev@dwurp.de>
---
Changes in v2:
- Reference correct commit in Fixes tag
- Added Suggested-by
---
drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c b/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
index 2fc7b0779b37..893af9b16756 100644
--- a/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
+++ b/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
@@ -359,7 +359,7 @@ static int kingdisplay_panel_probe(struct mipi_dsi_device *dsi)
dsi->lanes = 4;
dsi->format = MIPI_DSI_FMT_RGB888;
dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
- MIPI_DSI_MODE_LPM;
+ MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET;
kingdisplay = devm_drm_panel_alloc(&dsi->dev, __typeof(*kingdisplay), base,
&kingdisplay_panel_funcs,
--
2.51.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/panel: kingdisplay-kd097d04: Disable EoTp
2025-10-29 12:35 [PATCH v2] drm/panel: kingdisplay-kd097d04: Disable EoTp Sebastian Fleer
@ 2025-10-29 20:39 ` Neil Armstrong
2025-10-29 20:58 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2025-10-29 20:39 UTC (permalink / raw)
To: Sebastian Fleer, dri-devel, linux-kernel
Cc: Christoph Fritz, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Jens Reidel
On 10/29/25 13:35, Sebastian Fleer wrote:
> Since commit d97e71e44937 ("drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by
> default") panel output on an Acer Chromebook Tab 10 (google-dru) is corrupted.
> The tablet I use is equipped with a kingdisplay-kd097d04 panel, disabling EoTp
> restores the correct functionality.
>
> Fixes: 2a994cbed6b2 ("drm/panel: Add Kingdisplay KD097D04 panel driver")
> Suggested-by: Jens Reidel <adrian@postmarketos.org>
> Signed-off-by: Sebastian Fleer <dev@dwurp.de>
> ---
>
> Changes in v2:
> - Reference correct commit in Fixes tag
> - Added Suggested-by
>
> ---
> drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c b/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
> index 2fc7b0779b37..893af9b16756 100644
> --- a/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
> +++ b/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
> @@ -359,7 +359,7 @@ static int kingdisplay_panel_probe(struct mipi_dsi_device *dsi)
> dsi->lanes = 4;
> dsi->format = MIPI_DSI_FMT_RGB888;
> dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> - MIPI_DSI_MODE_LPM;
> + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET;
>
> kingdisplay = devm_drm_panel_alloc(&dsi->dev, __typeof(*kingdisplay), base,
> &kingdisplay_panel_funcs,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/panel: kingdisplay-kd097d04: Disable EoTp
2025-10-29 12:35 [PATCH v2] drm/panel: kingdisplay-kd097d04: Disable EoTp Sebastian Fleer
2025-10-29 20:39 ` Neil Armstrong
@ 2025-10-29 20:58 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2025-10-29 20:58 UTC (permalink / raw)
To: dri-devel, linux-kernel, Sebastian Fleer
Cc: Christoph Fritz, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Jens Reidel
Hi,
On Wed, 29 Oct 2025 13:35:28 +0100, Sebastian Fleer wrote:
> Since commit d97e71e44937 ("drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by
> default") panel output on an Acer Chromebook Tab 10 (google-dru) is corrupted.
> The tablet I use is equipped with a kingdisplay-kd097d04 panel, disabling EoTp
> restores the correct functionality.
>
>
Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)
[1/1] drm/panel: kingdisplay-kd097d04: Disable EoTp
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/d8eb00bbc628c8916ab0da2bb80059d48aa4512e
--
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-29 20:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-29 12:35 [PATCH v2] drm/panel: kingdisplay-kd097d04: Disable EoTp Sebastian Fleer
2025-10-29 20:39 ` Neil Armstrong
2025-10-29 20:58 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®