From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Prakash Sangappa <prakash.sangappa@oracle.com>,
Madadi Vineeth Reddy <vineethr@linux.ibm.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org
Subject: Re: [patch V3 10/12] rseq: Implement rseq_grant_slice_extension()
Date: Wed, 29 Oct 2025 16:08:59 -0400 [thread overview]
Message-ID: <20251029160859.22bb6eed@gandalf.local.home> (raw)
In-Reply-To: <20251029130404.051555060@linutronix.de>
On Wed, 29 Oct 2025 14:22:30 +0100 (CET)
Thomas Gleixner <tglx@linutronix.de> wrote:
> +static __always_inline bool rseq_grant_slice_extension(bool work_pending)
> +{
> + struct task_struct *curr = current;
> + struct rseq_slice_ctrl usr_ctrl;
> + union rseq_slice_state state;
> + struct rseq __user *rseq;
> +
> + if (!rseq_slice_extension_enabled())
> + return false;
> +
> + /* If not enabled or not a return from interrupt, nothing to do. */
> + state = curr->rseq.slice.state;
> + state.enabled &= curr->rseq.event.user_irq;
> + if (likely(!state.state))
> + return false;
> +
> + rseq = curr->rseq.usrptr;
> + scoped_user_rw_access(rseq, efault) {
> +
> + /*
> + * Quick check conditions where a grant is not possible or
> + * needs to be revoked.
> + *
> + * 1) Any TIF bit which needs to do extra work aside of
> + * rescheduling prevents a grant.
> + *
I'm curious to why any other TIF bit causes this to refuse a grant?
If deferred unwinding gets implemented, and profiling is enabled, it uses
task_work. From my understanding, task_work will set a TIF bit. Would this
mean that we would not be able to profile this feature with the deferred
unwinder? As profiling it will prevent it from being used?
-- Steve
> + * 2) A previous rescheduling request resulted in a slice
> + * extension grant.
> + */
> + if (unlikely(work_pending || state.granted)) {
> + /* Clear user control unconditionally. No point for checking */
> + unsafe_put_user(0U, &rseq->slice_ctrl.all, efault);
> + rseq_slice_clear_grant(curr);
> + return false;
> + }
> +
> + unsafe_get_user(usr_ctrl.all, &rseq->slice_ctrl.all, efault);
> + if (likely(!(usr_ctrl.request)))
> + return false;
> +
> + /* Grant the slice extention */
> + usr_ctrl.request = 0;
> + usr_ctrl.granted = 1;
> + unsafe_put_user(usr_ctrl.all, &rseq->slice_ctrl.all, efault);
> + }
> +
next prev parent reply other threads:[~2025-10-29 20:08 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 13:22 [patch V3 00/12] rseq: Implement time slice extension mechanism Thomas Gleixner
2025-10-29 13:22 ` [patch V3 01/12] sched: Provide and use set_need_resched_current() Thomas Gleixner
2025-10-29 13:22 ` [patch V3 02/12] rseq: Add fields and constants for time slice extension Thomas Gleixner
2025-10-30 22:01 ` Prakash Sangappa
2025-10-31 14:32 ` Thomas Gleixner
2025-10-31 19:31 ` Mathieu Desnoyers
2025-10-31 20:58 ` Thomas Gleixner
2025-11-01 22:53 ` Thomas Gleixner
2025-11-03 17:00 ` Mathieu Desnoyers
2025-11-03 19:19 ` Florian Weimer
2025-11-04 0:20 ` Steven Rostedt
2025-10-29 13:22 ` [patch V3 03/12] rseq: Provide static branch for time slice extensions Thomas Gleixner
2025-10-29 17:23 ` Randy Dunlap
2025-10-29 21:12 ` Thomas Gleixner
2025-10-31 19:34 ` Mathieu Desnoyers
2025-10-29 13:22 ` [patch V3 04/12] rseq: Add statistics " Thomas Gleixner
2025-10-31 19:36 ` Mathieu Desnoyers
2025-10-29 13:22 ` [patch V3 05/12] rseq: Add prctl() to enable " Thomas Gleixner
2025-10-31 19:43 ` Mathieu Desnoyers
2025-10-31 21:05 ` Thomas Gleixner
2025-10-29 13:22 ` [patch V3 06/12] rseq: Implement sys_rseq_slice_yield() Thomas Gleixner
2025-10-31 19:46 ` Mathieu Desnoyers
2025-10-31 21:07 ` Thomas Gleixner
2025-11-03 17:07 ` Mathieu Desnoyers
2025-10-29 13:22 ` [patch V3 07/12] rseq: Implement syscall entry work for time slice extensions Thomas Gleixner
2025-10-31 19:53 ` Mathieu Desnoyers
2025-11-19 0:20 ` Prakash Sangappa
2025-11-19 15:25 ` Thomas Gleixner
2025-11-20 7:37 ` Prakash Sangappa
2025-11-20 11:31 ` Thomas Gleixner
2025-11-21 0:12 ` Prakash Sangappa
2025-11-26 22:02 ` Prakash Sangappa
2025-11-21 9:28 ` david laight
2025-10-29 13:22 ` [patch V3 08/12] rseq: Implement time slice extension enforcement timer Thomas Gleixner
2025-10-29 18:45 ` Steven Rostedt
2025-10-29 21:37 ` Thomas Gleixner
2025-10-29 23:53 ` Steven Rostedt
2025-10-31 19:59 ` Mathieu Desnoyers
2025-10-29 13:22 ` [patch V3 09/12] rseq: Reset slice extension when scheduled Thomas Gleixner
2025-10-31 20:03 ` Mathieu Desnoyers
2025-10-29 13:22 ` [patch V3 10/12] rseq: Implement rseq_grant_slice_extension() Thomas Gleixner
2025-10-29 20:08 ` Steven Rostedt [this message]
2025-10-29 21:46 ` Thomas Gleixner
2025-10-29 22:04 ` Steven Rostedt
2025-10-31 14:33 ` Thomas Gleixner
2025-10-29 13:22 ` [patch V3 11/12] entry: Hook up rseq time slice extension Thomas Gleixner
2025-10-29 13:22 ` [patch V3 12/12] selftests/rseq: Implement time slice extension test Thomas Gleixner
2025-10-29 15:10 ` [patch V3 00/12] rseq: Implement time slice extension mechanism Sebastian Andrzej Siewior
2025-10-29 15:40 ` Steven Rostedt
2025-10-29 21:49 ` Thomas Gleixner
2025-11-06 17:28 ` Prakash Sangappa
2025-11-10 14:23 ` Mathieu Desnoyers
2025-11-10 17:05 ` Mathieu Desnoyers
2025-11-11 16:42 ` Mathieu Desnoyers
2025-11-12 6:30 ` Prakash Sangappa
2025-11-12 20:40 ` Mathieu Desnoyers
2025-11-12 21:57 ` Thomas Gleixner
2025-11-12 23:17 ` Prakash Sangappa
2025-11-13 2:34 ` Prakash Sangappa
2025-11-13 14:38 ` Thomas Gleixner
2025-11-12 20:31 ` Thomas Gleixner
2025-11-12 20:46 ` Mathieu Desnoyers
2025-11-12 21:54 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029160859.22bb6eed@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=kprateek.nayak@amd.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=prakash.sangappa@oracle.com \
--cc=tglx@linutronix.de \
--cc=vineethr@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®