From: Andrew Morton <akpm@linux-foundation.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: "Liam R . Howlett" <Liam.Howlett@oracle.com>,
maple-tree@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] maple_tree: fix tracepoint string pointers
Date: Thu, 30 Oct 2025 19:32:06 -0700 [thread overview]
Message-ID: <20251030193206.22bb773e697b6cc385d5aa67@linux-foundation.org> (raw)
In-Reply-To: <20251030155537.87972-1-martin@kaiser.cx>
On Thu, 30 Oct 2025 16:55:05 +0100 Martin Kaiser <martin@kaiser.cx> wrote:
> maple_tree tracepoints contain pointers to function names. Such a pointer
> is saved when a tracepoint logs an event. There's no guarantee that it's
> still valid when the event is parsed later and the pointer is dereferenced.
Oh.
> The kernel warns about these unsafe pointers.
>
> event 'ma_read' has unsafe pointer field 'fn'
> WARNING: kernel/trace/trace.c:3779 at ignore_event+0x1da/0x1e4
>
> Mark the function names as tracepoint_string() to fix the events.
>
> ...
>
> - trace_ma_op(__func__, mas);
> + trace_ma_op(TP_FCT, mas);
>
What could cause the storage for __func__ to disappear as you suggest?
next prev parent reply other threads:[~2025-10-31 2:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 15:55 Martin Kaiser
2025-10-31 2:32 ` Andrew Morton [this message]
2025-10-31 10:22 ` Martin Kaiser
2025-10-31 13:08 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030193206.22bb773e697b6cc385d5aa67@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=martin@kaiser.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®