From: Martin Kaiser <martin@kaiser.cx>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Liam R . Howlett" <Liam.Howlett@oracle.com>,
maple-tree@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] maple_tree: fix tracepoint string pointers
Date: Fri, 31 Oct 2025 11:22:58 +0100 [thread overview]
Message-ID: <aQSOAkBbFkBfYxPs@akranes.kaiser.cx> (raw)
In-Reply-To: <20251030193206.22bb773e697b6cc385d5aa67@linux-foundation.org>
Thus wrote Andrew Morton (akpm@linux-foundation.org):
> > - trace_ma_op(__func__, mas);
> > + trace_ma_op(TP_FCT, mas);
> What could cause the storage for __func__ to disappear as you suggest?
I see your point. For __func__, the compiler generates a local symbol in
.rodata that should always be accessible by its address.
One case that doesn't work without my patch would be trace-cmd record to save
the binary ringbuffer and trace-cmd report to parse it in userspace. The
address of __func__ can't be dereferenced from userspace but tracepoint_string
will add an entry to /sys/kernel/tracing/printk_formats
Best regards,
Martin
next prev parent reply other threads:[~2025-10-31 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 15:55 Martin Kaiser
2025-10-31 2:32 ` Andrew Morton
2025-10-31 10:22 ` Martin Kaiser [this message]
2025-10-31 13:08 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQSOAkBbFkBfYxPs@akranes.kaiser.cx \
--to=martin@kaiser.cx \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®