[PATCH v2 0/2] arm64: acpi: Drop default console log message when using SPCR

[PATCH v2 0/2] arm64: acpi: Drop default console log message when using SPCR

[Punit Agrawal]

From: Punit Agrawal <punita@qti.qualcomm.com>

Hi,

Based on feedback, I've updated the original patch[0] to instead drop
the default console message when using SPCR.

The first patch reverts the incorrect assumption about the return
values of acpi_parse_spcr(). The second drops the logging.

Thanks,
Punit

[0] https://lore.kernel.org/all/20251027141941.3089914-1-punit.agrawal@oss.qualcomm.com/

Punit Agrawal (2):
  Revert "ACPI: Suppress misleading SPCR console message when SPCR table
    is absent"
  arm64: acpi: Drop message logging SPCR default console

 arch/arm64/kernel/acpi.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

-- 
2.34.1

[PATCH v2 1/2] Revert "ACPI: Suppress misleading SPCR console message when SPCR table is absent"

[Punit Agrawal]

This reverts commit bad3fa2fb9206f4dcec6ddef094ec2fbf6e8dcb2.

Commit bad3fa2fb920 ("ACPI: Suppress misleading SPCR console message
when SPCR table is absent") mistakenly assumes acpi_parse_spcr()
returning 0 to indicate a failure to parse SPCR. While addressing the
resultant incorrect logging it was deemed that dropping the message is
a better approach as it is not particularly useful.

Roll back the commit introducing the bug as a step towards dropping
the log message.

Link: https://lore.kernel.org/all/aQN0YWUYaPYWpgJM@willie-the-truck/
Signed-off-by: Punit Agrawal <punit.agrawal@oss.qualcomm.com>
---
 arch/arm64/kernel/acpi.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c
index 7aca29e1d30b..fd164e8a35b2 100644
--- a/arch/arm64/kernel/acpi.c
+++ b/arch/arm64/kernel/acpi.c
@@ -197,8 +197,6 @@ static int __init acpi_fadt_sanity_check(void)
  */
 void __init acpi_boot_table_init(void)
 {
-	int ret;
-
 	/*
 	 * Enable ACPI instead of device tree unless
 	 * - ACPI has been disabled explicitly (acpi=off), or
@@ -252,12 +250,10 @@ void __init acpi_boot_table_init(void)
 		 * behaviour, use acpi=nospcr to disable console in ACPI SPCR
 		 * table as default serial console.
 		 */
-		ret = acpi_parse_spcr(earlycon_acpi_spcr_enable,
+		acpi_parse_spcr(earlycon_acpi_spcr_enable,
 			!param_acpi_nospcr);
-		if (!ret || param_acpi_nospcr || !IS_ENABLED(CONFIG_ACPI_SPCR_TABLE))
-			pr_info("Use ACPI SPCR as default console: No\n");
-		else
-			pr_info("Use ACPI SPCR as default console: Yes\n");
+		pr_info("Use ACPI SPCR as default console: %s\n",
+				param_acpi_nospcr ? "No" : "Yes");
 
 		if (IS_ENABLED(CONFIG_ACPI_BGRT))
 			acpi_table_parse(ACPI_SIG_BGRT, acpi_parse_bgrt);
-- 
2.34.1

[PATCH v2 2/2] arm64: acpi: Drop message logging SPCR default console

[Punit Agrawal]

Commit f5a4af3c7527 ("ACPI: Add acpi=nospcr to disable ACPI SPCR as
default console on ARM64") introduced a command line parameter to
prevent using SPCR provided console as default. It also introduced a
message to log this choice.

Drop the message as it is not particularly useful and can be incorrect
in situations where no SPCR is provided by the firmware.

Link: https://lore.kernel.org/all/aQN0YWUYaPYWpgJM@willie-the-truck/
Signed-off-by: Punit Agrawal <punit.agrawal@oss.qualcomm.com>
---
 arch/arm64/kernel/acpi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c
index fd164e8a35b2..c022c1acb8c7 100644
--- a/arch/arm64/kernel/acpi.c
+++ b/arch/arm64/kernel/acpi.c
@@ -252,8 +252,6 @@ void __init acpi_boot_table_init(void)
 		 */
 		acpi_parse_spcr(earlycon_acpi_spcr_enable,
 			!param_acpi_nospcr);
-		pr_info("Use ACPI SPCR as default console: %s\n",
-				param_acpi_nospcr ? "No" : "Yes");
 
 		if (IS_ENABLED(CONFIG_ACPI_BGRT))
 			acpi_table_parse(ACPI_SIG_BGRT, acpi_parse_bgrt);
-- 
2.34.1

Re: [PATCH v2 0/2] arm64: acpi: Drop default console log message when using SPCR

[Will Deacon]

On Fri, 31 Oct 2025 11:11:36 +0000, Punit Agrawal wrote:
> Based on feedback, I've updated the original patch[0] to instead drop
> the default console message when using SPCR.
> 
> The first patch reverts the incorrect assumption about the return
> values of acpi_parse_spcr(). The second drops the logging.
> 
> Thanks,
> Punit
> 
> [...]

Applied to arm64 (for-next/fixes), thanks!

[1/2] Revert "ACPI: Suppress misleading SPCR console message when SPCR table is absent"
      https://git.kernel.org/arm64/c/eeb8c1989695
[2/2] arm64: acpi: Drop message logging SPCR default console
      https://git.kernel.org/arm64/c/7991fda619f7

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev