* [PATCH] PCI: endpoint: replace use of system_wq with system_percpu_wq
@ 2025-11-05 15:16 Marco Crivellari
2025-12-24 15:02 ` Marco Crivellari
0 siblings, 1 reply; 2+ messages in thread
From: Marco Crivellari @ 2025-11-05 15:16 UTC (permalink / raw)
To: linux-kernel, linux-pci
Cc: Tejun Heo, Lai Jiangshan, Frederic Weisbecker,
Sebastian Andrzej Siewior, Marco Crivellari, Michal Hocko,
Manivannan Sadhasivam, Krzysztof Wilczynski, Bjorn Helgaas,
Kishon Vijay Abraham I
Currently if a user enqueues a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.
This lack of consistency cannot be addressed without refactoring the API.
This patch continues the effort to refactor worqueue APIs, which has begun
with the change introducing new workqueues and a new alloc_workqueue flag:
commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
Replace system_wq with system_percpu_wq, keeping the same behavior.
The old wq (system_wq) will be kept for a few release cycles.
Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
---
drivers/pci/endpoint/pci-ep-cfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c
index ef50c82e647f..c787ce59d9de 100644
--- a/drivers/pci/endpoint/pci-ep-cfs.c
+++ b/drivers/pci/endpoint/pci-ep-cfs.c
@@ -638,7 +638,7 @@ static struct config_group *pci_epf_make(struct config_group *group,
kfree(epf_name);
INIT_DELAYED_WORK(&epf_group->cfs_work, pci_epf_cfs_work);
- queue_delayed_work(system_wq, &epf_group->cfs_work,
+ queue_delayed_work(system_percpu_wq, &epf_group->cfs_work,
msecs_to_jiffies(1));
return &epf_group->group;
--
2.51.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] PCI: endpoint: replace use of system_wq with system_percpu_wq
2025-11-05 15:16 [PATCH] PCI: endpoint: replace use of system_wq with system_percpu_wq Marco Crivellari
@ 2025-12-24 15:02 ` Marco Crivellari
0 siblings, 0 replies; 2+ messages in thread
From: Marco Crivellari @ 2025-12-24 15:02 UTC (permalink / raw)
To: linux-kernel, linux-pci
Cc: Tejun Heo, Lai Jiangshan, Frederic Weisbecker,
Sebastian Andrzej Siewior, Michal Hocko, Manivannan Sadhasivam,
Krzysztof Wilczynski, Bjorn Helgaas, Kishon Vijay Abraham I
On Wed, Nov 5, 2025 at 4:16 PM Marco Crivellari
<marco.crivellari@suse.com> wrote:
> [...]
> drivers/pci/endpoint/pci-ep-cfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Gentle ping.
Many thanks!
--
Marco Crivellari
L3 Support Engineer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-24 15:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-05 15:16 [PATCH] PCI: endpoint: replace use of system_wq with system_percpu_wq Marco Crivellari
2025-12-24 15:02 ` Marco Crivellari
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®