[PATCH] ublk: return unsigned from ublk_{,un}map_io()

[PATCH] ublk: return unsigned from ublk_{,un}map_io()

[Caleb Sander Mateos]

ublk_map_io() and ublk_unmap_io() never return negative values, and
their return values are stored in variables of type unsigned. Clarify
that they can't fail by making their return types unsigned.

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
---
 drivers/block/ublk_drv.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 5cf288809226..5777586e4be3 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -961,12 +961,13 @@ static inline bool ublk_need_unmap_req(const struct request *req)
 {
 	return ublk_rq_has_data(req) &&
 	       (req_op(req) == REQ_OP_READ || req_op(req) == REQ_OP_DRV_IN);
 }
 
-static int ublk_map_io(const struct ublk_queue *ubq, const struct request *req,
-		       const struct ublk_io *io)
+static unsigned int ublk_map_io(const struct ublk_queue *ubq,
+				const struct request *req,
+				const struct ublk_io *io)
 {
 	const unsigned int rq_bytes = blk_rq_bytes(req);
 
 	if (!ublk_need_map_io(ubq))
 		return rq_bytes;
@@ -984,11 +985,11 @@ static int ublk_map_io(const struct ublk_queue *ubq, const struct request *req,
 		return ublk_copy_user_pages(req, 0, &iter, dir);
 	}
 	return rq_bytes;
 }
 
-static int ublk_unmap_io(bool need_map,
+static unsigned int ublk_unmap_io(bool need_map,
 		const struct request *req,
 		const struct ublk_io *io)
 {
 	const unsigned int rq_bytes = blk_rq_bytes(req);
 
-- 
2.45.2

Re: [PATCH] ublk: return unsigned from ublk_{,un}map_io()

[Ming Lei]

On Sat, Nov 8, 2025 at 12:23 PM Caleb Sander Mateos
<csander@purestorage.com> wrote:
>
> ublk_map_io() and ublk_unmap_io() never return negative values, and
> their return values are stored in variables of type unsigned. Clarify
> that they can't fail by making their return types unsigned.
>
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Re: [PATCH] ublk: return unsigned from ublk_{,un}map_io()

[Jens Axboe]

On Fri, 07 Nov 2025 21:23:16 -0700, Caleb Sander Mateos wrote:
> ublk_map_io() and ublk_unmap_io() never return negative values, and
> their return values are stored in variables of type unsigned. Clarify
> that they can't fail by making their return types unsigned.
> 
> 

Applied, thanks!

[1/1] ublk: return unsigned from ublk_{,un}map_io()
      commit: 727a44027815aea13d34c28254d386562efc3bab

Best regards,
-- 
Jens Axboe