mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v1 2/2] dt-bindings: media: i2c: et8ek8: document missing crc as optional property
@ 2025-11-08 23:32 Alex Tran
  2025-11-09 17:18 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Tran @ 2025-11-08 23:32 UTC (permalink / raw)
  To: Rob Herring
  Cc: Mauro Carvalho Chehab, Krzysztof Kozlowski, Conor Dooley,
	Bryan O'Donoghue, Konrad Dybcio, Hans Verkuil, linux-media,
	devicetree, linux-kernel, Alex Tran

Add the optional crc property to the endpoint node for the et8ek8 sensor.
This property enables CRC checksums for the sensor bus and was added to
match the new driver support for reading it from the device tree.

Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
---
 .../devicetree/bindings/media/i2c/toshiba,et8ek8.txt        | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
index 8d8e40c56..5fd30f59b 100644
--- a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
+++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
@@ -30,6 +30,12 @@ Endpoint node mandatory properties
 - remote-endpoint: A phandle to the bus receiver's endpoint node.
 
 
+Endpoint node optional properties
+---------------------------------
+
+- crc: Enable CRC checksums.
+
+
 Example
 -------
 
-- 
2.51.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 2/2] dt-bindings: media: i2c: et8ek8: document missing crc as optional property
  2025-11-08 23:32 [PATCH v1 2/2] dt-bindings: media: i2c: et8ek8: document missing crc as optional property Alex Tran
@ 2025-11-09 17:18 ` Krzysztof Kozlowski
  2025-11-15  0:57   ` Alex Tran
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-09 17:18 UTC (permalink / raw)
  To: Alex Tran
  Cc: Rob Herring, Mauro Carvalho Chehab, Krzysztof Kozlowski,
	Conor Dooley, Bryan O'Donoghue, Konrad Dybcio, Hans Verkuil,
	linux-media, devicetree, linux-kernel

On Sat, Nov 08, 2025 at 03:32:00PM -0800, Alex Tran wrote:
> Add the optional crc property to the endpoint node for the et8ek8 sensor.
> This property enables CRC checksums for the sensor bus and was added to
> match the new driver support for reading it from the device tree.

We do not add bindings because you want this in the driver. Please
describe the hardware.

> 
> Signed-off-by: Alex Tran <alex.t.tran@gmail.com>

Your patchser has broken threading. There is no patch #1.

> ---
>  .../devicetree/bindings/media/i2c/toshiba,et8ek8.txt        | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> index 8d8e40c56..5fd30f59b 100644
> --- a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> @@ -30,6 +30,12 @@ Endpoint node mandatory properties
>  - remote-endpoint: A phandle to the bus receiver's endpoint node.
>  
>  
> +Endpoint node optional properties
> +---------------------------------
> +
> +- crc: Enable CRC checksums.

Looks like SW property, so not really suitable for bindings.

Also, no changes to TXT bindings are accepted, so first this would have
to be converted to DT schema.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 2/2] dt-bindings: media: i2c: et8ek8: document missing crc as optional property
  2025-11-09 17:18 ` Krzysztof Kozlowski
@ 2025-11-15  0:57   ` Alex Tran
  0 siblings, 0 replies; 3+ messages in thread
From: Alex Tran @ 2025-11-15  0:57 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Mauro Carvalho Chehab, Krzysztof Kozlowski,
	Conor Dooley, Bryan O'Donoghue, Konrad Dybcio, Hans Verkuil,
	linux-media, devicetree, linux-kernel

On Sun, Nov 9, 2025 at 9:18 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Sat, Nov 08, 2025 at 03:32:00PM -0800, Alex Tran wrote:
> > Add the optional crc property to the endpoint node for the et8ek8 sensor.
> > This property enables CRC checksums for the sensor bus and was added to
> > match the new driver support for reading it from the device tree.
>
> We do not add bindings because you want this in the driver. Please
> describe the hardware.
>
> >
> > Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
>
> Your patchser has broken threading. There is no patch #1.
>
> > ---
> >  .../devicetree/bindings/media/i2c/toshiba,et8ek8.txt        | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> > index 8d8e40c56..5fd30f59b 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> > @@ -30,6 +30,12 @@ Endpoint node mandatory properties
> >  - remote-endpoint: A phandle to the bus receiver's endpoint node.
> >
> >
> > +Endpoint node optional properties
> > +---------------------------------
> > +
> > +- crc: Enable CRC checksums.
>
> Looks like SW property, so not really suitable for bindings.
>
> Also, no changes to TXT bindings are accepted, so first this would have
> to be converted to DT schema.
>
> Best regards,
> Krzysztof
>
Thanks for the review. The et8ek8 sensor has hardware support for CRC
checksums on CCP2.
However, the receiver must also support CRC for this to work.
Whether CRC should be enabled depends on the specific board design and receiver.
Regarding the conversion to a DT schema, I'll follow up with a patch
series v2 that fixes the broken threading and converts the binding to
a YAML format.

Best,
--
Alex Tran

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-15  0:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-08 23:32 [PATCH v1 2/2] dt-bindings: media: i2c: et8ek8: document missing crc as optional property Alex Tran
2025-11-09 17:18 ` Krzysztof Kozlowski
2025-11-15  0:57   ` Alex Tran

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®