mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] rtc: Fix error handling in devm_rtc_allocate_device
@ 2025-11-09  6:08 Ma Ke
  2025-11-09  8:59 ` Christophe JAILLET
  0 siblings, 1 reply; 2+ messages in thread
From: Ma Ke @ 2025-11-09  6:08 UTC (permalink / raw)
  To: alexandre.belloni; +Cc: linux-rtc, linux-kernel, akpm, Ma Ke, stable

In rtc_allocate_device(), device_initialize() sets the reference count
to 1. In rtc_allocate_device(), when devm_add_action_or_reset() or
dev_set_name() fails after successful device initialization via
device_initialize(), rtc_allocate_device() returns an error without
properly calling put_device() and releasing the reference count.

Add proper error handling that calls put_device() in all error paths
after device_initialize(), ensuring proper resource cleanup.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: 3068a254d551 ("rtc: introduce new registration method")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
 drivers/rtc/class.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c
index b1a2be1f9e3b..db5f33a22b14 100644
--- a/drivers/rtc/class.c
+++ b/drivers/rtc/class.c
@@ -379,13 +379,17 @@ struct rtc_device *devm_rtc_allocate_device(struct device *dev)
 	rtc->dev.parent = dev;
 	err = devm_add_action_or_reset(dev, devm_rtc_release_device, rtc);
 	if (err)
-		return ERR_PTR(err);
+		goto err_put_device;
 
 	err = dev_set_name(&rtc->dev, "rtc%d", id);
 	if (err)
-		return ERR_PTR(err);
+		goto err_put_device;
 
 	return rtc;
+
+err_put_device:
+	put_device(&rtc->dev);
+	return ERR_PTR(err);
 }
 EXPORT_SYMBOL_GPL(devm_rtc_allocate_device);
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-09  8:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-09  6:08 [PATCH] rtc: Fix error handling in devm_rtc_allocate_device Ma Ke
2025-11-09  8:59 ` Christophe JAILLET

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®