mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: gert.wollny@collabora.com
To: Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>,
	Russell King <linux+etnaviv@armlinux.org.uk>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	Gert Wollny <gert.wollny@collabora.com>
Subject: [PATCH v4 5/5] drm/etnaviv: Add module parameter to force PPU flop reset
Date: Mon, 10 Nov 2025 15:37:51 +0100	[thread overview]
Message-ID: <20251110144625.18653-6-gert.wollny@collabora.com> (raw)
In-Reply-To: <20251110144625.18653-1-gert.wollny@collabora.com>

From: Gert Wollny <gert.wollny@collabora.com>

v2: Check for feature PIPE_3D when forcing PPU flop reset (Lucas)

v3: - drop use of ppu_flop_reset enum (Christian Gmeiner)
    - don't initialize module parameter to zero (checkpatch)
    - avoid multi-line string in warning message (checkpatch)

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
---
 drivers/gpu/drm/etnaviv/etnaviv_flop_reset.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_flop_reset.c b/drivers/gpu/drm/etnaviv/etnaviv_flop_reset.c
index 7c0112b3b3ad..75fe8cce1177 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_flop_reset.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_flop_reset.c
@@ -13,6 +13,9 @@
 
 #include "etnaviv_flop_reset.h"
 
+static int etnaviv_force_flop_reset;
+module_param_named(force_flop_reset, etnaviv_force_flop_reset, int, 0);
+
 #define PPU_IMAGE_STRIDE 64
 #define PPU_IMAGE_XSIZE 64
 #define PPU_IMAGE_YSIZE 6
@@ -148,6 +151,19 @@ bool etnaviv_flop_reset_ppu_require(const struct etnaviv_chip_identity *chip_id)
 			return true;
 	}
 
+	if (etnaviv_force_flop_reset) {
+		if (!(chip_id->features & chipFeatures_PIPE_3D)) {
+			pr_warn("Etnaviv: model: 0x%04x, revision: 0x%04x does not support PIPE_3D\n",
+				chip_id->model, chip_id->revision);
+			pr_warn("Request to force PPU flop reset ignored.\n");
+			return false;
+		}
+
+		pr_info("Force PPU flop reset for model: 0x%04x, revision: 0x%04x\n",
+			chip_id->model, chip_id->revision);
+		return true;
+	}
+
 	return false;
 }
 
-- 
2.51.0


  parent reply	other threads:[~2025-11-10 14:43 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-18 20:43 drm/etnaviv: Add support for running a " Gert Wollny
2025-06-18 20:43 ` [PATCH v2 1/6] drm/etnaviv: Add command stream definitions required for " Gert Wollny
2025-06-18 20:43 ` [PATCH v2 2/6] drm/etnaviv: move some functions to a header to be able to use them externally Gert Wollny
2025-06-18 20:43 ` [PATCH v2 3/6] drm/etnaviv: Add a new function to emit a series of states to cmd stream Gert Wollny
2025-06-18 20:43 ` [PATCH v2 4/6] drm/etnaviv: Identify GPU already when binding Gert Wollny
2025-06-20 20:11   ` Lucas Stach
2025-06-18 20:43 ` [PATCH v2 5/6] drm/etnaviv: Add PPU flop reset Gert Wollny
2025-06-20 20:22   ` Lucas Stach
2025-06-23 12:05     ` Gert Wollny
2025-06-23 12:25       ` Lucas Stach
2025-06-18 20:43 ` [PATCH v2 6/6] drm/etnaviv: Add module parameter to force " Gert Wollny
2025-06-20 20:24   ` Lucas Stach
2025-06-30 20:26 ` [PATCH v3 0/5] drm/etnaviv: Add support for running a " Gert Wollny
2025-06-30 20:26   ` [PATCH v3 1/5] drm/etnaviv: Add command stream definitions required for " Gert Wollny
2025-06-30 20:26   ` [PATCH v3 2/5] drm/etnaviv: move some functions to a header to be able to use them externally Gert Wollny
2025-06-30 20:26   ` [PATCH v3 3/5] drm/etnaviv: Add a new function to emit a series of states to cmd stream Gert Wollny
2025-06-30 20:26   ` [PATCH v3 4/5] drm/etnaviv: Add PPU flop reset Gert Wollny
2025-10-09 21:40     ` Christian Gmeiner
2025-06-30 20:26   ` [PATCH v3 5/5] drm/etnaviv: Add module parameter to force " Gert Wollny
2025-11-10 14:37   ` [PATCH v4 0/5] drm/etnaviv: Add support for running a " gert.wollny
2025-11-10 14:37     ` [PATCH v4 1/5] drm/etnaviv: Add command stream definitions required for " gert.wollny
2025-11-10 15:54       ` Christian Gmeiner
2025-11-10 14:37     ` [PATCH v4 2/5] drm/etnaviv: move some functions to a header to be able to use them externally gert.wollny
2025-11-10 15:53       ` Christian Gmeiner
2025-11-10 14:37     ` [PATCH v4 3/5] drm/etnaviv: Add a new function to emit a series of states to cmd stream gert.wollny
2025-11-17  8:27       ` Christian Gmeiner
2025-11-10 14:37     ` [PATCH v4 4/5] drm/etnaviv: Add PPU flop reset gert.wollny
2025-11-17  8:57       ` Christian Gmeiner
2025-11-10 14:37     ` gert.wollny [this message]
2025-11-19 15:30       ` [PATCH v4 5/5] drm/etnaviv: Add module parameter to force " Christian Gmeiner
2025-11-19 16:45     ` [PATCH v5 0/5] drm/etnaviv: Add support for running a " gert.wollny
2025-11-19 16:45       ` [PATCH v5 1/5] drm/etnaviv: Add command stream definitions required for " gert.wollny
2025-11-19 16:45       ` [PATCH v5 2/5] drm/etnaviv: move some functions to a header to be able to use them externally gert.wollny
2025-11-28  8:56         ` Christian Gmeiner
2025-11-28 13:39           ` Gert Wollny
2025-11-19 16:45       ` [PATCH v5 3/5] drm/etnaviv: Add a new function to emit a series of states to cmd stream gert.wollny
2025-11-19 16:45       ` [PATCH v5 4/5] drm/etnaviv: Add PPU flop reset gert.wollny
2025-11-28  8:53         ` Christian Gmeiner
2025-11-19 16:45       ` [PATCH v5 5/5] drm/etnaviv: Add module parameter to force " gert.wollny
2025-11-21 20:47       ` [PATCH v5 0/5] drm/etnaviv: Add support for running a " Marek Vasut
2026-01-06 15:48         ` Christian Gmeiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251110144625.18653-6-gert.wollny@collabora.com \
    --to=gert.wollny@collabora.com \
    --cc=airlied@gmail.com \
    --cc=christian.gmeiner@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=etnaviv@lists.freedesktop.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux+etnaviv@armlinux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®