* [PATCH RESEND] x86/asm: Use inout "+" asm onstraint modifiers in __iowrite32_copy()
@ 2025-11-10 22:31 Uros Bizjak
2026-01-20 20:51 ` H. Peter Anvin
0 siblings, 1 reply; 3+ messages in thread
From: Uros Bizjak @ 2025-11-10 22:31 UTC (permalink / raw)
To: x86, linux-kernel
Cc: Uros Bizjak, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, H. Peter Anvin
Use inout "+" asm constraint modifiers to simplify asm operands.
No functional changes intended.
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
---
arch/x86/include/asm/io.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
index ca309a3227c7..2ea25745e059 100644
--- a/arch/x86/include/asm/io.h
+++ b/arch/x86/include/asm/io.h
@@ -218,9 +218,8 @@ static inline void __iowrite32_copy(void __iomem *to, const void *from,
size_t count)
{
asm volatile("rep movsl"
- : "=&c"(count), "=&D"(to), "=&S"(from)
- : "0"(count), "1"(to), "2"(from)
- : "memory");
+ : "+D"(to), "+S"(from), "+c"(count)
+ : : "memory");
}
#define __iowrite32_copy __iowrite32_copy
#endif
--
2.51.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] x86/asm: Use inout "+" asm onstraint modifiers in __iowrite32_copy()
2025-11-10 22:31 [PATCH RESEND] x86/asm: Use inout "+" asm onstraint modifiers in __iowrite32_copy() Uros Bizjak
@ 2026-01-20 20:51 ` H. Peter Anvin
0 siblings, 0 replies; 3+ messages in thread
From: H. Peter Anvin @ 2026-01-20 20:51 UTC (permalink / raw)
To: Uros Bizjak, x86, linux-kernel
Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen
On 2025-11-10 14:31, Uros Bizjak wrote:
> Use inout "+" asm constraint modifiers to simplify asm operands.
>
> No functional changes intended.
>
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> ---
> arch/x86/include/asm/io.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Looks good to me.
Reviewed-by: H. Peter Anvin (Intel) <hpa@zytor.com>
> diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
> index ca309a3227c7..2ea25745e059 100644
> --- a/arch/x86/include/asm/io.h
> +++ b/arch/x86/include/asm/io.h
> @@ -218,9 +218,8 @@ static inline void __iowrite32_copy(void __iomem *to, const void *from,
> size_t count)
> {
> asm volatile("rep movsl"
> - : "=&c"(count), "=&D"(to), "=&S"(from)
> - : "0"(count), "1"(to), "2"(from)
> - : "memory");
> + : "+D"(to), "+S"(from), "+c"(count)
> + : : "memory");
> }
> #define __iowrite32_copy __iowrite32_copy
> #endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH RESEND] x86/asm: Use inout "+" asm onstraint modifiers in __iowrite32_copy()
@ 2025-12-16 10:51 Uros Bizjak
0 siblings, 0 replies; 3+ messages in thread
From: Uros Bizjak @ 2025-12-16 10:51 UTC (permalink / raw)
To: x86, linux-kernel
Cc: Uros Bizjak, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, H. Peter Anvin
Use inout "+" asm constraint modifiers to simplify asm operands.
No functional changes intended.
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
---
arch/x86/include/asm/io.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
index ca309a3227c7..2ea25745e059 100644
--- a/arch/x86/include/asm/io.h
+++ b/arch/x86/include/asm/io.h
@@ -218,9 +218,8 @@ static inline void __iowrite32_copy(void __iomem *to, const void *from,
size_t count)
{
asm volatile("rep movsl"
- : "=&c"(count), "=&D"(to), "=&S"(from)
- : "0"(count), "1"(to), "2"(from)
- : "memory");
+ : "+D"(to), "+S"(from), "+c"(count)
+ : : "memory");
}
#define __iowrite32_copy __iowrite32_copy
#endif
--
2.52.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-20 20:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-10 22:31 [PATCH RESEND] x86/asm: Use inout "+" asm onstraint modifiers in __iowrite32_copy() Uros Bizjak
2026-01-20 20:51 ` H. Peter Anvin
2025-12-16 10:51 Uros Bizjak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®