[RESEND PATCH 1/1] w1: omap-hdq: Remove redundant pm_runtime_mark_last_busy() calls

[RESEND PATCH 1/1] w1: omap-hdq: Remove redundant pm_runtime_mark_last_busy() calls

[Sakari Ailus]

pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
pm_runtime_mark_last_busy().

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/w1/masters/omap_hdq.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
index 69b1d145657a..d13db3396570 100644
--- a/drivers/w1/masters/omap_hdq.c
+++ b/drivers/w1/masters/omap_hdq.c
@@ -445,7 +445,6 @@ static u8 omap_w1_triplet(void *_hdq, u8 bdir)
 out:
 	mutex_unlock(&hdq_data->hdq_mutex);
 rtn:
-	pm_runtime_mark_last_busy(hdq_data->dev);
 	pm_runtime_put_autosuspend(hdq_data->dev);
 
 	return ret;
@@ -466,7 +465,6 @@ static u8 omap_w1_reset_bus(void *_hdq)
 
 	omap_hdq_break(hdq_data);
 
-	pm_runtime_mark_last_busy(hdq_data->dev);
 	pm_runtime_put_autosuspend(hdq_data->dev);
 
 	return 0;
@@ -490,7 +488,6 @@ static u8 omap_w1_read_byte(void *_hdq)
 	if (ret)
 		val = -1;
 
-	pm_runtime_mark_last_busy(hdq_data->dev);
 	pm_runtime_put_autosuspend(hdq_data->dev);
 
 	return val;
@@ -525,7 +522,6 @@ static void omap_w1_write_byte(void *_hdq, u8 byte)
 	}
 
 out_err:
-	pm_runtime_mark_last_busy(hdq_data->dev);
 	pm_runtime_put_autosuspend(hdq_data->dev);
 }
 
@@ -625,7 +621,6 @@ static int omap_hdq_probe(struct platform_device *pdev)
 
 	omap_hdq_break(hdq_data);
 
-	pm_runtime_mark_last_busy(&pdev->dev);
 	pm_runtime_put_autosuspend(&pdev->dev);
 
 	omap_w1_master.data = hdq_data;
-- 
2.47.3

Re: [RESEND PATCH 1/1] w1: omap-hdq: Remove redundant pm_runtime_mark_last_busy() calls

[Krzysztof Kozlowski]

On 11/11/2025 10:43, Sakari Ailus wrote:
> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call

No, it doesn't, I don't see it. Are you sure you are basing patches on
the maintainer trees?

> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().
> 
Best regards,
Krzysztof

Re: [RESEND PATCH 1/1] w1: omap-hdq: Remove redundant pm_runtime_mark_last_busy() calls

[Krzysztof Kozlowski]

On 11/11/2025 10:53, Krzysztof Kozlowski wrote:
> On 11/11/2025 10:43, Sakari Ailus wrote:
>> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
>> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
> 
> No, it doesn't, I don't see it. Are you sure you are basing patches on
> the maintainer trees?


Bah, it does. Look at earlier __pm_runtime_put_autosuspend() when
searching. Looks fine.

Best regards,
Krzysztof

Re: [RESEND PATCH 1/1] w1: omap-hdq: Remove redundant pm_runtime_mark_last_busy() calls

[Krzysztof Kozlowski]

On Tue, 11 Nov 2025 11:43:02 +0200, Sakari Ailus wrote:
> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().
> 
> 

Applied, thanks!

[1/1] w1: omap-hdq: Remove redundant pm_runtime_mark_last_busy() calls
      https://git.kernel.org/krzk/linux-w1/c/a5d908e0ec05bd4f5dd818160f0252861879a5a2

Best regards,
-- 
Krzysztof Kozlowski <krzk@kernel.org>