From: Peter Zijlstra <peterz@infradead.org>
To: Gabriele Monaco <gmonaco@redhat.com>
Cc: Juri Lelli <juri.lelli@redhat.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Clark Williams <williams@redhat.com>,
arighi@nvidia.com
Subject: Re: [RFC PATCH] sched/deadline: Avoid dl_server boosting with expired deadline
Date: Tue, 11 Nov 2025 12:17:16 +0100 [thread overview]
Message-ID: <20251111111716.GL278048@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <b8454329ce061f0c113b25b9400e2b0771fa9e27.camel@redhat.com>
On Tue, Nov 11, 2025 at 10:58:51AM +0100, Gabriele Monaco wrote:
> Is there a reason why dl_server_stop() doesn't reset the running flag?
Yes. Suppose we're boosting a task, and that task has a small sleep
(mutex or whatever). The dl_server won't have anything to actually boost
and will stop itself, clearing running (if dl_server_stop() were to
clear running).
Then if the initial fair task wakes up again, we'll (re)start the
dl_server, but since !running, it will go do the whole defer/zero-laxity
thing again, making out task wait for a whole period until it can run
again.
Conversely (dl_server_stop(), like now, does *not* clear running), if
running is retained, the dl_server is able to immediately resume its
still valid runtime.
Put otherwise, a fair task that always runs and a fair task that has
micro-sleeps should more or less behave the same. We should not punish a
micro-sleep with a whole second delay.
Now, if the sleep is long, we'll find the deadline is in the past and
then it pushes the activation forward and we go ... Oooh to E.
Let me go draw that line in the diagram.
next prev parent reply other threads:[~2025-11-11 11:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 12:29 Gabriele Monaco
2025-10-14 9:30 ` Gabriele Monaco
2025-10-14 9:54 ` Peter Zijlstra
2025-10-14 10:05 ` Gabriele Monaco
2025-10-14 10:25 ` Peter Zijlstra
2025-10-14 15:32 ` Gabriele Monaco
2025-10-14 16:01 ` Juri Lelli
2025-10-14 19:33 ` Peter Zijlstra
2025-10-15 5:40 ` Juri Lelli
2025-10-20 14:11 ` Peter Zijlstra
2025-10-22 10:11 ` Gabriele Monaco
2025-10-30 18:42 ` Peter Zijlstra
2025-10-31 13:05 ` Peter Zijlstra
2025-10-31 13:24 ` Gabriele Monaco
2025-10-31 15:20 ` Peter Zijlstra
2025-10-31 15:41 ` Gabriele Monaco
2025-10-31 15:44 ` Peter Zijlstra
2025-10-31 15:51 ` Gabriele Monaco
2025-11-01 0:00 ` Peter Zijlstra
2025-11-11 9:58 ` Gabriele Monaco
2025-11-11 11:17 ` Peter Zijlstra [this message]
2025-11-11 11:24 ` Peter Zijlstra
2025-11-11 11:37 ` [tip: sched/core] sched/deadline: Fix dl_server stop condition tip-bot2 for Peter Zijlstra
2025-11-01 0:08 ` [RFC PATCH] sched/deadline: Avoid dl_server boosting with expired deadline Peter Zijlstra
2025-11-01 8:43 ` Gabriele Monaco
2025-11-11 11:37 ` [tip: sched/core] sched/deadline: Fix dl_server time accounting tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251111111716.GL278048@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arighi@nvidia.com \
--cc=gmonaco@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®