From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH v1 1/1] iio: imu: inv_icm42600: Convert to uXX and sXX integer types
Date: Sat, 15 Nov 2025 18:48:05 +0000 [thread overview]
Message-ID: <20251115184805.219c0715@jic23-huawei> (raw)
In-Reply-To: <aRDsoY7Ac4i0eGTF@smile.fi.intel.com>
On Sun, 9 Nov 2025 21:33:53 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Sun, Nov 09, 2025 at 08:24:36PM +0100, Andy Shevchenko wrote:
> > The driver code is full of intXX_t and uintXX_t types which is
> > not the pattern we use in the IIO subsystem. Switch the driver
> > to use kernel internal types for that. No functional changes.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >
> > Jonathan, what is the status of fixing the type for
> > iio_push_to_buffers_with_timestamp()? This patch doesn't do that
> > as I see no API has been fixed (and it seems the only one that uses
> > the *intXX_t parameter).
> >
> > drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> FWIW,
That interface is supposed to be going away anyway in favour
of iio_push_to_buffers_with_ts() which doesn't have that issue.
I'd rather an effort was put in that direction than changing
the types as part of that old interface.
Thanks,
Jonathan
>
> $ git grep -l 'u\?int[0-9][0-9]\?_t' -- drivers/iio/
> drivers/iio/accel/bmc150-accel-core.c
> drivers/iio/accel/bmc150-accel.h
> drivers/iio/accel/fxls8962af-core.c
> drivers/iio/accel/hid-sensor-accel-3d.c
> drivers/iio/accel/kionix-kx022a.c
> drivers/iio/accel/kxcjk-1013.c
> drivers/iio/accel/sca3000.c
> drivers/iio/accel/sca3300.c
> drivers/iio/accel/ssp_accel_sensor.c
> drivers/iio/adc/ad4000.c
> drivers/iio/adc/ad7791.c
> drivers/iio/adc/ad7887.c
> drivers/iio/adc/at91_adc.c
> drivers/iio/adc/ingenic-adc.c
> drivers/iio/adc/max1363.c
> drivers/iio/adc/qcom-spmi-rradc.c
> drivers/iio/adc/qcom-vadc-common.c
> drivers/iio/adc/ti-ads7950.c
> drivers/iio/adc/ti-tlc4541.c
> drivers/iio/adc/xilinx-xadc-core.c
> drivers/iio/adc/xilinx-xadc-events.c
> drivers/iio/adc/xilinx-xadc.h
> drivers/iio/chemical/scd4x.c
> drivers/iio/common/cros_ec_sensors/cros_ec_sensors_trace.h
> drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> drivers/iio/common/inv_sensors/inv_sensors_timestamp.c
> drivers/iio/common/ssp_sensors/ssp.h
> drivers/iio/common/ssp_sensors/ssp_iio.c
> drivers/iio/common/ssp_sensors/ssp_iio_sensor.h
> drivers/iio/dac/ad3552r.c
> drivers/iio/dac/ad5446.c
> drivers/iio/dac/ad5449.c
> drivers/iio/dac/ad5766.c
> drivers/iio/dac/ad7303.c
> drivers/iio/dac/ad8460.c
> drivers/iio/dac/ds4424.c
> drivers/iio/dac/ti-dac7612.c
> drivers/iio/frequency/admv4420.c
> drivers/iio/gyro/adis16136.c
> drivers/iio/gyro/ssp_gyro_sensor.c
> drivers/iio/humidity/ens210.c
> drivers/iio/imu/adis16400.c
> drivers/iio/imu/adis16460.c
> drivers/iio/imu/adis16480.c
> drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
> drivers/iio/imu/inv_mpu6050/inv_mpu_aux.c
> drivers/iio/imu/inv_mpu6050/inv_mpu_aux.h
> drivers/iio/imu/inv_mpu6050/inv_mpu_magn.c
> drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
> drivers/iio/industrialio-buffer.c
> drivers/iio/light/ltr501.c
> drivers/iio/light/rohm-bu27034.c
> drivers/iio/light/si1133.c
> drivers/iio/light/stk3310.c
> drivers/iio/light/vcnl4000.c
> drivers/iio/position/hid-sensor-custom-intel-hinge.c
> drivers/iio/pressure/icp10100.c
> drivers/iio/pressure/ms5611_core.c
> drivers/iio/temperature/mlx90632.c
>
next prev parent reply other threads:[~2025-11-15 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-09 19:24 Andy Shevchenko
2025-11-09 19:33 ` Andy Shevchenko
2025-11-15 18:48 ` Jonathan Cameron [this message]
2025-11-15 18:50 ` Jonathan Cameron
2026-02-03 11:21 ` Andy Shevchenko
2026-02-05 19:29 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2025-06-16 9:03 Andy Shevchenko
2025-06-16 14:16 ` Jean-Baptiste Maneyrol
2025-06-16 14:33 ` Andy Shevchenko
2025-06-17 14:43 ` Jean-Baptiste Maneyrol
2025-06-17 18:33 ` Andy Shevchenko
2025-06-21 17:13 ` Jonathan Cameron
2025-06-23 6:39 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251115184805.219c0715@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®