mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	"Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH v1 1/1] iio: imu: inv_icm42600: Convert to uXX and sXX integer types
Date: Sat, 15 Nov 2025 18:50:01 +0000	[thread overview]
Message-ID: <20251115185001.01f2b148@jic23-huawei> (raw)
In-Reply-To: <20251109192556.3163077-1-andriy.shevchenko@linux.intel.com>

On Sun,  9 Nov 2025 20:24:36 +0100
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> The driver code is full of intXX_t and uintXX_t types which is
> not the pattern we use in the IIO subsystem. Switch the driver
> to use kernel internal types for that. No functional changes.
No problem with the change but this description made me think
that this was going to be a huge patch touching lots of instances.

Probably needs a rewrite to not say 'full of' :)
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> 
> Jonathan, what is the status of fixing the type for
> iio_push_to_buffers_with_timestamp()? This patch doesn't do that
> as I see no API has been fixed (and it seems the only one that uses
> the *intXX_t parameter).
> 
>  drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
> index 54760d8f92a2..9be5ade24501 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
> @@ -1209,7 +1209,7 @@ int inv_icm42600_accel_parse_fifo(struct iio_dev *indio_dev)
>  	ssize_t i, size;
>  	unsigned int no;
>  	const void *accel, *gyro, *timestamp;
> -	const int8_t *temp;
> +	const s8 *temp;
>  	unsigned int odr;
>  	int64_t ts_val;
>  	/* buffer is copied to userspace, zeroing it to avoid any data leak */


  parent reply	other threads:[~2025-11-15 18:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-09 19:24 Andy Shevchenko
2025-11-09 19:33 ` Andy Shevchenko
2025-11-15 18:48   ` Jonathan Cameron
2025-11-15 18:50 ` Jonathan Cameron [this message]
2026-02-03 11:21   ` Andy Shevchenko
2026-02-05 19:29     ` Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2025-06-16  9:03 Andy Shevchenko
2025-06-16 14:16 ` Jean-Baptiste Maneyrol
2025-06-16 14:33   ` Andy Shevchenko
2025-06-17 14:43     ` Jean-Baptiste Maneyrol
2025-06-17 18:33       ` Andy Shevchenko
2025-06-21 17:13         ` Jonathan Cameron
2025-06-23  6:39           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251115185001.01f2b148@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jean-baptiste.maneyrol@tdk.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®