mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 0/3] Regulator adjustments for OnePlus 6 and 6T
@ 2025-11-18 14:52 David Heidelberg via B4 Relay
  2025-11-18 14:52 ` [PATCH v2 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on David Heidelberg via B4 Relay
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-11-18 14:52 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Casey Connolly
  Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, David Heidelberg

Small regulators adjustments, tested on sdm845-mainline and sdm845-next
tree with recently fixed (6) and upstreamed (6T) drivers.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
Changes in v2:
- Corrected description of
  "arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on".
  (Konrad)
- Added Fixes tag to the commits. (Konrad)
- Link to v1: https://lore.kernel.org/r/20251118-dts-oneplus-regulators-v1-0-79fb2f0f253b@ixit.cz

---
Casey Connolly (3):
      arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on
      arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on
      arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on

 arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
---
base-commit: 187dac290bfd0741b9d7d5490af825c33fd9baa4
change-id: 20251118-dts-oneplus-regulators-08aaa85fca38

Best regards,
-- 
David Heidelberg <david@ixit.cz>



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on
  2025-11-18 14:52 [PATCH v2 0/3] Regulator adjustments for OnePlus 6 and 6T David Heidelberg via B4 Relay
@ 2025-11-18 14:52 ` David Heidelberg via B4 Relay
  2025-11-18 15:02   ` Konrad Dybcio
  2025-11-18 14:52 ` [PATCH v2 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on David Heidelberg via B4 Relay
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-11-18 14:52 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Casey Connolly
  Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, David Heidelberg

From: Casey Connolly <casey.connolly@linaro.org>

The touchscreen isn't enabled by bootloader and doesn't need to be
enabled at boot, only when the driver probes, thus remove the
regulator-boot-on property.

Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index db6dd04c51bb5..ee62adfa6af0b 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -148,7 +148,6 @@ ts_1p8_supply: ts-1p8-regulator {
 
 		gpio = <&tlmm 88 0>;
 		enable-active-high;
-		regulator-boot-on;
 	};
 
 	panel_vci_3v3: panel-vci-3v3-regulator {

-- 
2.51.0



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on
  2025-11-18 14:52 [PATCH v2 0/3] Regulator adjustments for OnePlus 6 and 6T David Heidelberg via B4 Relay
  2025-11-18 14:52 ` [PATCH v2 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on David Heidelberg via B4 Relay
@ 2025-11-18 14:52 ` David Heidelberg via B4 Relay
  2025-11-18 15:02   ` Konrad Dybcio
  2025-11-18 14:52 ` [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on David Heidelberg via B4 Relay
  2026-01-05 14:07 ` [PATCH v2 0/3] Regulator adjustments for OnePlus 6 and 6T Bjorn Andersson
  3 siblings, 1 reply; 8+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-11-18 14:52 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Casey Connolly
  Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, David Heidelberg

From: Casey Connolly <casey.connolly@linaro.org>

The panel regulator doesn't need to be always on, so remove this
property.

Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index ee62adfa6af0b..5845bc3bb80b2 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -272,7 +272,6 @@ vreg_l14a_1p88: ldo14 {
 			regulator-min-microvolt = <1800000>;
 			regulator-max-microvolt = <1800000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-			regulator-always-on;
 		};
 
 		vreg_l17a_1p3: ldo17 {

-- 
2.51.0



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on
  2025-11-18 14:52 [PATCH v2 0/3] Regulator adjustments for OnePlus 6 and 6T David Heidelberg via B4 Relay
  2025-11-18 14:52 ` [PATCH v2 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on David Heidelberg via B4 Relay
  2025-11-18 14:52 ` [PATCH v2 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on David Heidelberg via B4 Relay
@ 2025-11-18 14:52 ` David Heidelberg via B4 Relay
  2025-11-18 15:02   ` Konrad Dybcio
  2026-01-05 14:07 ` [PATCH v2 0/3] Regulator adjustments for OnePlus 6 and 6T Bjorn Andersson
  3 siblings, 1 reply; 8+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-11-18 14:52 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Casey Connolly
  Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, David Heidelberg

From: Casey Connolly <casey.connolly@linaro.org>

This regulator is used only for the display, which is enabled by the
bootloader and left on for continuous splash. Mark it as such.

Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index 5845bc3bb80b2..8251f5a2f9475 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -272,6 +272,7 @@ vreg_l14a_1p88: ldo14 {
 			regulator-min-microvolt = <1800000>;
 			regulator-max-microvolt = <1800000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-boot-on;
 		};
 
 		vreg_l17a_1p3: ldo17 {

-- 
2.51.0



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on
  2025-11-18 14:52 ` [PATCH v2 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on David Heidelberg via B4 Relay
@ 2025-11-18 15:02   ` Konrad Dybcio
  0 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2025-11-18 15:02 UTC (permalink / raw)
  To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Casey Connolly
  Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel

On 11/18/25 3:52 PM, David Heidelberg via B4 Relay wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
> 
> The touchscreen isn't enabled by bootloader and doesn't need to be
> enabled at boot, only when the driver probes, thus remove the
> regulator-boot-on property.
> 
> Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on
  2025-11-18 14:52 ` [PATCH v2 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on David Heidelberg via B4 Relay
@ 2025-11-18 15:02   ` Konrad Dybcio
  0 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2025-11-18 15:02 UTC (permalink / raw)
  To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Casey Connolly
  Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel

On 11/18/25 3:52 PM, David Heidelberg via B4 Relay wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
> 
> The panel regulator doesn't need to be always on, so remove this
> property.
> 
> Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on
  2025-11-18 14:52 ` [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on David Heidelberg via B4 Relay
@ 2025-11-18 15:02   ` Konrad Dybcio
  0 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2025-11-18 15:02 UTC (permalink / raw)
  To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Casey Connolly
  Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel

On 11/18/25 3:52 PM, David Heidelberg via B4 Relay wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
> 
> This regulator is used only for the display, which is enabled by the
> bootloader and left on for continuous splash. Mark it as such.
> 
> Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 0/3] Regulator adjustments for OnePlus 6 and 6T
  2025-11-18 14:52 [PATCH v2 0/3] Regulator adjustments for OnePlus 6 and 6T David Heidelberg via B4 Relay
                   ` (2 preceding siblings ...)
  2025-11-18 14:52 ` [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on David Heidelberg via B4 Relay
@ 2026-01-05 14:07 ` Bjorn Andersson
  3 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2026-01-05 14:07 UTC (permalink / raw)
  To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Casey Connolly, David Heidelberg
  Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel


On Tue, 18 Nov 2025 15:52:24 +0100, David Heidelberg wrote:
> Small regulators adjustments, tested on sdm845-mainline and sdm845-next
> tree with recently fixed (6) and upstreamed (6T) drivers.
> 
> 

Applied, thanks!

[1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on
      commit: c9b98b9dad9749bf2eb7336a6fca31a6af1039d7
[2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on
      commit: 45d1f42d3e84b5880cf9fab1eb24a7818320eeb7
[3/3] arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on
      commit: ad33ee060be46794a03d033894c9db3a9d6c1a0f

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-01-05 14:08 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-18 14:52 [PATCH v2 0/3] Regulator adjustments for OnePlus 6 and 6T David Heidelberg via B4 Relay
2025-11-18 14:52 ` [PATCH v2 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on David Heidelberg via B4 Relay
2025-11-18 15:02   ` Konrad Dybcio
2025-11-18 14:52 ` [PATCH v2 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on David Heidelberg via B4 Relay
2025-11-18 15:02   ` Konrad Dybcio
2025-11-18 14:52 ` [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on David Heidelberg via B4 Relay
2025-11-18 15:02   ` Konrad Dybcio
2026-01-05 14:07 ` [PATCH v2 0/3] Regulator adjustments for OnePlus 6 and 6T Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®