From: Matthew W Carlis <mattc@purestorage.com>
To: tariqt@nvidia.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, dtatulea@nvidia.com,
edumazet@google.com, gal@nvidia.com, kuba@kernel.org,
leon@kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, mattc@purestorage.com,
mbloch@nvidia.com, moshe@nvidia.com, netdev@vger.kernel.org,
pabeni@redhat.com, richardcochran@gmail.com, saeedm@nvidia.com
Subject: Re: [PATCH net-next 1/5] net/mlx5: Refactor EEPROM query error handling to return status separately
Date: Wed, 19 Nov 2025 16:11:15 -0700 [thread overview]
Message-ID: <20251119231115.8722-1-mattc@purestorage.com> (raw)
In-Reply-To: <1763415729-1238421-2-git-send-email-tariqt@nvidia.com>
On Mon, 17 Nov 2025 23:42:05 +0200, Gal Pressman said
> Matthew and Jakub reported [1] issues where inventory automation tools
> are calling EEPROM query repeatedly on a port that doesn't have an SFP
> connected, resulting in millions of error prints.
I'm not very familiar with the networking stack in general, but I poked around a
little trying to be able to come up with a meaningful review. I noticed that in
ethtool there are two methods registered for "ethtool -m".. Looks like it first
prefers a netlink method, but also may fall back on an ioctl implementation.
Will users who end up in the ioctl path expect to see the kernel message? In the
case of users who run "ethtool -m" on a device without a transceiver installed I
think we should expect to see something as follows? (Is this correct?)
$ ethtool -m ethx
"netlink error: mlx5: Query module eeprom by page failed, read xxx bytes, err xxx, status xxx"
Thank you for helping on this issue.
-Matt
next prev parent reply other threads:[~2025-11-19 23:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 21:42 [PATCH net-next 0/5] net/mlx5: misc changes 2025-11-17 Tariq Toukan
2025-11-17 21:42 ` [PATCH net-next 1/5] net/mlx5: Refactor EEPROM query error handling to return status separately Tariq Toukan
2025-11-19 23:11 ` Matthew W Carlis [this message]
2025-11-23 7:11 ` Gal Pressman
2025-11-17 21:42 ` [PATCH net-next 2/5] net/mlx5e: Recover SQ on excessive PTP TX timestamp delta Tariq Toukan
2025-11-17 21:42 ` [PATCH net-next 3/5] net/mlx5: Remove redundant bw_share minimal value assignment Tariq Toukan
2025-11-17 21:42 ` [PATCH net-next 4/5] net/mlx5: Abort new commands if all command slots are stalled Tariq Toukan
2025-11-17 21:42 ` [PATCH net-next 5/5] net/mlx5: Use EOPNOTSUPP instead of ENOTSUPP Tariq Toukan
2025-11-19 3:20 ` [PATCH net-next 0/5] net/mlx5: misc changes 2025-11-17 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119231115.8722-1-mattc@purestorage.com \
--to=mattc@purestorage.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®