* [PATCH] perf: replace strcpy() with strncpy() in util/jitdump.c
@ 2025-11-20 4:16 Hrishikesh Suresh
2025-11-21 20:02 ` Namhyung Kim
0 siblings, 1 reply; 2+ messages in thread
From: Hrishikesh Suresh @ 2025-11-20 4:16 UTC (permalink / raw)
To: acme
Cc: peterz, mingo, namhyung, mark.rutland, alexander.shishkin, jolsa,
irogers, adrian.hunter, james.clark, linux-perf-users,
linux-kernel, Hrishikesh Suresh
Usage of strcpy() can lead to buffer overflows. Therefore, it has been
replaced with strncpy(). The output file path is provided as a parameter
and might be restricted by command-line by default. But this defensive
patch will prevent any potential overflow, making the code more robust
against future changes in input handling.
Testing:
- ran perf test from tools/perf and did not observe any regression with
the earlier code
Signed-off-by: Hrishikesh Suresh <hrishikesh123s@gmail.com>
---
tools/perf/util/jitdump.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/jitdump.c b/tools/perf/util/jitdump.c
index b062b1f234b6..496ca2d2bfdb 100644
--- a/tools/perf/util/jitdump.c
+++ b/tools/perf/util/jitdump.c
@@ -233,7 +233,8 @@ jit_open(struct jit_buf_desc *jd, const char *name)
/*
* keep dirname for generating files and mmap records
*/
- strcpy(jd->dir, name);
+ strncpy(jd->dir, name, PATH_MAX);
+ jd->dir[PATH_MAX - 1] = '\0';
dirname(jd->dir);
free(buf);
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] perf: replace strcpy() with strncpy() in util/jitdump.c
2025-11-20 4:16 [PATCH] perf: replace strcpy() with strncpy() in util/jitdump.c Hrishikesh Suresh
@ 2025-11-21 20:02 ` Namhyung Kim
0 siblings, 0 replies; 2+ messages in thread
From: Namhyung Kim @ 2025-11-21 20:02 UTC (permalink / raw)
To: acme, Hrishikesh Suresh
Cc: peterz, mingo, mark.rutland, alexander.shishkin, jolsa, irogers,
adrian.hunter, james.clark, linux-perf-users, linux-kernel
On Wed, 19 Nov 2025 23:16:10 -0500, Hrishikesh Suresh wrote:
> Usage of strcpy() can lead to buffer overflows. Therefore, it has been
> replaced with strncpy(). The output file path is provided as a parameter
> and might be restricted by command-line by default. But this defensive
> patch will prevent any potential overflow, making the code more robust
> against future changes in input handling.
>
> Testing:
> - ran perf test from tools/perf and did not observe any regression with
> the earlier code
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-21 20:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-20 4:16 [PATCH] perf: replace strcpy() with strncpy() in util/jitdump.c Hrishikesh Suresh
2025-11-21 20:02 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®