[PATCH 0/2] PCI/pwrctrl: tc9563: A couple of fixes

[PATCH 0/2] PCI/pwrctrl: tc9563: A couple of fixes

[Manivannan Sadhasivam]

Hi Bjorn,

Please squash these fixes with the offending commit.

- Mani

Manivannan Sadhasivam (2):
  PCI/pwrctrl: tc9563: Enforce I2C dependency
  PCI/pwrctrl: tc9563: Remove unnecessary semicolons

 drivers/pci/pwrctrl/Kconfig              | 1 +
 drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.48.1

[PATCH 1/2] PCI/pwrctrl: tc9563: Enforce I2C dependency

[Manivannan Sadhasivam]

This driver depends on the I2C interface to configure the switch. So
enforce the dependency in Kconfig so that the I2C interface is selected
appropriately. This also avoids the build issues like the one reported by
the LKP bot:

   alpha-linux-ld: alpha-linux-ld: DWARF error: could not find abbrev number 14070
   drivers/pci/pwrctrl/pci-pwrctrl-tc9563.o: in function `tc9563_pwrctrl_remove':
>> (.text+0x4c): undefined reference to `i2c_unregister_device'
>> alpha-linux-ld: (.text+0x50): undefined reference to `i2c_unregister_device'
>> alpha-linux-ld: (.text+0x60): undefined reference to `i2c_put_adapter'
   alpha-linux-ld: (.text+0x64): undefined reference to `i2c_put_adapter'

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202511200555.M4TX84jK-lkp@intel.com
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
---
 drivers/pci/pwrctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/pwrctrl/Kconfig b/drivers/pci/pwrctrl/Kconfig
index b43fdf052d37..e0f999f299bb 100644
--- a/drivers/pci/pwrctrl/Kconfig
+++ b/drivers/pci/pwrctrl/Kconfig
@@ -26,6 +26,7 @@ config PCI_PWRCTRL_TC9563
 	tristate "PCI Power Control driver for TC9563 PCIe switch"
 	select PCI_PWRCTRL
 	default m if ARCH_QCOM
+	depends on I2C
 	help
 	  Say Y here to enable the PCI Power Control driver of TC9563 PCIe
 	  switch.
-- 
2.48.1

Re: [PATCH 1/2] PCI/pwrctrl: tc9563: Enforce I2C dependency

[Bartosz Golaszewski]

On Thu, 20 Nov 2025 07:51:15 +0100, Manivannan Sadhasivam
<manivannan.sadhasivam@oss.qualcomm.com> said:
> This driver depends on the I2C interface to configure the switch. So
> enforce the dependency in Kconfig so that the I2C interface is selected
> appropriately. This also avoids the build issues like the one reported by
> the LKP bot:
>
>    alpha-linux-ld: alpha-linux-ld: DWARF error: could not find abbrev number 14070
>    drivers/pci/pwrctrl/pci-pwrctrl-tc9563.o: in function `tc9563_pwrctrl_remove':
>>> (.text+0x4c): undefined reference to `i2c_unregister_device'
>>> alpha-linux-ld: (.text+0x50): undefined reference to `i2c_unregister_device'
>>> alpha-linux-ld: (.text+0x60): undefined reference to `i2c_put_adapter'
>    alpha-linux-ld: (.text+0x64): undefined reference to `i2c_put_adapter'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202511200555.M4TX84jK-lkp@intel.com
> Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
> ---
>  drivers/pci/pwrctrl/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/pwrctrl/Kconfig b/drivers/pci/pwrctrl/Kconfig
> index b43fdf052d37..e0f999f299bb 100644
> --- a/drivers/pci/pwrctrl/Kconfig
> +++ b/drivers/pci/pwrctrl/Kconfig
> @@ -26,6 +26,7 @@ config PCI_PWRCTRL_TC9563
>  	tristate "PCI Power Control driver for TC9563 PCIe switch"
>  	select PCI_PWRCTRL
>  	default m if ARCH_QCOM
> +	depends on I2C
>  	help
>  	  Say Y here to enable the PCI Power Control driver of TC9563 PCIe
>  	  switch.
> --
> 2.48.1
>
>

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

[PATCH 2/2] PCI/pwrctrl: tc9563: Remove unnecessary semicolons

[Manivannan Sadhasivam]

As reported by the LKP bot, semicolons are not needed at the end of the
switch and if blocks. Hence, remove them.

This fixes the below cocci warnings:

  cocci warnings: (new ones prefixed by >>)
  >> drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c:351:2-3: Unneeded semicolon
     drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c:414:2-3: Unneeded semicolon
     drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c:316:2-3: Unneeded semicolon

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202511200555.M4TX84jK-lkp@intel.com
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
---
 drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c
index 46339a23204f..ec423432ac65 100644
--- a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c
+++ b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c
@@ -313,7 +313,7 @@ static int tc9563_pwrctrl_set_tx_amplitude(struct tc9563_pwrctrl_ctx *ctx,
 		break;
 	default:
 		return -EINVAL;
-	};
+	}
 
 	struct tc9563_pwrctrl_reg_setting tx_amp_seq[] = {
 		{TC9563_PORT_ACCESS_ENABLE, port_access},
@@ -348,7 +348,7 @@ static int tc9563_pwrctrl_disable_dfe(struct tc9563_pwrctrl_ctx *ctx,
 		break;
 	default:
 		return -EINVAL;
-	};
+	}
 
 	struct tc9563_pwrctrl_reg_setting disable_dfe_seq[] = {
 		{TC9563_PORT_ACCESS_ENABLE, port_access},
@@ -411,7 +411,7 @@ static int tc9563_pwrctrl_parse_device_dt(struct tc9563_pwrctrl_ctx *ctx, struct
 	if (!of_device_is_available(node)) {
 		cfg->disable_port = true;
 		return 0;
-	};
+	}
 
 	ret = of_property_read_u32(node, "aspm-l0s-entry-delay-ns", &cfg->l0s_delay);
 	if (ret && ret != -EINVAL)
-- 
2.48.1

Re: [PATCH 2/2] PCI/pwrctrl: tc9563: Remove unnecessary semicolons

[Bartosz Golaszewski]

On Thu, 20 Nov 2025 07:51:16 +0100, Manivannan Sadhasivam
<manivannan.sadhasivam@oss.qualcomm.com> said:
> As reported by the LKP bot, semicolons are not needed at the end of the
> switch and if blocks. Hence, remove them.
>
> This fixes the below cocci warnings:
>
>   cocci warnings: (new ones prefixed by >>)
>   >> drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c:351:2-3: Unneeded semicolon
>      drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c:414:2-3: Unneeded semicolon
>      drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c:316:2-3: Unneeded semicolon
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202511200555.M4TX84jK-lkp@intel.com
> Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
> ---
>  drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH 0/2] PCI/pwrctrl: tc9563: A couple of fixes

[Bjorn Helgaas]

On Thu, Nov 20, 2025 at 12:21:14PM +0530, Manivannan Sadhasivam wrote:
> Hi Bjorn,
> 
> Please squash these fixes with the offending commit.
> 
> - Mani
> 
> Manivannan Sadhasivam (2):
>   PCI/pwrctrl: tc9563: Enforce I2C dependency
>   PCI/pwrctrl: tc9563: Remove unnecessary semicolons
> 
>  drivers/pci/pwrctrl/Kconfig              | 1 +
>  drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 6 +++---
>  2 files changed, 4 insertions(+), 3 deletions(-)

Squashed into pci/pwrctrl-tc9563, thanks!