* Subject: [PATCH] nvme: Call nvme_setup_cmd before check host_pathing_error.
[not found] <CGME20251120071302epcms2p79062e2da03d95e64d78266f5bdad3f7b@epcms2p7>
@ 2025-11-20 7:13 ` 전민식
0 siblings, 0 replies; only message in thread
From: 전민식 @ 2025-11-20 7:13 UTC (permalink / raw)
To: linux-kernel, linux-nvme, linux-arm-kernel, asahi
Cc: sven, j, neal, kbusch, axboe, hch, sagi, justin.tee,
nareshgottumukkala83, paul.ely, kch, 이승철
From f77ad0431e08d66be940aaf31d7d79780ac3a3da Mon Sep 17 00:00:00 2001
From: Minsik Jeon <hmi.jeon@samsung.com>
Date: Thu, 20 Nov 2025 14:33:11 +0900
Subject: [PATCH] nvme: Call nvme_setup_cmd before check host_pathing_error.
we were checking host_pathing_error before calling nvme_setup_cmd().
This is caused the command setup to be skipped entirely when a pathing
error occurred, making it impossible to trace the nvme command via
trace_cmd nvme_complete_rq().
As a result, when nvme_complete_rq() logged a completion with cmdid=0,
it was impossible to correlate the completion with the nvme command
request.
This patch reorders the logic to first call nvme_setup_cmd(), then
perform the host_pathing_error check.
trace_nvme_complete_rq()
nvme6: qid=0, cmdid=0, res=0x0, retries=0, flags=0x2, status=0x370
Acked-by: Kibeom Son <kibeom.son@samsung.com>
Co-authored-by: Beomsoo Kim <beomsooo.kim@samsung.com>
Co-authored-by: Eunsoo Lee <euns212.lee@samsung.com>
Co-authored-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Signed-off-by: Minsik Jeon <hmi.jeon@samsung.com>
---
drivers/nvme/host/apple.c | 6 +++---
drivers/nvme/host/fc.c | 8 ++++----
drivers/nvme/host/pci.c | 8 ++++----
drivers/nvme/host/rdma.c | 8 ++++----
drivers/nvme/host/tcp.c | 8 ++++----
drivers/nvme/target/loop.c | 6 +++---
6 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/nvme/host/apple.c b/drivers/nvme/host/apple.c
index f35d3f71d..4e3b0ded9 100644
--- a/drivers/nvme/host/apple.c
+++ b/drivers/nvme/host/apple.c
@@ -783,13 +783,13 @@ static blk_status_t apple_nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
if (unlikely(!READ_ONCE(q->enabled)))
return BLK_STS_IOERR;
- if (!nvme_check_ready(&anv->ctrl, req, true))
- return nvme_fail_nonready_command(&anv->ctrl, req);
-
ret = nvme_setup_cmd(ns, req);
if (ret)
return ret;
+ if (!nvme_check_ready(&anv->ctrl, req, true))
+ return nvme_fail_nonready_command(&anv->ctrl, req);
+
if (blk_rq_nr_phys_segments(req)) {
ret = apple_nvme_map_data(anv, req, cmnd);
if (ret)
diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index 03987f497..ad8402d3a 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -2764,14 +2764,14 @@ nvme_fc_queue_rq(struct blk_mq_hw_ctx *hctx,
u32 data_len;
blk_status_t ret;
- if (ctrl->rport->remoteport.port_state != FC_OBJSTATE_ONLINE ||
- !nvme_check_ready(&queue->ctrl->ctrl, rq, queue_ready))
- return nvme_fail_nonready_command(&queue->ctrl->ctrl, rq);
-
ret = nvme_setup_cmd(ns, rq);
if (ret)
return ret;
+ if (ctrl->rport->remoteport.port_state != FC_OBJSTATE_ONLINE ||
+ !nvme_check_ready(&queue->ctrl->ctrl, rq, queue_ready))
+ return nvme_fail_nonready_command(&queue->ctrl->ctrl, rq);
+
/*
* nvme core doesn't quite treat the rq opaquely. Commands such
* as WRITE ZEROES will return a non-zero rq payload_bytes yet
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 72fb675a6..d57347eb0 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1149,10 +1149,6 @@ static blk_status_t nvme_prep_rq(struct request *req)
iod->total_len = 0;
iod->meta_total_len = 0;
- ret = nvme_setup_cmd(req->q->queuedata, req);
- if (ret)
- return ret;
-
if (blk_rq_nr_phys_segments(req)) {
ret = nvme_map_data(req);
if (ret)
@@ -1191,6 +1187,10 @@ static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
if (unlikely(!test_bit(NVMEQ_ENABLED, &nvmeq->flags)))
return BLK_STS_IOERR;
+ ret = nvme_setup_cmd(req->q->queuedata, req);
+ if (ret)
+ return ret;
+
if (unlikely(!nvme_check_ready(&dev->ctrl, req, true)))
return nvme_fail_nonready_command(&dev->ctrl, req);
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 190a4cfa8..266531fda 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -2005,6 +2005,10 @@ static blk_status_t nvme_rdma_queue_rq(struct blk_mq_hw_ctx *hctx,
WARN_ON_ONCE(rq->tag < 0);
+ ret = nvme_setup_cmd(ns, rq);
+ if (ret)
+ return ret;
+
if (!nvme_check_ready(&queue->ctrl->ctrl, rq, queue_ready))
return nvme_fail_nonready_command(&queue->ctrl->ctrl, rq);
@@ -2020,10 +2024,6 @@ static blk_status_t nvme_rdma_queue_rq(struct blk_mq_hw_ctx *hctx,
ib_dma_sync_single_for_cpu(dev, sqe->dma,
sizeof(struct nvme_command), DMA_TO_DEVICE);
- ret = nvme_setup_cmd(ns, rq);
- if (ret)
- goto unmap_qe;
-
nvme_start_request(rq);
if (IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY) &&
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 9a96df1a5..d847ca0d6 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -2704,10 +2704,6 @@ static blk_status_t nvme_tcp_setup_cmd_pdu(struct nvme_ns *ns,
u8 hdgst = nvme_tcp_hdgst_len(queue), ddgst = 0;
blk_status_t ret;
- ret = nvme_setup_cmd(ns, rq);
- if (ret)
- return ret;
-
req->state = NVME_TCP_SEND_CMD_PDU;
req->status = cpu_to_le16(NVME_SC_SUCCESS);
req->offset = 0;
@@ -2767,6 +2763,10 @@ static blk_status_t nvme_tcp_queue_rq(struct blk_mq_hw_ctx *hctx,
bool queue_ready = test_bit(NVME_TCP_Q_LIVE, &queue->flags);
blk_status_t ret;
+ ret = nvme_setup_cmd(ns, rq);
+ if (ret)
+ return ret;
+
if (!nvme_check_ready(&queue->ctrl->ctrl, rq, queue_ready))
return nvme_fail_nonready_command(&queue->ctrl->ctrl, rq);
diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c
index f85a8441b..b2dcbea2b 100644
--- a/drivers/nvme/target/loop.c
+++ b/drivers/nvme/target/loop.c
@@ -140,13 +140,13 @@ static blk_status_t nvme_loop_queue_rq(struct blk_mq_hw_ctx *hctx,
bool queue_ready = test_bit(NVME_LOOP_Q_LIVE, &queue->flags);
blk_status_t ret;
- if (!nvme_check_ready(&queue->ctrl->ctrl, req, queue_ready))
- return nvme_fail_nonready_command(&queue->ctrl->ctrl, req);
-
ret = nvme_setup_cmd(ns, req);
if (ret)
return ret;
+ if (!nvme_check_ready(&queue->ctrl->ctrl, req, queue_ready))
+ return nvme_fail_nonready_command(&queue->ctrl->ctrl, req);
+
nvme_start_request(req);
iod->cmd.common.flags |= NVME_CMD_SGL_METABUF;
iod->req.port = queue->ctrl->port;
--
2.47.1
^ permalink raw reply [flat|nested] only message in thread