From: Avadhut Naik <avadhut.naik@amd.com>
To: <x86@kernel.org>
Cc: <bp@alien8.de>, <gregkh@linuxfoundation.org>,
<yazen.ghannam@amd.com>, <tony.luck@intel.com>,
<qiuxu.zhuo@intel.com>, <Smita.KoralahalliChannabasappa@amd.com>,
<linux-kernel@vger.kernel.org>, <avadhut.naik@amd.com>
Subject: [PATCH 1/2] x86/mce: Do not clear bank's poll bit in mce_poll_banks on AMD SMCA systems
Date: Fri, 21 Nov 2025 19:04:04 +0000 [thread overview]
Message-ID: <20251121190542.2447913-2-avadhut.naik@amd.com> (raw)
In-Reply-To: <20251121190542.2447913-1-avadhut.naik@amd.com>
Currently, when a CMCI storm, detected on a Machine Check bank, subsides,
the bank's corresponding bit in the mce_poll_banks per-CPU variable is
cleared unconditionally through cmci_storm_end().
On AMD SMCA systems, this essentially disables polling on that particular
bank on that CPU. Consequently, any subsequent correctable errors or
storms will not be logged.
Since AMD SMCA systems allow banks to be managed by both polling and
interrupts, the polling banks bitmap for a CPU, i.e., mce_poll_banks,
should not be modified when a storm subsides.
Fixes: 7eae17c4add5 ("x86/mce: Add per-bank CMCI storm mitigation")
Cc: stable@vger.kernel.org
Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
---
arch/x86/kernel/cpu/mce/threshold.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mce/threshold.c b/arch/x86/kernel/cpu/mce/threshold.c
index eebaa633df80..f19dd5bc2969 100644
--- a/arch/x86/kernel/cpu/mce/threshold.c
+++ b/arch/x86/kernel/cpu/mce/threshold.c
@@ -98,7 +98,8 @@ void cmci_storm_end(unsigned int bank)
{
struct mca_storm_desc *storm = this_cpu_ptr(&storm_desc);
- __clear_bit(bank, this_cpu_ptr(mce_poll_banks));
+ if (!mce_flags.amd_threshold)
+ __clear_bit(bank, this_cpu_ptr(mce_poll_banks));
storm->banks[bank].history = 0;
storm->banks[bank].in_storm_mode = false;
--
2.43.0
next prev parent reply other threads:[~2025-11-21 19:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 19:04 [PATCH 0/2] Interrupt Storm support " Avadhut Naik
2025-11-21 19:04 ` Avadhut Naik [this message]
2025-11-21 21:05 ` [tip: ras/core] x86/mce: Do not clear bank's poll bit in mce_poll_banks " tip-bot2 for Avadhut Naik
2025-11-21 19:04 ` [PATCH 2/2] x86/mce: Handle AMD threshold interrupt storms Avadhut Naik
2025-11-21 21:05 ` [tip: ras/core] " tip-bot2 for Smita Koralahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121190542.2447913-2-avadhut.naik@amd.com \
--to=avadhut.naik@amd.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®