mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH V1] arm64: dts: qcom: talos: Correct UFS clocks ordering
@ 2025-11-26 13:11 Pradeep P V K
  2025-11-26 14:39 ` Dmitry Baryshkov
  2025-12-17 23:07 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Pradeep P V K @ 2025-11-26 13:11 UTC (permalink / raw)
  To: andersson, konradybcio, robh, krzk+dt, conor+dt, manivannan.sadhasivam
  Cc: quic_sayalil, nitin.rawat, linux-arm-msm, devicetree,
	linux-kernel, Pradeep P V K, stable

The current UFS clocks does not align with their respective names,
causing the ref_clk to be set to an incorrect frequency as below,
which results in command timeouts.

ufshcd-qcom 1d84000.ufshc: invalid ref_clk setting = 300000000

This commit fixes the issue by properly reordering the UFS clocks to
match their names.

Fixes: ea172f61f4fd ("arm64: dts: qcom: qcs615: Fix up UFS clocks")
Cc: stable@vger.kernel.org
Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/talos.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
index d1dbfa3bd81c..95d26e313622 100644
--- a/arch/arm64/boot/dts/qcom/talos.dtsi
+++ b/arch/arm64/boot/dts/qcom/talos.dtsi
@@ -1399,10 +1399,10 @@
 				 <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>,
 				 <&gcc GCC_UFS_PHY_AHB_CLK>,
 				 <&gcc GCC_UFS_PHY_UNIPRO_CORE_CLK>,
-				 <&gcc GCC_UFS_PHY_ICE_CORE_CLK>,
 				 <&rpmhcc RPMH_CXO_CLK>,
 				 <&gcc GCC_UFS_PHY_TX_SYMBOL_0_CLK>,
-				 <&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>;
+				 <&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>,
+				 <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
 			clock-names = "core_clk",
 				      "bus_aggr_clk",
 				      "iface_clk",
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH V1] arm64: dts: qcom: talos: Correct UFS clocks ordering
  2025-11-26 13:11 [PATCH V1] arm64: dts: qcom: talos: Correct UFS clocks ordering Pradeep P V K
@ 2025-11-26 14:39 ` Dmitry Baryshkov
  2025-12-17 23:07 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2025-11-26 14:39 UTC (permalink / raw)
  To: Pradeep P V K
  Cc: andersson, konradybcio, robh, krzk+dt, conor+dt,
	manivannan.sadhasivam, quic_sayalil, nitin.rawat, linux-arm-msm,
	devicetree, linux-kernel, stable

On Wed, Nov 26, 2025 at 06:41:46PM +0530, Pradeep P V K wrote:
> The current UFS clocks does not align with their respective names,
> causing the ref_clk to be set to an incorrect frequency as below,
> which results in command timeouts.
> 
> ufshcd-qcom 1d84000.ufshc: invalid ref_clk setting = 300000000
> 
> This commit fixes the issue by properly reordering the UFS clocks to
> match their names.
> 
> Fixes: ea172f61f4fd ("arm64: dts: qcom: qcs615: Fix up UFS clocks")
> Cc: stable@vger.kernel.org
> Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/talos.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH V1] arm64: dts: qcom: talos: Correct UFS clocks ordering
  2025-11-26 13:11 [PATCH V1] arm64: dts: qcom: talos: Correct UFS clocks ordering Pradeep P V K
  2025-11-26 14:39 ` Dmitry Baryshkov
@ 2025-12-17 23:07 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2025-12-17 23:07 UTC (permalink / raw)
  To: konradybcio, robh, krzk+dt, conor+dt, manivannan.sadhasivam,
	Pradeep P V K
  Cc: quic_sayalil, nitin.rawat, linux-arm-msm, devicetree,
	linux-kernel, stable


On Wed, 26 Nov 2025 18:41:46 +0530, Pradeep P V K wrote:
> The current UFS clocks does not align with their respective names,
> causing the ref_clk to be set to an incorrect frequency as below,
> which results in command timeouts.
> 
> ufshcd-qcom 1d84000.ufshc: invalid ref_clk setting = 300000000
> 
> This commit fixes the issue by properly reordering the UFS clocks to
> match their names.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: talos: Correct UFS clocks ordering
      commit: 8bb3754909cde5df4f8c1012bde220b97d8ee3bc

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-12-17 22:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-26 13:11 [PATCH V1] arm64: dts: qcom: talos: Correct UFS clocks ordering Pradeep P V K
2025-11-26 14:39 ` Dmitry Baryshkov
2025-12-17 23:07 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®