From: Huang Shijie <shijie@os.amperecomputing.com>
To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org
Cc: patches@amperecomputing.com, cl@linux.com,
Shubhang@os.amperecomputing.com, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
linux-kernel@vger.kernel.org, vschneid@redhat.com,
vineethr@linux.ibm.com,
Huang Shijie <shijie@os.amperecomputing.com>
Subject: [PATCH v2 3/3] sched/fair: update rq->avg_idle for the delay-dequeue task
Date: Thu, 27 Nov 2025 13:03:53 +0800 [thread overview]
Message-ID: <20251127050353.1089724-4-shijie@os.amperecomputing.com> (raw)
In-Reply-To: <20251127050353.1089724-1-shijie@os.amperecomputing.com>
When a delay-dequeue task is woken and requeued back, it may
becomes eligible, and changes the CPU idle status,
so we need to update the rq->avg_idle for it.
This patch adds a new parameter for requeue_delayed_entity(),
and updates the rq->avg_idle as needed.
Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com>
---
kernel/sched/fair.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index c1a8fa043156..2ac630ecdbd5 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5208,7 +5208,7 @@ static void check_enqueue_throttle(struct cfs_rq *cfs_rq);
static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq);
static void
-requeue_delayed_entity(struct sched_entity *se);
+requeue_delayed_entity(struct rq *rq, struct sched_entity *se);
static void
enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)
@@ -6835,7 +6835,7 @@ static int sched_idle_cpu(int cpu)
}
static void
-requeue_delayed_entity(struct sched_entity *se)
+requeue_delayed_entity(struct rq *rq, struct sched_entity *se)
{
struct cfs_rq *cfs_rq = cfs_rq_of(se);
@@ -6862,6 +6862,10 @@ requeue_delayed_entity(struct sched_entity *se)
}
update_load_avg(cfs_rq, se, 0);
+
+ if (entity_eligible(cfs_rq, se))
+ update_rq_avg_idle(rq);
+
clear_delayed(se);
}
@@ -6894,7 +6898,7 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
util_est_enqueue(&rq->cfs, p);
if (flags & ENQUEUE_DELAYED) {
- requeue_delayed_entity(se);
+ requeue_delayed_entity(rq, se);
return;
}
@@ -6912,7 +6916,7 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
for_each_sched_entity(se) {
if (se->on_rq) {
if (se->sched_delayed)
- requeue_delayed_entity(se);
+ requeue_delayed_entity(rq, se);
break;
}
cfs_rq = cfs_rq_of(se);
--
2.40.1
next prev parent reply other threads:[~2025-11-27 5:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 5:03 [PATCH v2 0/3] sched: update the rq->avg_idle when a task is moved to an idle CPU Huang Shijie
2025-11-27 5:03 ` [PATCH v2 1/3] sched/fair: set rq->idle_stamp at the end of the sched_balance_newidle Huang Shijie
2025-11-27 5:03 ` [PATCH v2 2/3] sched: update the rq->avg_idle when a task is moved to an idle CPU Huang Shijie
2025-11-27 5:03 ` Huang Shijie [this message]
2025-11-27 5:51 ` [PATCH v2 3/3] sched/fair: update rq->avg_idle for the delay-dequeue task K Prateek Nayak
2025-11-27 7:59 ` Shijie Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127050353.1089724-4-shijie@os.amperecomputing.com \
--to=shijie@os.amperecomputing.com \
--cc=Shubhang@os.amperecomputing.com \
--cc=bsegall@google.com \
--cc=cl@linux.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=patches@amperecomputing.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vineethr@linux.ibm.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®