From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Huang Shijie <shijie@os.amperecomputing.com>, <mingo@redhat.com>,
<peterz@infradead.org>, <juri.lelli@redhat.com>,
<vincent.guittot@linaro.org>
Cc: <patches@amperecomputing.com>, <cl@linux.com>,
<Shubhang@os.amperecomputing.com>, <dietmar.eggemann@arm.com>,
<rostedt@goodmis.org>, <bsegall@google.com>, <mgorman@suse.de>,
<linux-kernel@vger.kernel.org>, <vschneid@redhat.com>,
<vineethr@linux.ibm.com>
Subject: Re: [PATCH v2 3/3] sched/fair: update rq->avg_idle for the delay-dequeue task
Date: Thu, 27 Nov 2025 11:21:15 +0530 [thread overview]
Message-ID: <72a32cac-29dc-41b7-a318-84345a55ed45@amd.com> (raw)
In-Reply-To: <20251127050353.1089724-4-shijie@os.amperecomputing.com>
On 11/27/2025 10:33 AM, Huang Shijie wrote:
> When a delay-dequeue task is woken and requeued back, it may
> becomes eligible, and changes the CPU idle status,
> so we need to update the rq->avg_idle for it.
>
> This patch adds a new parameter for requeue_delayed_entity(),
> and updates the rq->avg_idle as needed.
Can't this be solved by moving update_rq_avg_idle() into
enqueue_task() in the previous patch? The only path that can
reenqueue a delayed task from ttwu_runnable() calls
enqueue_task() with ENQUEUE_DELAYED.
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2025-11-27 5:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 5:03 [PATCH v2 0/3] sched: update the rq->avg_idle when a task is moved to an idle CPU Huang Shijie
2025-11-27 5:03 ` [PATCH v2 1/3] sched/fair: set rq->idle_stamp at the end of the sched_balance_newidle Huang Shijie
2025-11-27 5:03 ` [PATCH v2 2/3] sched: update the rq->avg_idle when a task is moved to an idle CPU Huang Shijie
2025-11-27 5:03 ` [PATCH v2 3/3] sched/fair: update rq->avg_idle for the delay-dequeue task Huang Shijie
2025-11-27 5:51 ` K Prateek Nayak [this message]
2025-11-27 7:59 ` Shijie Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72a32cac-29dc-41b7-a318-84345a55ed45@amd.com \
--to=kprateek.nayak@amd.com \
--cc=Shubhang@os.amperecomputing.com \
--cc=bsegall@google.com \
--cc=cl@linux.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=patches@amperecomputing.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shijie@os.amperecomputing.com \
--cc=vincent.guittot@linaro.org \
--cc=vineethr@linux.ibm.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®