[PATCH 1/2] i3c: fix I3C_SDR bit number

[PATCH 1/2] i3c: fix I3C_SDR bit number

[alexandre.belloni]

From: Alexandre Belloni <alexandre.belloni@bootlin.com>

0x31 is decimal 49 and doesn't fit in a 32 bit integer, switch to the
intended decimal 31.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202512020956.Dnz8A2H0-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202512021613.97jVprvJ-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202512021644.lp8ZMSx5-lkp@intel.com/
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 include/linux/i3c/device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h
index ae0662d9d77e..9fcb6410a584 100644
--- a/include/linux/i3c/device.h
+++ b/include/linux/i3c/device.h
@@ -51,7 +51,7 @@ enum i3c_xfer_mode {
 	I3C_HDR_TSP = 1,
 	I3C_HDR_TSL = 2,
 	/* Use for default SDR transfer mode */
-	I3C_SDR = 0x31,
+	I3C_SDR = 31,
 };
 
 /**
-- 
2.52.0

[PATCH 2/2] i3c: document i3c_xfers

[alexandre.belloni]

From: Alexandre Belloni <alexandre.belloni@bootlin.com>

i3c_xfers was left undocumented, document it.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 include/linux/i3c/master.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h
index d0d5b3a9049f..2fd850f4678b 100644
--- a/include/linux/i3c/master.h
+++ b/include/linux/i3c/master.h
@@ -418,7 +418,11 @@ struct i3c_bus {
  * @send_ccc_cmd: send a CCC command
  *		  This method is mandatory.
  * @priv_xfers: do one or several private I3C SDR transfers
- *		This method is mandatory.
+ *		This method is mandatory when i3c_xfers is not implemented. It
+ *		is deprecated.
+ * @i3c_xfers: do one or several I3C SDR or HDR transfers
+ *	       This method is mandatory when priv_xfers is not implemented but
+ *	       should be implemented instead of priv_xfers.
  * @attach_i2c_dev: called every time an I2C device is attached to the bus.
  *		    This is a good place to attach master controller specific
  *		    data to I2C devices.
-- 
2.52.0

Re: [PATCH 2/2] i3c: document i3c_xfers

[Frank Li]

On Tue, Dec 02, 2025 at 04:38:03PM +0100, alexandre.belloni@bootlin.com wrote:
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
> i3c_xfers was left undocumented, document it.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  include/linux/i3c/master.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h
> index d0d5b3a9049f..2fd850f4678b 100644
> --- a/include/linux/i3c/master.h
> +++ b/include/linux/i3c/master.h
> @@ -418,7 +418,11 @@ struct i3c_bus {
>   * @send_ccc_cmd: send a CCC command
>   *		  This method is mandatory.
>   * @priv_xfers: do one or several private I3C SDR transfers
> - *		This method is mandatory.
> + *		This method is mandatory when i3c_xfers is not implemented. It
> + *		is deprecated.
> + * @i3c_xfers: do one or several I3C SDR or HDR transfers
> + *	       This method is mandatory when priv_xfers is not implemented but
> + *	       should be implemented instead of priv_xfers.
>   * @attach_i2c_dev: called every time an I2C device is attached to the bus.
>   *		    This is a good place to attach master controller specific
>   *		    data to I2C devices.
> --
> 2.52.0
>

Re: [PATCH 1/2] i3c: fix I3C_SDR bit number

[Frank Li]

On Tue, Dec 02, 2025 at 04:38:02PM +0100, alexandre.belloni@bootlin.com wrote:
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
> 0x31 is decimal 49 and doesn't fit in a 32 bit integer, switch to the
> intended decimal 31.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512020956.Dnz8A2H0-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202512021613.97jVprvJ-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202512021644.lp8ZMSx5-lkp@intel.com/
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---

Thanks.

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  include/linux/i3c/device.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h
> index ae0662d9d77e..9fcb6410a584 100644
> --- a/include/linux/i3c/device.h
> +++ b/include/linux/i3c/device.h
> @@ -51,7 +51,7 @@ enum i3c_xfer_mode {
>  	I3C_HDR_TSP = 1,
>  	I3C_HDR_TSL = 2,
>  	/* Use for default SDR transfer mode */
> -	I3C_SDR = 0x31,
> +	I3C_SDR = 31,
>  };
>
>  /**
> --
> 2.52.0
>