mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: thermal: qcom-tsens: Remove invalid tab character
@ 2025-12-03 15:24 Rob Herring (Arm)
  2025-12-03 16:43 ` Linus Torvalds
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2025-12-03 15:24 UTC (permalink / raw)
  To: Linus Torvalds, Amit Kucheria, Thara Gopinath, Rafael J. Wysocki,
	Daniel Lezcano, Zhang Rui, Lukasz Luba, Krzysztof Kozlowski,
	Conor Dooley, Akhil P Oommen, Bjorn Andersson, Gaurav Kohli
  Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel

Commit 1ee90870ce79 ("dt-bindings: thermal: tsens: Add QCS8300
compatible") uses a tab character which is illegal in YAML (at the
beginning of a line). The original patch was correct, so this got
corrupted when applied.

Fixes: 1ee90870ce79 ("dt-bindings: thermal: tsens: Add QCS8300 compatible")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Linus, Can you please apply this directly as your tree and next are
broken and that breaks all my automated testing. I raised the issue with
Daniel on Mon, but haven't gotten any response.
---
 Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
index 921b6172d6f0..3c5256b0cd9f 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
@@ -61,7 +61,7 @@ properties:
               - qcom,msm8996-tsens
               - qcom,msm8998-tsens
               - qcom,qcm2290-tsens
-	      - qcom,qcs8300-tsens
+              - qcom,qcs8300-tsens
               - qcom,qcs615-tsens
               - qcom,sa8255p-tsens
               - qcom,sa8775p-tsens
-- 
2.51.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: thermal: qcom-tsens: Remove invalid tab character
  2025-12-03 15:24 [PATCH] dt-bindings: thermal: qcom-tsens: Remove invalid tab character Rob Herring (Arm)
@ 2025-12-03 16:43 ` Linus Torvalds
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2025-12-03 16:43 UTC (permalink / raw)
  To: Rob Herring (Arm)
  Cc: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
	Zhang Rui, Lukasz Luba, Krzysztof Kozlowski, Conor Dooley,
	Akhil P Oommen, Bjorn Andersson, Gaurav Kohli, linux-pm,
	linux-arm-msm, devicetree, linux-kernel

On Wed, 3 Dec 2025 at 07:24, Rob Herring (Arm) <robh@kernel.org> wrote:
>
> Commit 1ee90870ce79 ("dt-bindings: thermal: tsens: Add QCS8300
> compatible") uses a tab character which is illegal in YAML (at the
> beginning of a line).

Applied.

But I want to object to the garbage that is 'yaml' and 'invisible
whitespace has semantics'.

Maybe we can have a "kernel yaml" that just turns tabs into spaces
with 'expand -t 8' and make the rule be that kernel yaml files don't
have to participate in the mindless garbage that is "yaml by the
specs".

Yes, I know it matters for 'make'. That was a mistake too. But at
least we could *fix* the braindamage that is yaml, and we already have
a defined tab width for the kernel anyway.

          Linus

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-03 16:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-03 15:24 [PATCH] dt-bindings: thermal: qcom-tsens: Remove invalid tab character Rob Herring (Arm)
2025-12-03 16:43 ` Linus Torvalds

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®